From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5002EC001DC for ; Mon, 31 Jul 2023 15:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cBb64P6+VXaRV7bJPA8ZwnKu5VUOsJDOV6KqJQWilW4=; b=4bqRmGAnZRc48P gLTm0ETuun9hMwQ/sByOHm9aLvA+YK1A4C7RGvbSTjEbV5Ah8AoIPA7+FiSBTTw9FUeZAM4z2OgjY y4brn/X2nhTjfaF34Jxn6H/Fo/7WeG8U4OQJwrMcD9a8GNIEGLQ2a2weeZEYTuaHCEGfN9P2h1hhe DCjy/i4tEaPIzzFb+IeNb/07U0EfX6UqkPzmaTE99iAHXePjRgTGKep1T7ss0qclrLZ1XgFYujRXL NsP8aO6LNc5Di6Gy7NOMRbmPvyhDeJbx8XUwHAbjYYHGsmz2d+qctgWKzmeTJhRKMlbZ7fLb6I6A8 Q3/Hd4coEtGyuctwqFuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQUVu-00GHTI-2c; Mon, 31 Jul 2023 15:08:50 +0000 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQUVr-00GHLq-2j for linux-arm-kernel@lists.infradead.org; Mon, 31 Jul 2023 15:08:49 +0000 Message-ID: Date: Mon, 31 Jul 2023 11:08:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff Content-Language: en-US To: Christoph Hellwig , Luis Chamberlain , Greg Kroah-Hartman , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ulf Hansson , Yangbo Lu Cc: Daniel Vetter , linux-arm-kernel@lists.infradead.org, open list , linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org References: <20230731083806.453036-1-hch@lst.de> <20230731083806.453036-4-hch@lst.de> From: Joshua Kinard In-Reply-To: <20230731083806.453036-4-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230731_080847_901994_54752AE1 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/31/2023 04:38, Christoph Hellwig wrote: > ds1685_rtc_poweroff is only used externally via symbol_get, which was > only ever intended for very internal symbols like this one. Use > EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used > on EXPORT_SYMBOL_GPL symbols. > > Signed-off-by: Christoph Hellwig > --- > drivers/rtc/rtc-ds1685.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c > index 0f707be0eb87fa..04dbf35cf3b706 100644 > --- a/drivers/rtc/rtc-ds1685.c > +++ b/drivers/rtc/rtc-ds1685.c > @@ -1432,7 +1432,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev) > unreachable(); > } > } > -EXPORT_SYMBOL(ds1685_rtc_poweroff); > +EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff); > /* ----------------------------------------------------------------------- */ > > Acked-by: Joshua Kinard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel