From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81C0AC3DA7F for ; Wed, 7 Aug 2024 17:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MUNN0AugEZ1zPnIu0ewnWkrGOsYCX84PMrFL5jeb/Zc=; b=N841XXxPCv7fqkUChg3D0bJB+N wUrm++Hqgp37hu9/aBRfG+QxhtW4opXsRUwd5kz4+EIOkocak8TGRbbtkr7Ewtk6Lp2wZCukL+xfy x9dJc30fpHDcPkjYeI9HyXSjAix+HIfZVrPScjwsKCoTZgnxvNhfwvl5uvCutGOcHmNQcbvopsS6b FPMk+KdpXwW/8ELloEs5r8gk2FMopezBxkmYp26L5u0pAHLhN90H3vdXTXm8jEw4ofYfNoi5g8ved Q0+VqkU9biA/104Iqssv4nMYD6azXL7SnsccZpp3Yp941sIs1yI07rwstGK36melL6f95AH4ALGat YLFMlLyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbkWi-00000005qF0-32n0; Wed, 07 Aug 2024 17:32:44 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbkW9-00000005q9V-3iMT; Wed, 07 Aug 2024 17:32:11 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1723051927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUNN0AugEZ1zPnIu0ewnWkrGOsYCX84PMrFL5jeb/Zc=; b=AeSpDEItCSMqhZdwouuVi3u6JOcbGyrpEG0X8dpagAL5NtxFRX/x6W636AyRv56IWhlECN s48UEFjA+FONFfb7Q/3BoUorCOOGsT3AnV0A+AXNe2WdHx/TQiACct0E60jAGzc8hwOTMA J8icx/RkkH0Wj+kFsdvm3Xy/zQwJ7mkAXSRZHx8ZR0kumDyYlhyUx73skUGI5xmOSr7KNu QVOTkPKbClTwgJBXYnjWyAZVqwcuRsdlsZbdRs81B1ryfX83HcIZCjbX4oZ6hdBj99TwZv CZaDgUUGzgMKmDtYgfIsCpLcJsDzHQ2NPEJVeoxGC4NflXbUvwS16l5c0eT0EQ== Date: Wed, 07 Aug 2024 19:32:07 +0200 From: Dragan Simic To: Florian Klink Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Kever Yang , Muhammed Efe Cetin , FUKAUMI Naoki , =?UTF-8?Q?Ta?= =?UTF-8?Q?m=C3=A1s_Sz=C5=B1cs?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: rockchip: add rfkill node for M.2 E wifi on orangepi-5-plus In-Reply-To: References: <20240807162001.1737829-1-flokli@flokli.de> <20240807170030.1747381-1-flokli@flokli.de> <4364452.rE2NhlSrgm@diego> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_103210_287924_B9A3B352 X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-08-07 19:28, Florian Klink wrote: > On Wed, Aug 07, 2024 at 07:17:49PM GMT, Heiko Stübner wrote: >> Am Mittwoch, 7. August 2024, 19:15:03 CEST schrieb Dragan Simic: >>> On 2024-08-07 19:00, Florian Klink wrote: >>> > This follows the same logic as 82d40b141a4c ("arm64: dts: rockchip: add >>> > rfkill node for M.2 Key E WiFi on rock-5b"). >>> > >>> > On the orangepi-5-plus, there's also a GPIO pin connecting the WiFi >>> > enable signal inside the M.2 Key E slot. >>> > >>> > The exact GPIO PIN can be validated in the Armbian rk-5.10-rkr4 kernel >>> > rk3588-orangepi-5-plus.dtsi file [1], which contains a `wifi_disable` >>> > node referencing RK_PC4 on &gpio0. >>> > >>> > Signed-off-by: Florian Klink >>> > Tested-by: Florian Klink >>> > Link: >>> > https://github.com/armbian/linux-rockchip/blob/9fbe23c9da24f236c6009f42d3f02c1ffb84c169/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts >>> > [1] >>> >>> Unfortunately, this isn't how the "Link: ..." tag is to be used, or >>> how >>> a reference is to be provided. Please see the patch submission >>> linked >>> below for a correct example of providing links as references. >>> >>> https://lore.kernel.org/linux-rockchip/4449f7d4eead787308300e2d1d37b88c9d1446b2.1717308862.git.dsimic@manjaro.org/T/#u >> >> please also don't post v2 patches as replies to v1. >> Instead start a new mail thread please. >> >> A lot of tooling cannot really find the correct version in such >> multiversion threads. > > sorry for the noise. I sent a v3, addressing the requested changes, as > a > new thread. > > Somewhat offtopic for this patch, but it'd be great if > process/submitting-patches.html could include: > > - A mention of the kernel quotation style for commit ids and subjects > and how to produce them > - A styleguide for how to link to references > - An active discouragement from using --in-reply-to for v2 (which > differs from what `git send-email` proposes). I'd suggest that you go ahead and whip up a new patch that adds those specific instructions to the documentation.