From: colin.king@canonical.com (Colin Ian King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] include/media: fix missing | operator when setting cfg
Date: Wed, 18 Apr 2018 16:24:11 +0100 [thread overview]
Message-ID: <c554a771-e9a9-fe1f-6792-e73f33b08838@canonical.com> (raw)
In-Reply-To: <bafbcf6c-a08d-11ba-af25-655b7cc44e1c@samsung.com>
On 18/04/18 16:23, Sylwester Nawrocki wrote:
> On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote:
>> On 04/18/2018 05:06 PM, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however
>>> this is not being used and cfg is being re-assigned. I believe the
>>> assignment operator should actually be instead the |= operator.
>>>
>>> Detected by CoverityScan, CID#1467987 ("Unused value")
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> Thanks for the patch.
>>
>> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> I forgot to mention that the subject should rather looks something
> like:
>
> "exynos4-is: fimc-lite: : fix missing | operator when setting cfg"
>
Oops, shall I re-send?
next prev parent reply other threads:[~2018-04-18 15:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180418150622epcas4p4be934b89937c0e50a2f236116c02d7cb@epcas4p4.samsung.com>
2018-04-18 15:06 ` [PATCH] [media] include/media: fix missing | operator when setting cfg Colin King
2018-04-18 15:20 ` Sylwester Nawrocki
2018-04-18 15:23 ` Sylwester Nawrocki
2018-04-18 15:24 ` Colin Ian King [this message]
2018-04-18 15:27 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c554a771-e9a9-fe1f-6792-e73f33b08838@canonical.com \
--to=colin.king@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox