From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD105C5475B for ; Fri, 8 Mar 2024 10:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:From: References:Cc:To:Subject:Date:Message-ID:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Y9skTghysaCLzuS3J5EhhN7V+mZZhzjgTZEuWPoF4bE=; b=Ou6DKhAB/ey4/wXsusIdt6QNaI 90i/1RBA8uUmieyxrsvJbgmEB3CIT4IKYKvmeJ/xjGgPpPYowSo9XuopsoG6pCFNvVL7tjURr4oXd nKto5hHx118R5aeCFpR5upmOGgKWsr86ZMMw8htsIBcNqHEj2ILoEbClM+TOyBYtYsqrl/ghP9mQ9 DdYKe3iZ15ReQ2CuY6o/yDyMKp4DgP5j0WSXozXRmQoKpuzDojynwv/sRhEgqUB7C/vDHD7K1DAZt NTWVyNDlh5eo9GoZkx8Tg54WhA83eO2SXgaJJBTbaR2UyPnczB4g8gf9kyM4TbSizfZw5RMp95t+z gTJ/Oc3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riXLn-00000008jyx-2yK8; Fri, 08 Mar 2024 10:21:15 +0000 Received: from mail-db5eur02on20601.outbound.protection.outlook.com ([2a01:111:f403:2608::601] helo=EUR02-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riXLk-00000008jwb-0amR for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 10:21:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQcrnemzTornTPjbDzUNWRM11nRU5aRd5TPp4NjIRMqf9ezF1k7vGHxTxJgdfR5JNIidhN5fa3x0mN+g1ew/D1L3aiHXBG+3Ufr2JhIW9/jSvg5dwcdOFPToSKdImD6q2WjPT7JcIPJxPNK7VW06FmzfoU9CGW1OLoR4Be1icW3GkVMSveTADdey/GKK5g9RehBaYyJz1uvXLgs5FANCZGDdNvNLqq3pbVsESerK90EWhVAqR/Azyfj/jgtkLyIIUDa5LpupzAUSiNCCgrd3TUqEraPUeotCtjNnPr3hL9erU57kd2/n1TM/Zp6mH4NfQkCINODO4blmjHOXT/RE0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SmLp/zJwj4/bZCIFeQbbmnX2VI3Kwlh8WvwR3EC32vo=; b=nssZCMgqFqGbkFRggYRdT02FWKGLyrSBFREQi3M524VMrxAkRHoTqGPDDyhUOs8P8UUeEOjJjs11rKvxrEjHKLThmv6xAKjW4iORjGtYSrVD1o+S+8/D2Y8mvzsfL/o/MauweLzlRtZVJvWJml+OCayOXppCg0rU9j6Nvy9eV2nP75T6YMUeYaSn5EyD9P5cfjG8erJo0i/ZhM3B8CqwoLXSm4jNduruFtBt+aky1S61z2TAwraYhZIS6pCGFMFLyIflx9NG+4KLFap26XO5/N3psFGJVTjzCnC6aths6KeV5p822oO6Urc4GzMLOc3RAa2UJsqMGfj1U7tOndx9Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SmLp/zJwj4/bZCIFeQbbmnX2VI3Kwlh8WvwR3EC32vo=; b=OvPI/VYGj72OMJ3HJH129hlT4XSa54SM+4CGAXTkq40T/7IXInB2hJD8oK5WcmPRj4WOTFw07cxIBSqDJIMOD3/+y7zpfTCgUj5W9XKOJjb88k5xWiM6F5FaV5wYiy7keUGK4aNxUalmmJo/JWo1TvGmdtvZ6j/7xLvAD2+xbUveWBHW0IMHO/JvKsj/WNIKgrF9501cpPkWk7K0qCflXN8Mn4u3BzTTebiCBNLk8SqU04svsCgEPwxPOrQ4J95ULNlICf+M+A9C3isMsyEwAFRbD29vse5zujsImI0FPQwlZN5reke/B6cyNDHZjUDhvu7dG8X9uc3rcqoqmX7u4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com; Received: from PAWPR07MB9688.eurprd07.prod.outlook.com (2603:10a6:102:383::17) by AM8PR07MB8311.eurprd07.prod.outlook.com (2603:10a6:20b:32a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.28; Fri, 8 Mar 2024 10:21:01 +0000 Received: from PAWPR07MB9688.eurprd07.prod.outlook.com ([fe80::995b:5be7:51dd:e540]) by PAWPR07MB9688.eurprd07.prod.outlook.com ([fe80::995b:5be7:51dd:e540%4]) with mapi id 15.20.7362.024; Fri, 8 Mar 2024 10:21:01 +0000 Message-ID: Date: Fri, 8 Mar 2024 11:20:58 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm: smp: Avoid false positive CPU hotplug Lockdep-RCU splat Content-Language: en-US To: Boqun Feng Cc: Russell King , "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , linux-arm-kernel@lists.infradead.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org, Frederic Weisbecker References: <20240307160951.3607374-1-stefan.wiehler@nokia.com> From: Stefan Wiehler Organization: Nokia In-Reply-To: X-ClientProxiedBy: FR3P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::19) To PAWPR07MB9688.eurprd07.prod.outlook.com (2603:10a6:102:383::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAWPR07MB9688:EE_|AM8PR07MB8311:EE_ X-MS-Office365-Filtering-Correlation-Id: a07696b3-0506-416e-fa55-08dc3f597425 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4HrW795lXSZXzhkupV0SMFzpzVZZDbtcJHCK3X1vlXpA40rOa5YFz+rdJbeJMDbRYKK+wZDASP23LsEkv+vE85WpvFleWCDAtoj0fxqZz1Kf8M0BEmLWdYKE+bWxZ3MdSlvw4V9ZEkfQ1KOCZKoKvq8O3BZX1bS99EPLdh1whUWTrMudkalaI7wdT31TncaAtT0/XgpRVeXmn0WrgxylAuDu8pgzcOIrVWoeGw13H0okBGgWyrD426SwiLy2XJ3f8DpcCp7zaKy9qNgmlQ5p05J59XVPtxg8Wcct2tSLRQFgx8R5iiVEp8LBObC8QkB+aMYJ7HX4mHpgq0EVFgGkuXuFjqhGG8NfZxjVz8UEx7bTwUzw1LT2MhWPhtzNd2hcVw0g5O/MDSF7kZ47AzYr8x38MXQ4oB/VlreWcstErZX2soCS1HgLUtEExaUhZVa0V6jdHko6DRpXXewaN+O6MJN5Kub4/LGPnXnGCX4tKaD29JX5m9f/8EyeEw290xfhgJoEk+2EBDXBgtKBJdihw90+HxRCGtP1Xf5+AdN56SYWgykHbVJ9F4WmXS7pV2KQMmB/UeiKObkbFxYj6aNu7IkoXRcK9C2SyubgY2WvhhNlWEAJALXQotgoDwNzSncTe7yCCMG8GE9Rptqu7gLw7zm26FRR5l69mVomJsQ5dTE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR07MB9688.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzhRN1JhMUplL1hLNzZ2MVFweXo4UXhuSXByQmJZOEpIbUJML0dpZERPN3E1?= =?utf-8?B?K3U5YWx3d2tMVnkzM2tXM1FocWdjV3ZpdjN2eDF4U21FQzRib21DUW9aZm00?= =?utf-8?B?WXJWaWRaczJHdTg0eWdSQmFiNTBIbEtLK0RPRG01TjlRTmUyT2lHRUZyMkgr?= =?utf-8?B?Wmg0UjFkbkVpalFJUEFpSnFWR0tvb0ZhdFhvdDNiNHdtN0ZNVEQ3RysxbGVM?= =?utf-8?B?MTdDalljbzljNlRNTFJJTDZaK0FVd3Nxd2l6VnJwejZPUnZkQXRFazN6SGJj?= =?utf-8?B?TnhCWjROQzl6a1ZRN1Q0TFpRRjRzSjIxODlqUXZOZTZkMkpEUUdRMXFmL0dE?= =?utf-8?B?K0t1M2JNcklZbS95cXFFaUFGdWg0SDk1ME5uT21Zc0VVRm8rOGdkSnRFbjVY?= =?utf-8?B?Z2lpNU5Sc1Y2Q1VZaEtKbFFrMks2OXZEOGk0eFhOQ0o0SnQ4V1VoNnVmcXZ0?= =?utf-8?B?dEI3ZEJOZVRhZnFveTlvTmRiWFhPeW8rU2YvbGdIeFIwUzlydXh0cE80Nm1n?= =?utf-8?B?YVZMMkFZUElNencvTXE5N3VlbGthbEMwWXU4d0VPeGhUSk84MGl0SmY0VzRm?= =?utf-8?B?Ny9HY0RjdzVFZjBhV0FTeDlnMFU0bFh2Sjd4czk4di9qS20wN3hwQ2VCV3pU?= =?utf-8?B?UmhkeTBXUm9acGNXQlR6N3FKL1FUZWlXQkVvZEcvczdBTXY1V0lVTk1oRkpQ?= =?utf-8?B?ZVNLY0hnRE41bWw3b01RRFlMcCtoYllHZm9ObjJxL3JuNUwyakV3OVhxOUs0?= =?utf-8?B?REVnK2VacVhtUmQ5Z1RlMjFCcXNsLzBxaXdUTERJclhWaFd6bTNsRjNNRDFV?= =?utf-8?B?ZWM1cFE3di9uVWtjc2pTR0RnZGJ5bW9iNTZIU0Exd2JiaCtwYkpjU2NvVWVx?= =?utf-8?B?WXl6ZnVRZ0NCbzJYd29iMTFqSFRLWjB2RGxJTHUzNzk2TXFySmVMQXlJUzJL?= =?utf-8?B?UmFBUmorY0lTR202elVRckd0MVVlQW05N2JHSnJXcElWaVdVME1Oblh0WGRo?= =?utf-8?B?aGxHNTl4SCtCMmFXRmtIdkp0bEdONzVaRWtwL3JrdlNMMXo0OXByVytoSnZo?= =?utf-8?B?ajROb2dOQmNPemVVOUxiN0xmdEYxNElXT1R3aktSbmdka09mMW0rRmlmUlM3?= =?utf-8?B?RnArazdXZ25oZml6elBHQmJoV1BlcTR0NlhMQ1dUSU1SaFU2dURXNGpRRGhK?= =?utf-8?B?RnplSkNENmc2RjcrblFxcGRuN0J3WkhReWNIRk9pSHJ1dVpJbkQxdkpqZDFx?= =?utf-8?B?RTZ0eERqc1VOMW1IOENWSE5tYVFWMC9tVW1aUGdreFFxajZRV1U0bSsvdVpK?= =?utf-8?B?S2xyZFdnR0h2ZyttN2MxYkk2MmRjNXV0UEFoYUE5QlhmSlkwYitQNkh2Tmhk?= =?utf-8?B?bE5MUWhyUmEySTRQcmpkSFUrUjVGSDdrMEN2N0srd1ZlcDlPMnp4Y0tJQmZP?= =?utf-8?B?NFY5eHNhSkhiblNmeE9jL0plaU42MnQ5aFV4azdsUVdJVmZwemFRUis5UmJh?= =?utf-8?B?ZFdjOC9NMG1OYWNiQzA4VGl1SzVZQmhNa01nTS9GNHBjZlZXWDF2NHQyTXRE?= =?utf-8?B?WFk0emJ0d0tmcmh1UmFtK2FoU3NVRXNTMTQvOTdJNEZtdEo4ZFpncFRDWWJJ?= =?utf-8?B?SkEwY3hWZmF1dng5ODcxNFYwa2VZU1lKMzN4aUxmVzBMVk9RWGFtUkRrTDlU?= =?utf-8?B?akZNYzMwNkRUZUE2YU1ZQnhZK0JwS3I4Y2xrT0cwd21obmk3RFJ1M0VtTTkx?= =?utf-8?B?RE83Zml6TFhnbU5FYXg3cnJLMmFGYy9sRktBbGJJOHFZRkplNG5ZRkFzQ0pS?= =?utf-8?B?b2tBazBRQU5MSE93U01nYjN2eUZSUlZ6d0VtTCtHZklCVzlMek9MWG5hSFBr?= =?utf-8?B?b3c4SGg1ams0K3ZKNTZZMFB4OWU5NGZrTndNZ0RseTE2cXRqRmhBU2RyUmpX?= =?utf-8?B?MW1SdnNINU0zWkw2YWdvVVN3UkZlSFA2ZStpSmZUdHBXeHAxNnIwWE0xMzN4?= =?utf-8?B?L0dpWEFwWENhYkR0MGkvVk5NY004czJJRnlnQXYxaGpDUkhUblFqSlA3SENh?= =?utf-8?B?N1RkSUZkRHhzNGdnR2dWL2dzUDNDZGhqbkIxRi84N2JwbDUxL0RDUWVpNHFm?= =?utf-8?B?eVB5b2w0endEWUVYZkpONGJKQkdjY1d3QlR0ODhkN1pIK1hBYTZORnE3MTB6?= =?utf-8?B?bTkwR1BzaEI1Y3FnK2JOYkhQZ2ZobGw5M3RPaHhrVlNwNzJPNjBwbEw4YTNC?= =?utf-8?B?SDNGN2ZIbEFuUjJYWFhJVHFSNzJnPT0=?= X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a07696b3-0506-416e-fa55-08dc3f597425 X-MS-Exchange-CrossTenant-AuthSource: PAWPR07MB9688.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 10:21:01.3994 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T7X2MtWPTW4Oyg6nlcKbLfDClR1UhLAp2/88HQesh9cW+b4nJrm7+R92jyXxarR7/cgY9LMdi//H429nlVGfs0jI3GwiuLtlgZycbo9xMg4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR07MB8311 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_022112_454034_EFB728A9 X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > I'm not sure this is a false-positive: if you traverse an RCU-list > without RCU watching the CPU, then a grace period may pass, the next > list can be garbage and you can go anywhere from the list. Or am I > missing something that a CPU hotplug can block a grace period? Thanks for the feedback! Yes, calling it a false positive is probably not correct, I will remove that. However, as Russell has explained in a previous email, the spinlock is fundamental for ASID handling and cannot be removed. @Russell, I will submit to the patch tracking system then. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel