public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: ricardo@pardini.net, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: amlogic: add the type-c controller on Radxa Zero 2
Date: Thu, 15 Jan 2026 15:29:37 +0100	[thread overview]
Message-ID: <c56da924-9b12-4ba4-8d47-7c572bf241fa@kernel.org> (raw)
In-Reply-To: <20260114-arm64-dts-amlogic-radxa-zero2-additions-v1-2-8b5cdf328fde@pardini.net>

On 14/01/2026 23:48, Ricardo Pardini via B4 Relay wrote:
>  };
>  
> +/* Also exposed on the 40-pin header: SDA pin 3, SCL pin 5 */
> +&i2c3 {
> +	pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +
> +	fusb302@22 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

> +		compatible = "fcs,fusb302";
> +		reg = <0x22>;
> +
> +		pinctrl-0 = <&fusb302_irq_pins>;
> +		pinctrl-names = "default";
> +		interrupt-parent = <&gpio_intc>;
> +		interrupts = <13 IRQ_TYPE_LEVEL_LOW>;
> +
> +		vbus-supply = <&ao_5v>;
> +
> +		status = "okay";

Not needed or was it disabled anywhere?


Best regards,
Krzysztof


  parent reply	other threads:[~2026-01-15 14:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 22:48 [PATCH 0/2] NPU and i2c3 + FUSB302 addition for Radxa Zero 2 Ricardo Pardini via B4 Relay
2026-01-14 22:48 ` [PATCH 1/2] arm64: dts: amlogic: Enable the npu node on " Ricardo Pardini via B4 Relay
2026-01-14 22:48 ` [PATCH 2/2] arm64: dts: amlogic: add the type-c controller " Ricardo Pardini via B4 Relay
2026-01-15 13:00   ` Neil Armstrong
2026-01-15 13:59     ` Ricardo Pardini
2026-01-15 14:05       ` Neil Armstrong
2026-01-15 14:29   ` Krzysztof Kozlowski [this message]
2026-01-15  8:02 ` [PATCH 0/2] NPU and i2c3 + FUSB302 addition for " Neil Armstrong
2026-01-15  8:06 ` Neil Armstrong
2026-01-16 16:56   ` Krzysztof Kozlowski
2026-01-19  9:04     ` Neil Armstrong
2026-01-15 18:42 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c56da924-9b12-4ba4-8d47-7c572bf241fa@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=ricardo@pardini.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox