From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D15B6C433F5 for ; Tue, 9 Nov 2021 17:50:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C66D611BF for ; Tue, 9 Nov 2021 17:50:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C66D611BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=quicinc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pOUl1prUViyA0Zlh0kQoIZTsup83yEFMX4qeBPF02as=; b=jLmR2e3vtwiw0e KIHmzrvqfDgDmE4iOffBNhZF0JIUuozQ20ZR82gWMgrvTd27vhwL/2kTXkBF2sRyhX7l9BI0v7Jra KxB2BuxVx0pXg32boFys0YwR30fm7UScLZ/icGLsRhqFbxbEC1tn5SFion71YSEmlunjJaIbOGKdN efdfwsvCfSGZc46+WRdQ9Bz2b0K+kewHdRC3WMkQAb5VNMGQ2C8IwTlot2/z8rq3vWpdPtMo0jOGd GcLaBksQR9FxfDO6EBR2ng4UjPV8H52PGpsBc2kAB6mw9skEETbvwaUDUnj6+/c/Hgc+R91NBgCYL YHfE62N/R95WpO7z1sjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkVFY-002vBa-39; Tue, 09 Nov 2021 17:49:36 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkVFU-002vAZ-6m for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 17:49:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1636480172; x=1668016172; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wGWf/s+/hjinpE7Jq07oJQ20p6yx/FmYg7kNrRKK77Y=; b=j+0UAh2pki8sNVJTEE8sYHRD+E8U6e4ICuHaedLCYxM+J3MSGpx979tb rQce90K2P+uq+HeRzrTkEzu+aFIqJn3gaIw4NL4lQMlMH81UoCj5kqxJy /C5MGQprAskYI+JlWoDiWczFBipVGzcZ5GOYpArySZPXn+nteG5aMprsN E=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 09 Nov 2021 09:49:29 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 09:49:28 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.7; Tue, 9 Nov 2021 09:49:28 -0800 Received: from [10.50.19.148] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.7; Tue, 9 Nov 2021 09:49:23 -0800 Message-ID: Date: Tue, 9 Nov 2021 23:19:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCHv3 3/3] dynamic_debug: Add a flag for dynamic event tracing Content-Language: en-US To: Steven Rostedt CC: Will Deacon , Catalin Marinas , , Marc Zyngier , , , , , , , , References: <3706af20bc64a320ff8f3ff8950738b988f4bdf5.1636452784.git.quic_saipraka@quicinc.com> <20211109104941.2d50eafc@gandalf.local.home> <20211109115951.1c2b5228@gandalf.local.home> <264b77dd-5509-60f9-248c-a93135b01aa9@quicinc.com> <20211109124046.2a772bcb@gandalf.local.home> From: Sai Prakash Ranjan In-Reply-To: <20211109124046.2a772bcb@gandalf.local.home> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_094932_309312_94D30722 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/9/2021 11:10 PM, Steven Rostedt wrote: > On Tue, 9 Nov 2021 23:00:11 +0530 > Sai Prakash Ranjan wrote: > >> Ah that's a very good idea, descriptor does contain the module, file name. >> We can probably even pass the module name,file name as string from the >> descriptor itself to event? >> Perhaps we can do that for all trace events and not just this trace >> event? Just like the trace event name displayed >> with trace events, perhaps have file name,module name displayed when >> dynamic debug is enabled? Filtering by >> filename is pretty useful since most of these usecases in debugging will >> be with respect to some driver or subsystems. > If we add this for all events, it would require a lot of changes to all > users of tracepoints, as it would require adding a new parameter to the > callbacks. > > We could add a flag in the registering that states that the callback is OK > for it, and it passes that data as well. > > Let me look into this for a bit. I may not have something this week, but > we should look into this more before adding little hacks that do this one > at a time like this patch. > > -- Steve Sure, thanks for the help and review. I can skip this patch adding support for dynamic event tracing till we have something concrete as the previous patches doesn't depend on this. Thanks, Sai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel