From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67FAEC001DB for ; Tue, 8 Aug 2023 08:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e72gv0GDMCAEcI9RTpJdZbhFZdrAEaiO+qvdU0zhk60=; b=eGWVLQSbhWjaFd ySKApTOd8t7K2f/63HVBGtiIkk7MPbTaMKwbZksIJZXSIeIc0c2il12idHeb4QGCRALDX054rUCZH YPZ49KGczfmgrETg3YdK5vf5j7+EPhB6e9P7cgASfCz7QTBWwgRNqZX4Tq4LURucFlYFmJNxshK6s 6WBiutCeFbp3L7aYz7gu72ipAQ7CeW/JQfciPTZzzKThjY8TysJjY7aCk0axgeKpmB4osYWTgFrWi xNpHUs3+lKeqbdmXkgtbuOFUmvcVSqBADjqAivEwSjtRM6b6N31QYUJhTDoigZI84nbeOxwSRczKA z9KKbFg3zrnTC5EkzoxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTIDK-0023Nc-3D; Tue, 08 Aug 2023 08:37:15 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTIDI-0023MI-0y for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 08:37:13 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9923833737eso746264666b.3 for ; Tue, 08 Aug 2023 01:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691483828; x=1692088628; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AV7pYGODgs/vswsM71s7yBSPT97U68gXTdayAu9iSYw=; b=hveblOYA0AS94pZtwkfaVK+JKBbtxLCL5rjQtShv3Wrp2awU8WyY+lvMlo9Jcwax3V CT3O3GQMqag240+P22XB+ZwQnsKJwym4ekN5ByleF+g0lcOMArrn1fI9fllXEFMVjWZe hyXIMUurI8jbij7XGdLPECyaxmWeMdTB18+fSBW4Gf/PflF7osAxbImWypuWZ5PMWJ01 +DNxDlGykPaCeQiZE7K2t+Whf7YY+T3BXDgMv+WhOR/NR4rVqD9S3EU6AOmp6mQ/WdzM vsDwK5UTk8F5ez1KSOLg0OSqbxWaZWJODxwSJppjgT7ussZ7BDYGDBbUOfDrSNepJgK2 hW0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691483828; x=1692088628; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AV7pYGODgs/vswsM71s7yBSPT97U68gXTdayAu9iSYw=; b=UnHeXqK+l5kTJvCOrU1X+iDnZ2gR/8QFdbrwR4Dx64A8lLoqtSCcBmojhd9zWC37on GJAv5C0k7jinuzHHYCVKlxbgJunIvtyvOyJnKeXiNReRJFLhjkNmjWZmDdANdECEBxgb 4ArQ3zRBZEekg8mOlAGwsh2pbGgoCTOKByFKcFVwBU2PLO0Mk/bD272+ACzPdL8y9/RO /sHkfU7Z3ceOFW86Abga+/CNsdvvofZMULf28mCbYWYD2NnYE26fUNbFSFQhEKf15SSX oggSMzybr6i6Y4Ep+S7aKTz+koyjxqNzRcO/o5tLvQP+U7W5hw/t3EToCu29dpr2IPf2 3FwA== X-Gm-Message-State: AOJu0YzLhjDjdqlgO37uhaYJEaPOm/uPm6bSSnYaDSpC5YMQIkgV9uz5 H8eLBTmT+XXqB5HPsmKqVexkpw== X-Google-Smtp-Source: AGHT+IHi6Yp+yRsRwvN5aEzHBHFgm8hd5a3fbcIKHC1dwK0+H3FWM+RobNVM6FnNwNpUNH5BDqly7w== X-Received: by 2002:a17:906:e:b0:99c:7134:ab6d with SMTP id 14-20020a170906000e00b0099c7134ab6dmr10266806eja.41.1691483828332; Tue, 08 Aug 2023 01:37:08 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id l17-20020a1709060e1100b009944e955e19sm6302110eji.30.2023.08.08.01.37.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 01:37:07 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 10:37:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 8/9] i2c: imx-lpi2c: Use dev_err_probe in probe function Content-Language: en-US To: Liao Chang , andi.shyti@kernel.org, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-9-liaochang1@huawei.com> From: Krzysztof Kozlowski In-Reply-To: <20230808012954.1643834-9-liaochang1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_013712_337988_98E08BCE X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 03:29, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > ret = devm_request_irq(&pdev->dev, irq, lpi2c_imx_isr, 0, > pdev->name, lpi2c_imx); > - if (ret) { > - dev_err(&pdev->dev, "can't claim irq %d\n", irq); > - return ret; > - } > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "can't claim irq %d\n", irq); > I don't think this is needed: https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel