From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface
Date: Thu, 28 Sep 2023 07:32:20 +0200 [thread overview]
Message-ID: <c58ffc72-59d9-49f5-be22-18588f7df1e3@linaro.org> (raw)
In-Reply-To: <20230925232806.950683-2-yuji2.ishikawa@toshiba.co.jp>
On 26/09/2023 01:28, Yuji Ishikawa wrote:
> Adds the Device Tree binding documentation that allows to describe
> the Video Input Interface found in Toshiba Visconti SoCs.
>
> + reg:
> + items:
> + - description: Registers for capture control
> + - description: Registers for CSI2 receiver control
> + - description: Registers for bus interface unit control
> + - description: Registers for Memory Protection Unit
> +
> + interrupts:
> + items:
> + - description: Sync Interrupt
> + - description: Status (Error) Interrupt
> + - description: CSI2 Receiver Interrupt
> + - description: L1ISP Interrupt
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: CSI-2 input port, with a single endpoint connected to the CSI-2 transmitter.
> +
> + properties:
> + endpoint:
> + $ref: video-interfaces.yaml#
> + additionalProperties: false
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
> +
> + required:
> + - clock-noncontinuous
> + - link-frequencies
> + - remote-endpoint
> + - data-lanes
Not much improved here. required goes after properties, always. I
pointed you last time the file which you should use as an example.
> +
> + properties:
> + data-lanes:
> + description: VIIF supports 1, 2, 3 or 4 data lanes
> + minItems: 1
> + items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> +
> + clock-noncontinuous: true
Drop
> + link-frequencies: true
Drop
> + remote-endpoint: true
Drop
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-28 5:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 23:28 [PATCH v8 0/5] Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-09-25 23:28 ` [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface Yuji Ishikawa
2023-09-28 5:32 ` Krzysztof Kozlowski [this message]
2023-10-03 23:10 ` yuji2.ishikawa
2023-10-04 6:51 ` Krzysztof Kozlowski
2023-10-05 12:30 ` yuji2.ishikawa
2023-09-25 23:28 ` [PATCH v8 4/5] documentation: media: add documentation for Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-09-25 23:28 ` [PATCH v8 5/5] MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface Yuji Ishikawa
2023-09-27 13:23 ` [PATCH v8 0/5] Add Toshiba Visconti Video Input Interface driver Hans Verkuil
2023-09-29 1:49 ` yuji2.ishikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c58ffc72-59d9-49f5-be22-18588f7df1e3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).