public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Kendall Willis <k-willis@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Dhruva Gole <d-gole@ti.com>,
	"Bryan Brattlof" <bb@ti.com>, <vishalm@ti.com>,
	<sebin.francis@ti.com>, <msp@baylibre.com>,
	<khilman@baylibre.com>, <a-kaur@ti.com>, <s-kochidanadu@ti.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: boot: dts: ti: k3-am62l3-evm: enable WKUP UART wakeup from LPM
Date: Tue, 6 Jan 2026 11:10:50 -0600	[thread overview]
Message-ID: <c5954858-7d62-4b57-801d-8a6fe9cccefc@ti.com> (raw)
In-Reply-To: <20260106115658.susgttqvokqeasz3@width>

On 1/6/26 05:56, Nishanth Menon wrote:
> On 16:10-20260105, Kendall Willis wrote:
>> On 1/5/26 07:55, Nishanth Menon wrote:
>>> On 20:51-20251230, Kendall Willis wrote:
>>>> Change the status of the wkup_uart0_interconnect node to enabled. The
>>>> target-module node sets the UART SYSC and SYSS registers to allow wakeup
>>>> from WKUP UART in DeepSleep low power mode.
>>>>
>>>> Signed-off-by: Kendall Willis <k-willis@ti.com>
>>>> ---
>>>>    arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
>>>> index cae04cce337366b50928d39b0c888550b14e43d3..02b1a1c76b2ee05d49cd69d199a6aacdb1973fa0 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
>>>> +++ b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
>>>> @@ -359,3 +359,7 @@ &usb1 {
>>>>    	pinctrl-names = "default";
>>>>    	pinctrl-0 = <&usb1_default_pins>;
>>>>    };
>>>> +
>>>> +&wkup_uart0_interconnect {
>>>> +	status = "okay";
>>>> +};
>>>
>>> don't we need to set status okay and provide pinmux for wkup_uart?
>>>
>>
>> No, only the interconnect target node needs to be enabled because it manages
>> the SYSC register. The SYSC register configures the WKUP_UART to be able to
>> wakeup the SoC from system suspend. This allows the WKUP_UART to be wakeup
>> capable even if it is reserved by firmware.
>>
> 
> If wkup_uart is controlled by firmware, it should be managed by
> firmware. $subject claims that wkup_uart is being enabled, but it is
> not.
> 
> 

Okay, I will change the $subject to reflect the patch better in v2.

Best,
Kendall


  reply	other threads:[~2026-01-06 17:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-31  2:51 [PATCH 0/3] arm64: boot: dts: ti: k3-am62l: enable WKUP UART wakeup Kendall Willis
2025-12-31  2:51 ` [PATCH 1/3] arm64: dts: ti: k3-am62l: include WKUP_UART0 in wakeup peripheral window Kendall Willis
2026-01-05 13:22   ` Dhruva Gole
2025-12-31  2:51 ` [PATCH 2/3] arm64: boot: dts: ti: k3-am62l-wakeup: create label for target-module Kendall Willis
2026-01-05 13:24   ` Dhruva Gole
2025-12-31  2:51 ` [PATCH 3/3] arm64: boot: dts: ti: k3-am62l3-evm: enable WKUP UART wakeup from LPM Kendall Willis
2026-01-05 13:25   ` Dhruva Gole
2026-01-05 13:55   ` Nishanth Menon
2026-01-05 22:10     ` Kendall Willis
2026-01-06 11:56       ` Nishanth Menon
2026-01-06 17:10         ` Kendall Willis [this message]
2026-01-05 14:01   ` Bryan Brattlof
2026-01-05 22:14     ` Kendall Willis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5954858-7d62-4b57-801d-8a6fe9cccefc@ti.com \
    --to=k-willis@ti.com \
    --cc=a-kaur@ti.com \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msp@baylibre.com \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=s-kochidanadu@ti.com \
    --cc=sebin.francis@ti.com \
    --cc=vigneshr@ti.com \
    --cc=vishalm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox