From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78C0FC61DA4 for ; Thu, 16 Feb 2023 09:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k9KwgLQyFKObQ3Jus5s3tkHKDPKhtjlh9yEp2sQKYGs=; b=3LqYd3RR6nt5AW Io7Y0/pR6jTZLw87fMXILNEQ92nEWxoMc/zXMMjCODXp06OpA45HmUi5vhXancF+ahqzUsC9ZCniE +B83R+l0l+OaXKJnd/9vgQ14UKkpkjXKj43YfcuMcSriRsAND4wO3NlTojQxxPddiqLrhU/kOcnbo 1kp762gNckBBcLwjSUaUzKuBZuPO4BgwXxZKWoW/19dtfOtjOXH47gZmYT3Pvaw88DdFt3jor2ZNX gx7JP9bOE/IWKdp9zTS578Tnyk3yEYwyQZKXouFZtiVq3sgviXJA4AFKqKN/pfQr0UQlBrvJtjVyZ n0ADv4LI9cgjdk4DGn5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSaSu-009DyR-I7; Thu, 16 Feb 2023 09:22:08 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSaSr-009DxT-9L for linux-arm-kernel@lists.infradead.org; Thu, 16 Feb 2023 09:22:06 +0000 Received: by mail-ej1-x635.google.com with SMTP id lf10so3622446ejc.5 for ; Thu, 16 Feb 2023 01:22:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=instFpBHV/JuNsnWbwYUXVPH2jqRlugl+D8EIlje5FQ=; b=GrUGTvJULPegvd61t+FvX4GJ1ZjZrTJ3eASv/bmwutJFj2QeHGRGB1FD/AGQ1XxuRE WOTMiUdZcblkLBuDPkmahhNkk4t+sdXMhO+S4hqew/OOQDbqX4hEXVDX0tfiatAoOUGK 2jvogjL9yAVb2ql6c8Klqs2hAObfqG7b3/9Vwq3FZtZvy05MOyVWvc0r+6e/Tf9F5UzS GXm5UvijElk0MLM92Dzfh3Er0AZRUMGhho0lTIzgouVqzFu5f3LSfsWQQwDOQqqdTYfk 8hnhYS1J6/YaDGebJEirp1RUBAVfegruIWEpxoxnzcxhTS+7EwkBjEj6TmXt2NQyridh Sv/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=instFpBHV/JuNsnWbwYUXVPH2jqRlugl+D8EIlje5FQ=; b=hCCegXg9YQFbYNcILcms+q2sKzl9Vq4XXxX3A9LvqAsLG+3bnH5v3sP5K2qIkuFW49 CwDUWAIC8ipR8astukmrQFzgtWtarQPG6I1AbYxtvSgzqRZ23rgS7ljfzuZwC+PrAi2k rUwVXMptYeM4wz8umRCnln6iP7VZ6llxmBE35EgeFZIeCh6ImMavMczgkWsp9eWfO7sZ zi+h91qABIK5cRYj0d6S0FGE6V6CcZCl2vndQSe8IX0pLAgBavHbDMWfe+MewgdqCdL+ 8hTeBXblpppFVf2QIMqIrnU6KxquZdom0CPRDv9wrgRar2+gOZLJcG/yUVhKX7Mg0/yU Cfvw== X-Gm-Message-State: AO0yUKU6POA6ZpUlmpIlDBp7kuYrpIlrdE+TxvWy/XcJ3mScojVr64FN lWZ360hWiG15+HF8TZuLifNyfg== X-Google-Smtp-Source: AK7set/G+wS4JosvTqvxTxSGbj6EYBrpnJuw4HyLgb4b6T7aodQrpX4RymIdMOUmmQGVjEpMesOwKA== X-Received: by 2002:a17:906:f6d9:b0:884:4806:c39 with SMTP id jo25-20020a170906f6d900b0088448060c39mr4958957ejb.11.1676539323879; Thu, 16 Feb 2023 01:22:03 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id s9-20020a170906960900b0088091cca1besm548331ejx.134.2023.02.16.01.22.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 01:22:03 -0800 (PST) Message-ID: Date: Thu, 16 Feb 2023 10:22:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver Content-Language: en-US To: Ryan Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Philipp Zabel , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20230201103359.1742140-1-ryan_chen@aspeedtech.com> <20230201103359.1742140-3-ryan_chen@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_012205_360200_EFDFAB12 X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/02/2023 10:20, Ryan Chen wrote: > Hello Krzysztof > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Thursday, February 16, 2023 4:18 AM >> To: Ryan Chen ; Rob Herring >> ; Krzysztof Kozlowski >> ; Joel Stanley ; Andrew >> Jeffery ; Philipp Zabel ; >> openbmc@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 >> i2C driver >> >> On 15/02/2023 06:43, Ryan Chen wrote: >>>>> + - $ref: /schemas/i2c/i2c-controller.yaml# >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - aspeed,ast2600-i2c >>>> >>>> NAK. It's already there. Please do not waste our time in submitting >>>> duplicated drivers. >>> >>> It is not duplicated, as my description in cover " This series add AST2600 i2c >> new register set driver" >>> So, this will be different driver compatible. >>> The original compatible is >>> - aspeed,ast2400-i2c-bus >>> - aspeed,ast2500-i2c-bus >>> - aspeed,ast2600-i2c-bus >>> So the new register set compatible is "- aspeed,ast2600-i2c", remove "bus". >> >> Bindings are documenting hardware, so I claim - we already have this >> hardware described and this is duplicated. Otherwise - what are these two I2C >> controllers and what are the differences? Why they do not have really different >> name? Bus looks more like a mistake than a differentiating name. > For misunderstanding, or mistaken. > I purpose to be aspeed,ast2600-i2cv2, will it more clear way ? I don't know. I still did not get answers. I asked here several questions. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel