From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 794EBC433F5 for ; Wed, 13 Apr 2022 08:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Km5a35QYLSZ3WaXEiDMhTWAX2SCRnGMCEIVhMyMI9I=; b=CHhybIzjiY5c4C cRHmqeF3tcGhsWzKE6G9jn6VzMXEtkBKEEAseKwniK5KEVZ686fZuC84czNHr/GYCALmX6E2KdyT3 hPYZZ5tE+nkSJ6kEBzVaLVL310e8zc/qbettaq7C7jqqhvcrFXDGj2M132L7oZNv8MO0XpM7rctoz 4oP8JrvA+oEOZ/z+Iov7Yadtuk8qcJHAH5D+BY+PLTfMO0ISUx8sRk1JgJMLyMVv4M6TzINeHnzTv inKjEGoeh+P3vvU8u+t4CbFUhdiuCKf8Y/gKfc4XfDpuYPVhCTyTJWqqYEM1PLIszujUstI0Q2qYK +XtJPmAs+4e89bgL8sDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neY4b-00HY77-E6; Wed, 13 Apr 2022 08:09:57 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neY4V-00HY5L-UF for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 08:09:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A49A9B8214A; Wed, 13 Apr 2022 08:09:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60D09C385A4; Wed, 13 Apr 2022 08:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649837388; bh=7dRvLs/Squ22R+scDlSG9re8YSadv6HhAtuiD/awykQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Kshi/SnmDVYPCGpaw4/TRZPxJODVaWZYlavAwmIkJVPei0A6X2fmhxTjXeSUQ3568 Xv9HmI6mPkFZnFXjmQSmX2dIA0tRzRgPVuqCnYZ2jo67rmsDS5wZhJh/EX5rgdg9x9 /Qwcf8JTSKJ2i8wCmdvpcxy5/sO/VX7fso7C7iplwfhowdIcBCqksgtSAOjm69CIBi 6fL/wp0Jd2ZB4GTYsykdck3IeAOn0WaYIK9opgcdmuN39YjCRI2P34sCEtT3JPioIT UVQYJpOGrHIBO//bSxpJaoa/sr/MWnwDjNh2wvzignKAw1Z/1WTnPKnOp9taVHTDwW uUNKzX9E7+xtA== Message-ID: Date: Wed, 13 Apr 2022 11:09:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC 13/13] net: ti: icssg-prueth: Add ICSSG ethernet driver Content-Language: en-US To: Puranjay Mohan , Andrew Lunn References: <20220406094358.7895-1-p-mohan@ti.com> <20220406094358.7895-14-p-mohan@ti.com> <080bf31d-a452-af0b-ca41-a6b3d951e18f@ti.com> From: Roger Quadros In-Reply-To: <080bf31d-a452-af0b-ca41-a6b3d951e18f@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_010952_173061_A269A474 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, Grygorii Strashko , vigneshr@ti.com, mathieu.poirier@linaro.org, kishon@ti.com, netdev@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, krzysztof.kozlowski+dt@linaro.org, ssantosh@kernel.org, kuba@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/04/2022 12:46, Puranjay Mohan wrote: > +Roger, Grygorii > > On 07/04/22 00:12, Andrew Lunn wrote: >>> +config TI_ICSSG_PRUETH >>> + tristate "TI Gigabit PRU Ethernet driver" >>> + select TI_DAVINCI_MDIO >>> + >> >> I don't see a dependency on TI_DAVINCI_MDIO in the code. All you need >> is an MDIO bus so that your phy-handle has somewhere to point. But that >> could be a GPIO bit banger. >> >> What i do think is missing here is a dependency on PHYLIB. That is correct. >> >> If possible, it would be good to also have it compile when >> COMPILE_TEST is set. >> Yes, that is a good idea. cheers, -roger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel