From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D9A7CD1283 for ; Mon, 1 Apr 2024 09:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G3fWGxfpBE3AerwIw3y/56Wqe8Hs1CHuWwDAIi7/+r0=; b=S2l9lDAqYU36Fe T8736e9fl35bSIJd6OW3suCWyz9wc6M/PAFXJYML82do05/tUa82QHF+Hw/J07gQveL76OLsWuzCY c1A7v2iJI46H95kf5LdpaYRtKFNQv3jdhWounWJ4JwxvQivhHsO5pA15CzKWOQBt44nnUksBIv6Fb xmcakT+zc26nL2SItSw0tUvyMD3laY8UwSaebF8xeLEe9Ujc1u3M+b5yseMnnHtN6UfChfB0AD6YV FtrQzJ46TvtkbXfWbI88nUPtKXBprLMkX9Ul91MPRGzs9oZ2LjvRhncgVYxRDIgJsMCfVIe8wNh3r 7iwNEcXhSU+x8nL8D/tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrEKT-00000007ONz-2CXf; Mon, 01 Apr 2024 09:51:49 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrEKQ-00000007OMW-0e8n for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 09:51:47 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a4e6489c31eso114028766b.2 for ; Mon, 01 Apr 2024 02:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711965104; x=1712569904; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Dzql5prZwnt+vohd76RG25/DjYuQd5VmqrQyYq+ATkM=; b=YKBlsGrll+voCs1W0kRPgSjYMYDQTm2MnvxhAA8XUqwNI6PuLc86EiqEq3bOTjFM0O 69eElj4Gt3HRiLjJQV/63NuHB0ex05amNRz1ZDZsxVYkRHi6ON+xMtWnPxq8OEmsz/GI Xg42pNSx9LG53T51FSeaHfnUyDot/VKXybQNqqGl4qpL+UqzKoDtpHKElkN1NYg8/ArH cSYTSkjHeB0DnvvMkW3STqq0FWjOHvKZYBJPpnc3aiDPxy56uUSIH97kZ0zdCEdexqx7 lbuB6HmXYQUITKL2yc8zDREO17BJtWQGZfGeWa5fG0AMdepIqJ6vUlGi/ucQqBgL/ecq pLEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711965104; x=1712569904; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dzql5prZwnt+vohd76RG25/DjYuQd5VmqrQyYq+ATkM=; b=Rnw9PhX/1RX3MqR7Knqe7wnykxueT3PQBRZyQCe7M7fcUC1/zCHjsfXmVEf0vjeV2d lJclhXw2V4rYfr6n4qgOVyzb5ZTidnCPBsyg9fo0QY3oMIKD8jukJShPd0Jpcir+v0wa iYW5M9qQhuEJdDY3/dyfZA5qT+j+0jBAAPiuorYMlhTdgmv0Lqo9CLvKB1AetPvav+Nj ylWjyQHpXUwEQINp6Cg3/kUWsFjMgsTswtFDW7KYm2rEnmeg+OVI2yBej3upn5tie+f6 rVcQjMwc/UmRzp80BnkEuVRfllA7qbmEOYYRzoScMXIaqg/ZfN8ojbDKhrTo1mymeNIV jccA== X-Forwarded-Encrypted: i=1; AJvYcCUb8ONVYhlfzEGwsYiARIsFMElTWg+hmhYO5MG1zDkSGjd3d1CRKkTC8FYe2YWfen+I6g9BLpmA8ZGPyp/PFuYFpiU/3ljJnjfyjwlKN3A8LSqClEE= X-Gm-Message-State: AOJu0YyuaKeH/CAkTeCP/2Zug2u8XAQiPN8PIor5YNga345bcPc8PkWM g5gE8YEPs0Z3RMSlIKPoFWo/z9j9nU58ufU4xz8lSYu3tF6h7YP2NaHdOWk/36o= X-Google-Smtp-Source: AGHT+IExQYQm0NtAZHBPONy7nCXeQvXeh7zREgZ48G/YhMdHAfJzfcWm7cIICaIC6PIwA+ynBGZlzg== X-Received: by 2002:a17:906:1253:b0:a4d:ff5f:98ad with SMTP id u19-20020a170906125300b00a4dff5f98admr5550248eja.37.1711965103725; Mon, 01 Apr 2024 02:51:43 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id gl20-20020a170906e0d400b00a46c39e6a47sm5158120ejb.148.2024.04.01.02.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Apr 2024 02:51:43 -0700 (PDT) Message-ID: Date: Mon, 1 Apr 2024 11:51:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/4] dt-bindings: clock: add i.MX95 clock header To: Peng Fan , "Peng Fan (OSS)" , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Abel Vesa Cc: "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20240324-imx95-blk-ctl-v5-0-7a706174078a@nxp.com> <20240324-imx95-blk-ctl-v5-3-7a706174078a@nxp.com> <31b493d1-ad74-48c7-8585-9df323418ae3@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_025146_249528_5086D3A7 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/04/2024 09:26, Peng Fan wrote: >> Subject: Re: [PATCH v5 3/4] dt-bindings: clock: add i.MX95 clock header >> >> On 24/03/2024 08:52, Peng Fan (OSS) wrote: >>> From: Peng Fan >>> >>> Add clock header for i.MX95 BLK CTL modules >>> >>> Signed-off-by: Peng Fan >>> --- >>> include/dt-bindings/clock/nxp,imx95-clock.h | 32 >> +++++++++++++++++++++++++++++ >>> 1 file changed, 32 insertions(+) >>> >>> diff --git a/include/dt-bindings/clock/nxp,imx95-clock.h b/include/dt- >> bindings/clock/nxp,imx95-clock.h >>> new file mode 100644 >>> index 000000000000..83fa3ffe78a8 >>> --- /dev/null >>> +++ b/include/dt-bindings/clock/nxp,imx95-clock.h >>> @@ -0,0 +1,32 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ >>> +/* >>> + * Copyright 2024 NXP >>> + */ >>> + >>> +#ifndef __DT_BINDINGS_CLOCK_IMX95_H >>> +#define __DT_BINDINGS_CLOCK_IMX95_H >>> + >>> +#define IMX95_CLK_VPUBLK_WAVE 0 >>> +#define IMX95_CLK_VPUBLK_JPEG_ENC 1 >>> +#define IMX95_CLK_VPUBLK_JPEG_DEC 2 >>> +#define IMX95_CLK_VPUBLK_END 3 >> >> No improvements, so again: drop counting. > > Could you please give more details on what you think needs > to be addressed here? I may overlook your comments before, > but I search v1-v4, not find comments on the headers, > except the one file name align with binding if 1:1 match. Drop all defines which count number of clocks. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel