From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Simplify printks with pOF format
Date: Fri, 12 Sep 2025 11:34:53 +0200 [thread overview]
Message-ID: <c5df4196-b951-4f8e-b2ca-c63fba63d1ee@linaro.org> (raw)
In-Reply-To: <20250912092423.162497-2-krzysztof.kozlowski@linaro.org>
On 12/09/2025 11:24, Krzysztof Kozlowski wrote:
> Print full device node name with %pOF format, so the code will be a bit
> simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/firmware/arm_scmi/bus.c | 13 ++++++-------
> drivers/firmware/arm_scmi/transports/mailbox.c | 7 +++----
> 2 files changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
> index 24e59ddf85e7..c7698cfaa4e8 100644
> --- a/drivers/firmware/arm_scmi/bus.c
> +++ b/drivers/firmware/arm_scmi/bus.c
> @@ -401,8 +401,8 @@ static void scmi_device_release(struct device *dev)
>
> static void __scmi_device_destroy(struct scmi_device *scmi_dev)
> {
> - pr_debug("(%s) Destroying SCMI device '%s' for protocol 0x%x (%s)\n",
> - of_node_full_name(scmi_dev->dev.parent->of_node),
> + pr_debug("(%pOF) Destroying SCMI device '%s' for protocol 0x%x (%s)\n",
> + scmi_dev->dev.parent->of_node,
> dev_name(&scmi_dev->dev), scmi_dev->protocol_id,
> scmi_dev->name);
Heh, I misread the docs and see now in the testing that my patch changes
the behavior. of_node_full_name() is just node name. pOF is full path.
This might be desired or not...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-12 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 9:24 [PATCH] firmware: arm_scmi: Simplify printks with pOF format Krzysztof Kozlowski
2025-09-12 9:34 ` Krzysztof Kozlowski [this message]
2025-09-12 10:31 ` Sudeep Holla
2025-09-12 11:19 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5df4196-b951-4f8e-b2ca-c63fba63d1ee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox