Re: [PATCH v6 3/3] phy: mediatek: tphy: add debugfs files

Chunfeng Yun (云春峰)
2023-01-16T07:29:59Z

On Fri, 2023-01-13 at 23:45 +0530, Vinod Koul wrote:
> On 04-01-23, 21:26, Chunfeng Yun wrote:
> > These debugfs files are mainly used to make eye diagram test
> > easier,
> > especially helpful to do HQA test for a new IC without efuse
> > enabled.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v6: no changes
> >
> > v5: using common debugfs config CONFIG_DEBUG_FS
> >
> > v4: fix build warning of sometimes uninitialized variable
> >
> > v3: fix typo of "debugfs" suggested by AngeloGioacchino
> >
> > v2: add CONFIG_PHY_MTK_TPHY_DEBUGFS suggested by AngeloGioacchino
> > ---
> > drivers/phy/mediatek/phy-mtk-tphy.c | 405
> > +++++++++++++++++++++++++++-
> > 1 file changed, 404 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c
> > b/drivers/phy/mediatek/phy-mtk-tphy.c
> > index e906a82791bd..923e5ee119f3 100644
> > --- a/drivers/phy/mediatek/phy-mtk-tphy.c
> > +++ b/drivers/phy/mediatek/phy-mtk-tphy.c
> > @@ -7,6 +7,7 @@
> >
> > #include <dt-bindings/phy/phy.h>
> > #include <linux/clk.h>
> > +#include <linux/debugfs.h>
> > #include <linux/delay.h>
> > #include <linux/iopoll.h>
> > #include <linux/mfd/syscon.h>
> > @@ -264,6 +265,8 @@
> >
> > #define TPHY_CLKS_CNT 2
> >
> > +#define USER_BUF_LEN(count) min_t(size_t, 8, (count))
> > +
> > enum mtk_phy_version {
> > MTK_PHY_V1 = 1,
> > MTK_PHY_V2,
> > @@ -310,6 +313,7 @@ struct mtk_phy_instance {
> > struct clk_bulk_data clks[TPHY_CLKS_CNT];
> > u32 index;
> > u32 type;
> > + struct dentry *dbgfs;
> > struct regmap *type_sw;
> > u32 type_sw_reg;
> > u32 type_sw_index;
> > @@ -332,10 +336,391 @@ struct mtk_tphy {
> > const struct mtk_phy_pdata *pdata;
> > struct mtk_phy_instance **phys;
> > int nphys;
> > + struct dentry *dbgfs_root;
> > int src_ref_clk; /* MHZ, reference clock for slew rate
> > calibrate */
> > int src_coef; /* coefficient for slew rate calibrate */
> > };
> >
> > +#if IS_ENABLED(CONFIG_DEBUG_FS)
> > +
> >
> > <skip>
> >
> > +
> > +DEFINE_SHOW_ATTRIBUTE(tphy_type);
> > +
> > +static void tphy_debugfs_init(struct mtk_tphy *tphy, struct
> > mtk_phy_instance *inst)
> > +{
> > + char name[16];
> > +
> > + snprintf(name, sizeof(name) - 1, "phy.%d", inst->index);
>
> I wouold suggest driver name/ device name rather than phy.foo...
> again
> folks needs to see what is foo
Ok, I'll change it, thanks a lot

>
> <skip>
> >
> > static struct platform_driver mtk_tphy_driver = {
> > .probe = mtk_tphy_probe,
> > + .remove = mtk_tphy_remove,
> > .driver = {
> > .name = "mtk-tphy",
> > .of_match_table = mtk_tphy_id_table,
> > --
> > 2.18.0