From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CBD4C54E58 for ; Mon, 18 Mar 2024 20:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C3wQP66ZNOi5sZd3i2PxzmBex0WNykkPuVqeFmZ8Nls=; b=tr8Z78pjBz6j/Q 8rh94nyCCvsaHAK7VmjOoJTBaZ87RtzzBfgZuKYT6OtNYqPILHhFNaLMpY6809AB0rNzTgiOHWWXk OROokkUVEAbBhEpJTdxrC4FdxG2E/r1GoPzz+gyQnkkI73n9UUynSzkUis9PJXxWxNc2WRJTQviFY jJPgUS8V76kVQpwhA8Urnc/PP2NuTA2RD3q8L5fsnSLE4tW0f2sAgzM6OmM5cBrINK7zSdJSBqLfT cbObyJaHc8x7wfyY6Zi2NMEEMrWM7npAqwg6LswUBHMiO0pxSi13btEBVP7hectKuv4vCflxpO0Uj pUTkbHulsyZ8etveQbfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmJQi-0000000A0fq-1Fcu; Mon, 18 Mar 2024 20:17:56 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmJQe-0000000A0eU-17XT for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 20:17:54 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-56b0af675deso1356734a12.1 for ; Mon, 18 Mar 2024 13:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1710793069; x=1711397869; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u1VK2UrvRK1GqfS+jZTcmyrPbAehgKhpyQhy7X6GkE8=; b=M0sbXpNHe4Y6CL3tm+YzaJpC5MgdnXU9yom3bne57LD+CBdebYv6NJD51/Cr99i10J P3egSScEDVJGcnfQaDVE5N3Q2KAohI8GxkkkNHGNzH7AEiSu+fhvVevKCjPgfhxFL9/I sib/iDOfXeepPSGvAxZls5RSquzgGA+Db6ZxqRBxxDLA4ptL+R6bHhlMeHLEB09psGGy qM4BPXGsEt0tw894gLwLjhunEhj05oAfkheUXReFc3Sg0an81cqQLky2ZiQFtcx2fzXZ LKjyI0+1+GMnfWEWyaGUWc8L3Fq15p9WowQ0s78sfsNJQ7gG9rwhWVgCplV6lQyR/uON e0Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710793069; x=1711397869; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u1VK2UrvRK1GqfS+jZTcmyrPbAehgKhpyQhy7X6GkE8=; b=DQYEuuoK6J0FFEuMFtktnLCXbVHa9yp2G/Wp2cilgmCxUJRa9EipYUTZpHnnv2kYfI HoTPsm/DuZxIVtXqQxAo06TzMNyRkP7fgpXpDsQiNWB0DdN2WyXD0KPS60dwMv12tkVw +axc/vo8jZ2a57bTcJDTpanyFfgzbz/04n7tyXXvDAFIRJok6vBVbnEHKoxOCGIh3cW6 cS4PAbsBh3N8IFdgkTS1ytAwHx95AdyW3uGHUviO7xf+DhsCu2oQcVwSddDzu0fYDOpC 5Qgx7qlyuXNUNvqIxicjs3XpaLdknPwsIX2g1HprHs6/CeYsKgNGuZ074PoX9i7a7bCP KHXQ== X-Forwarded-Encrypted: i=1; AJvYcCWqyDzNJ++gcyBrEYW0/ENxhA8Cr3bC1BoIHOi03F+bRqXygKcNF312RB56PPugudcEoK1OHNcJuWMtIjTUCVvW6K37Zf2VUhHF9Ej1pTxwfs4AYvM= X-Gm-Message-State: AOJu0YzoiPVrg9AuXicxpPxaFY/f06aKIBomTv77X28WBpgFNx8ScooK pfgTWF8oDTNTuJTdbBxzpf0vWL9wl0A76LPTmbjDDUd73Ie7+EvB9iuQoytnsHg= X-Google-Smtp-Source: AGHT+IF9T4xVGnEMDWOvmebwvh7RSH//MnjXmlytzIKhD9eeivlJmumrE3KnhdTbwCwawu0TsPm8Jg== X-Received: by 2002:a05:6402:4347:b0:568:1882:651f with SMTP id n7-20020a056402434700b005681882651fmr276209edc.25.1710793069043; Mon, 18 Mar 2024 13:17:49 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.144]) by smtp.gmail.com with ESMTPSA id g18-20020a056402091200b00568b6f73491sm3513123edz.14.2024.03.18.13.17.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 13:17:48 -0700 (PDT) Message-ID: Date: Mon, 18 Mar 2024 22:17:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 27/39] clk: at91: sam9x7: add sam9x7 pmc driver Content-Language: en-US To: Varshini.Rajendran@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223172831.672953-1-varshini.rajendran@microchip.com> <01e96d4b-3038-498b-a9b2-2acac51f1d80@tuxon.dev> From: claudiu beznea In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_131752_786186_29454D4E X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18.03.2024 11:25, Varshini.Rajendran@microchip.com wrote: > Hi Claudiu, > > On 11/03/24 11:28 am, claudiu beznea wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 23.02.2024 19:28, Varshini Rajendran wrote: >>> Add a driver for the PMC clocks of sam9x7 Soc family. >>> >>> Signed-off-by: Varshini Rajendran >>> --- >>> Changes in v4: >>> - Changed variable name alloc_mem to clk_mux_buffer to be more >>> suggestive >>> - Changed description of @f structure member appropriately >>> --- >>> drivers/clk/at91/Makefile | 1 + >>> drivers/clk/at91/sam9x7.c | 946 ++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 947 insertions(+) >>> create mode 100644 drivers/clk/at91/sam9x7.c >>> >>> diff --git a/drivers/clk/at91/Makefile b/drivers/clk/at91/Makefile >>> index 89061b85e7d2..8e3684ba2c74 100644 >>> --- a/drivers/clk/at91/Makefile >>> +++ b/drivers/clk/at91/Makefile [ ... ] >>> +static const struct { >>> + const char *n; >>> + const char *p; >>> + const struct clk_pll_layout *l; >>> + u8 t; >>> + const struct clk_pll_characteristics *c; >>> + unsigned long f; >>> + u8 eid; >>> +} sam9x7_plls[][PLL_ID_MAX] = { >>> + [PLL_ID_PLLA] = { >>> + { >>> + .n = "plla_fracck", >>> + .p = "mainck", >>> + .l = &plla_frac_layout, >>> + .t = PLL_TYPE_FRAC, >>> + /* >>> + * This feeds plla_divpmcck which feeds CPU. It should >>> + * not be disabled. >>> + */ >>> + .f = CLK_IS_CRITICAL | CLK_SET_RATE_GATE, >>> + .c = &plla_characteristics, >>> + }, >>> + >>> + { >>> + .n = "plla_divpmcck", >>> + .p = "plla_fracck", >>> + .l = &pll_divpmc_layout, >> >> You mentioned in "[PATCH v4 24/39] clk: at91: sam9x7: add support for HW >> PLL freq dividers" that this has div2 but it is registered w/ a layout that >> has .div2 = 0. > > This is handled in the above plla_fracck fractional part as defined in > the plla_frac_layout. Ah, right. I missed the changes in sam9x60_frac_pll_recalc_rate(). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel