From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04DADC4332F for ; Wed, 9 Nov 2022 08:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NYSm4iTepNyfq03NHJVdMfpQm4Z1jzSgC5mPnO48EPo=; b=0fFN+N6RyxfKdS 4+88tFobX0gCErHhkaAUSl8Zy6U4pM/yW8gT5y0OavMvV3/4ksgvcrimRhPQhR2bYJB1t6dp/zA9a 35MOp64JpgCXNxFT497hTEEsi+IXRBptbuF8SMpPAlxDWKh7Zbq04ywGTZXSULF6SGc+DCcVXAtmC zV1ghjj4/p0+u8+TBHHMOD3HcEBhEslTJcedS3ThNqKlXDPgLEoZvB1SSyHpKLMhXfRH+Eou1d/Xj 9Ke81gIgLSUhNTM5k7DIzd4h+oaDxvVlLcyK0EhiCzVEOaD5bldoCDibY7bCAJ/5QYk6veHKVlUSW /OfKm9q0CFP8TKsVWUSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osgok-00C1sr-Mz; Wed, 09 Nov 2022 08:52:19 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osgog-00C1qU-WB for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 08:52:16 +0000 Received: by mail-lj1-x236.google.com with SMTP id l8so24710661ljh.13 for ; Wed, 09 Nov 2022 00:52:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=46OCH59w3LqN3DFnsBqHvYNV0xn8XCE9P307ZDZk3AA=; b=bOaHLlQzCqgpoDKIfAdOcPxyMphds2gW/+oEmQWmBaJ/oY0Bo1T9UeLWt2Wfr1fnbR apcZlaVOeC0ltdwp+RcGkjrSQ8AYPEHsKA/bKYq3h21kLm3CEJEavx+9H/LxQCdXoJdQ pWS5vnaWB/oYp3GcgMYgx1WVRUe6auS5DOn8GthKriRrCAArJshSf4K8GYs6kHWQVmeH XhNaaQwYRSj7F/a4W9srQXIyqk8K25mNTqZgDAC4G1JU/Ku/5XeYeG2aHe9pxPUrKYkP 8S8k6iIIVUAuEuwBTnd4EkTgx9QP9aaYv7BV76kPfpec2SaELovmoVWnj7b2v7n7Mhds C6qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=46OCH59w3LqN3DFnsBqHvYNV0xn8XCE9P307ZDZk3AA=; b=jTRbgXAtnjTTtvqYhdnPXHEa9M4aXSoz6WasDDTK018g1TXFO3nxfYxtJKAod0BBoe FhhDXdFDhRYRzZGAuUHW9sIfqPOTTNPSXmyeCgvWDYTJGs4+AREm0SQ2MYk82YoIMUqc IhWjY4aC4cfDyVet7vppsZfP1nr8vfqA0cua7KUiBpl6OB61F4547xMuAawz5Uj1nfjm M6jy5Zu151ciwJgGLCRlpfCIm951MT1cVEfw/lxmyPdsSI4bXCqxD3OuS0MBZ082BUi3 blc6TnvPPyVa97RUEpRLc0ipyJaZ6bpIskmUNkZF16mexmW2sPJtb43Zoxx7s9aL3vOq EbNw== X-Gm-Message-State: ANoB5pmohNQtZuGPQqEtALWoDv2lFoqYgwDm+Jugem459vGdCE+HmKSS MyR/V15s3q9gszvok4ANqTIkoA== X-Google-Smtp-Source: AA0mqf4PijX6S+EWsWi7KC+JIidbUh1ZOg831La7EQ62sybOOoU91PYCjv+jKar1i9GEc6DOyGmVTA== X-Received: by 2002:a2e:9e41:0:b0:277:155c:f510 with SMTP id g1-20020a2e9e41000000b00277155cf510mr2456552ljk.17.1667983932706; Wed, 09 Nov 2022 00:52:12 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id t8-20020ac25488000000b004b0b131453csm2132827lfk.49.2022.11.09.00.52.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 00:52:12 -0800 (PST) Message-ID: Date: Wed, 9 Nov 2022 09:52:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/7] MFD: TPS6594x: Add new PMIC device driver for TPS6594x chips Content-Language: en-US To: Matt Ranostay , brgl@bgdev.pl, lee@kernel.org, linus.walleij@linaro.org, kristo@kernel.org, alexandre.belloni@bootlin.com, a.zummo@towertech.it, krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, vigneshr@ti.com Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-gpio@vger.kernel.org, Keerthy References: <20221109065546.24912-1-mranostay@ti.com> <20221109065546.24912-3-mranostay@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20221109065546.24912-3-mranostay@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_005215_129545_CBC963D3 X-CRM114-Status: GOOD ( 30.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/11/2022 07:55, Matt Ranostay wrote: > From: Keerthy > Use subject prefixes matching the subsystem (git log --oneline -- ...). > The TPS6594x chip is a PMIC, and contains the following components: > > - GPIO controller > - RTC > > However initially only RTC is supported. > > Signed-off-by: Keerthy > Signed-off-by: Matt Ranostay > --- > drivers/mfd/Kconfig | 14 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/tps6594x.c | 120 +++++++++++++++++++++++++++++++++++ > include/linux/mfd/tps6594x.h | 84 ++++++++++++++++++++++++ > 4 files changed, 219 insertions(+) > create mode 100644 drivers/mfd/tps6594x.c > create mode 100644 include/linux/mfd/tps6594x.h > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 6e920442366c..9a6dc6b69058 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1596,6 +1596,20 @@ config MFD_TI_LP873X > This driver can also be built as a module. If so, the module > will be called lp873x. > > +config MFD_TPS6594X > + tristate "TI TPS6594X Power Management IC" > + depends on I2C && OF > + select MFD_CORE > + select REGMAP_I2C > + help > + If you say yes here then you get support for the TPS6594X series of > + Power Management Integrated Circuits (PMIC). > + These include voltage regulators, RTS, configurable > + General Purpose Outputs (GPO) that are used in portable devices. > + > + This driver can also be built as a module. If so, the module > + will be called tps6594x. > + > config MFD_TI_LP87565 > tristate "TI LP87565 Power Management IC" > depends on I2C && OF > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 4dd479212b3a..51d7bfcd0a27 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -101,6 +101,7 @@ obj-$(CONFIG_MFD_TPS65910) += tps65910.o > obj-$(CONFIG_MFD_TPS65912) += tps65912-core.o > obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o > obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o > +obj-$(CONFIG_MFD_TPS6594X) += tps6594x.o > obj-$(CONFIG_MENELAUS) += menelaus.o > > obj-$(CONFIG_TWL4030_CORE) += twl-core.o twl4030-irq.o twl6030-irq.o > diff --git a/drivers/mfd/tps6594x.c b/drivers/mfd/tps6594x.c > new file mode 100644 > index 000000000000..0de7946b6b8b > --- /dev/null > +++ b/drivers/mfd/tps6594x.c > @@ -0,0 +1,120 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Driver for tps6594x PMIC chips > + * > + * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/ > + * Author: Keerthy > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static const struct regmap_config tps6594x_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + .max_register = TPS6594X_REG_MAX, > +}; > + > +static const struct mfd_cell tps6594x_cells[] = { > + { .name = "tps6594x-gpio" }, > + { .name = "tps6594x-rtc" }, You have compatibles for children, so use them. > +}; > + > +static struct tps6594x *tps; > + > +static void tps6594x_power_off(void) > +{ > + regmap_write(tps->regmap, TPS6594X_FSM_NSLEEP_TRIGGERS, > + TPS6594X_FSM_NSLEEP_NSLEEP1B | TPS6594X_FSM_NSLEEP_NSLEEP2B); > + > + regmap_write(tps->regmap, TPS6594X_INT_STARTUP, > + TPS6594X_INT_STARTUP_NPWRON_START_INT | > + TPS6594X_INT_STARTUP_ENABLE_INT | TPS6594X_INT_STARTUP_RTC_INT | > + TPS6594X_INT_STARTUP_SOFT_REBOOT_INT); > + > + regmap_write(tps->regmap, TPS6594X_INT_MISC, > + TPS6594X_INT_MISC_BIST_PASS_INT | > + TPS6594X_INT_MISC_EXT_CLK_INT | TPS6594X_INT_MISC_TWARN_INT); > + > + regmap_write(tps->regmap, TPS6594X_CONFIG_1, > + TPS6594X_CONFIG_NSLEEP1_MASK | TPS6594X_CONFIG_NSLEEP2_MASK); > + > + regmap_write(tps->regmap, TPS6594X_FSM_I2C_TRIGGERS, > + TPS6594X_FSM_I2C_TRIGGERS_I2C0); > +} > + > +static int tps6594x_probe(struct i2c_client *client) > +{ > + struct tps6594x *ddata; > + struct device_node *node = client->dev.of_node; > + unsigned int otpid; > + int ret; > + > + ddata = devm_kzalloc(&client->dev, sizeof(*ddata), GFP_KERNEL); > + if (!ddata) > + return -ENOMEM; > + > + ddata->dev = &client->dev; > + > + ddata->regmap = devm_regmap_init_i2c(client, &tps6594x_regmap_config); > + if (IS_ERR(ddata->regmap)) { > + ret = PTR_ERR(ddata->regmap); > + dev_err(ddata->dev, > + "Failed to initialize register map: %d\n", ret); > + return ret; return dev_err_probe > + } > + > + ret = regmap_read(ddata->regmap, TPS6594X_REG_DEV_REV, &otpid); > + if (ret) { > + dev_err(ddata->dev, "Failed to read OTP ID\n"); > + return ret; return dev_err_probe > + } > + > + ddata->rev = otpid; > + i2c_set_clientdata(client, ddata); > + > + ret = mfd_add_devices(ddata->dev, PLATFORM_DEVID_AUTO, tps6594x_cells, > + ARRAY_SIZE(tps6594x_cells), NULL, 0, NULL); > + if (ret) { > + dev_err(ddata->dev, "Failed to register cells\n"); > + return ret; return dev_err_probe > + } > + > + tps = ddata; > + > + if (of_property_read_bool(node, "ti,system-power-controller")) > + pm_power_off = tps6594x_power_off; > + > + return 0; > +} Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel