From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EE9FC54E94 for ; Wed, 25 Jan 2023 16:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=stSDBZwaTc8dx1eRSDsHqMgTIjZNAx4hVQySsZbhb9k=; b=moAYaJiQIwzM1W 2C8Fh+TsW4lNNRauknEutDFIsHealAdEnh4D5/1svhkCYy8XaslQkvbxVkBXKUvbLOLGDpWdQa+vh 4epMYJJXtXhxy6yrr1MZXSzcEuXn9KWQ2wEzgIDJApfaYaxUv9+LGj1n5f/qXkLEVB5aHyN6sEKqw X6jnZlJIu+axj50yBxAY1b29Sjo5xJ0QRiRKkxLtCh2ozHhQSPBU5hFtjrirZ8e4qaADxIM0DvWwG rkZ7gp1bpoSgC/wMNThm5lKey5WbGdmZVhKTIcucYr0MitjZ0Nc9iQNKeGHKGbwEscpNsYY2shuQT IySGX7htXLQVFiu14dDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKivo-0082oA-Ne; Wed, 25 Jan 2023 16:47:29 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKiv8-0082QO-IG for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 16:46:48 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9BCA0856CA; Wed, 25 Jan 2023 17:46:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1674665204; bh=ELe7sNCIKhzIhAIEvK/gbGq94iiKiM0v2v0PvH85gc0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oz8XbnxCu2ZV30t6/kQEk5rYvTgHME+DYJnAsThYPGJ0XIoITi45VS2UV/mMxbEH9 li4X3z/C5ihPYKMksanzsojAI+iteGg9X3798kM3x+wuf8wa+VMwFr6b6hZ1UZ2WXO OKlj9zv1ZTesft9RGiMXpCiF4wI9NQR9gvpuNGH+SYdVBSOmbZeq0U+FB5ShH2tH9W m4j+cEZ+i32tCIgByfsIBeNNwwkmKRLsCvIMdhkGMHcLljAkscD0mLw3hzATHupZRZ JdFfBLx61gccRCnAAsEikcvix6uALOkCn+vAO4UN4xlqCBjMxJJ6MLWBbFG0GWDh48 yHWRse7IFay3Q== Message-ID: Date: Wed, 25 Jan 2023 17:46:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RESEND PATCH v11 13/18] drm: exynos: dsi: Add Exynos based host irq hooks To: Jagan Teki Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Robert Foss , Laurent Pinchart , Tommaso Merciai , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula References: <20230123151212.269082-1-jagan@amarulasolutions.com> <20230123151212.269082-14-jagan@amarulasolutions.com> <43f4a7dc-a4cc-7552-1a6d-a2a49fae6020@denx.de> Content-Language: en-US From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_084647_067218_0EEE0742 X-CRM114-Status: GOOD ( 22.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/25/23 15:04, Jagan Teki wrote: > On Wed, Jan 25, 2023 at 7:23 PM Marek Vasut wrote: >> >> On 1/25/23 07:54, Jagan Teki wrote: >>> On Wed, Jan 25, 2023 at 2:54 AM Jagan Teki wrote: >>>> >>>> On Wed, Jan 25, 2023 at 2:54 AM Jagan Teki wrote: >>>>> >>>>> On Wed, Jan 25, 2023 at 2:42 AM Marek Vasut wrote: >>>>>> >>>>>> On 1/24/23 22:01, Jagan Teki wrote: >>>>>>> On Wed, Jan 25, 2023 at 2:18 AM Marek Vasut wrote: >>>>>>>> >>>>>>>> On 1/23/23 16:12, Jagan Teki wrote: >>>>>>>>> Enable and disable of te_gpio's are Exynos platform specific >>>>>>>>> irq handling, so add the exynos based irq operations and hook >>>>>>>>> them for exynos plat_data. >>>>>>>> >>>>>>>> If this is just an optional generic GPIO IRQ, why not keep it in the >>>>>>>> core code ? TE (tearing enable?) should be available on MX8M too. >>>>>>> >>>>>>> So far the discussion (since from initial versions) with Marek >>>>>>> Szyprowski, seems to be available in Exynos. So, I keep it separate >>>>>>> from the DSIM core. >>>>>> >>>>>> Isn't TE a generic GPIO IRQ ? If so, it is available also on i.MX8M . >>>> >>>> I will check this. >>> >>> In order to use TE_GPIO we need te handler implementation, right now >>> Exynos CRTC DRM drivers have implementation for this. That is the main >>> reason to keep the TE_GPIO handling in exynos, maybe if we handle that >>> generically then it is a viable option to move TE_GPIO to the DSIM >>> core. >> >> I think you can do this exactly the same way exynos does it -- check >> whether te_handler() callback is implemented by the glue code (the one >> you already have for various exynos and imx8mm/imx8mm SoCs) and if so, >> call it. If it is not implemented, do not call anything in the TE IRQ >> handler. > > I need to understand how i.MX8MM handles this on TE IRQ in the DSIM > host side, Can I do this in future patch set as it might involve > bindings changes as well if it's part of DSIM? Why not leave an empty te_handler implementation on MX8M for now ? You can fill that implementation in future patchset, but the generic part of the code would be in place . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel