From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBDAFC433E1 for ; Sat, 22 Aug 2020 20:51:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CBE72072D for ; Sat, 22 Aug 2020 20:51:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TlEpalCE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sXxIwStB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CBE72072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C+xKedA+L3EXLJ9A53cSQiYOcYu1vTcP79FBsPgJG2U=; b=TlEpalCEEgVKzGbTnQfOqbG7z xw/dMWjrRiJGzuKMkprV34Uuw1cfXk88GzeOGwGg4sTpef5/C242I+6kZh/zxTgslfJlGXGTbZD1X LvwwiRIuAMNoh5yk3n5I9yIZHr4IikjqxoTG6IjVp48uBR1Bh31Az2MG0T+EJy5vUdCbrmTrn0yYz 3TySrF8nf+4DbY/Z6yGWFmZWwqD9wjo+m6Wj2WmaYZCy0Rh1tDLBVnbgE+IAnKCEyQPik7fUIbo8b ncnwxg9JLQ2fpWXWuoBgyveHTgr3dIpBwPvumAc9Sz6MMptOn1yQuoSEhGowZ1v2sEbwo0XisjlMv FxRIfPX1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9aSM-0003l5-T9; Sat, 22 Aug 2020 20:49:42 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9aSI-0003jp-OU for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2020 20:49:40 +0000 Received: by mail-pj1-x1031.google.com with SMTP id q93so2038708pjq.0 for ; Sat, 22 Aug 2020 13:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hH9H2ABdvu9ijY93JDRl5gL40YddKNa5RSjoOsfkU4Q=; b=sXxIwStBLLksVtoDY6Thna2iknz5zpi0NCdBinkz6KrjU9uNu46he8yHY8M877YbOU C0GbsSkyhV792XReqRG14ji6CWGcrQx4nMbuDNrJv0C8kBFPXijZ8LRargFPwTJQhUlg S+IK2P8fg8HHOo0sjq8AWUdlvhrX2fTqa8hzpBge0AaKBSnS5ANEgFMX6GDdcKzppZS4 5dDz5MO2UK54eIotNw+/j7tzw3tBgwoYnTl8d0HZ9af36ZWAwgAWJ3zxlL9NLTCnA/Eo KY5MYQ8Z38OXIxi1/v637x1EY3Dog34sMIIoHszE2w2OUP3kwq2xCg3sLY2G30PW6vp7 4O9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hH9H2ABdvu9ijY93JDRl5gL40YddKNa5RSjoOsfkU4Q=; b=lj5Qiqg3/NqxMFYcicADW1V/LcikrHzY6Hb9f79iA87UWVP9KVCOYZVro10O4RgirI OI1Ts0LbLOWmHqoLhg3ZMEac7kkbAhGlR5DMCw7x8DQ0s4EVqVkROOih5VXEznAtIJYg 6xTwNb6jpwbj5kK+MNAXvww6u4zQ5R8qZNAHspqiqeGWnI9YWYGghRgfc9jlxs+TPGs8 xBsuTeqsq1YfwWTed7ZcTrhN/63jjaXYxGdFsfIc0qmbxqkHfeF6Xgh+8Ro2pSj82QpN nr4ZwsosRjvHfVUR1HbKFOh2KnIAM49HjXx+ORk391KaXHLGgMxRIUTYpOBph9Ks47iP Qlgg== X-Gm-Message-State: AOAM532RyDb4u/Ol7taJiW6YcJsE7q7CZyl/e2C9eBW3R6oYpxxWdcXc qAk+VnqbHc3y0R7O7fOfwEc= X-Google-Smtp-Source: ABdhPJzA2V6uZzLuxDmG9sZngQJ9nzaNbuju8ETafw3nojOp/GVQMK4+8LYyCKyCzE8qqezlfXHnFg== X-Received: by 2002:a17:90a:514a:: with SMTP id k10mr5489033pjm.81.1598129376538; Sat, 22 Aug 2020 13:49:36 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id 143sm1079390pfc.66.2020.08.22.13.49.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Aug 2020 13:49:35 -0700 (PDT) Subject: Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds To: Markus Mayer References: <20200821165221.32267-1-mmayer@broadcom.com> <20200822115636.GA19975@kozik-lap> <20200822164619.GA24669@kozik-lap> <81b2ad54-d4ef-cf98-886c-61c79e4cac62@gmail.com> From: Florian Fainelli Message-ID: Date: Sat, 22 Aug 2020 13:49:34 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_164938_982803_2657BC55 X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Ian King , BCM Kernel Feedback , Linux ARM Kernel , Krzysztof Kozlowski , Linux Kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/22/2020 1:47 PM, Markus Mayer wrote: > On Sat, 22 Aug 2020 at 13:21, Florian Fainelli wrote: >> >> On 8/22/2020 1:14 PM, Markus Mayer wrote: >>> On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: >>>> >>>> On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: >>>>> On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski wrote: >>>>>> >>>>>> On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: >>>>>>> We would overrun the error_text array if we hit a TIMEOUT condition, >>>>>>> because we were using the error code "ETIMEDOUT" (which is 110) as an >>>>>>> array index. >>>>>>> >>>>>>> We fix the problem by correcting the array index and by providing a >>>>>>> function to retrieve error messages rather than accessing the array >>>>>>> directly. The function includes a bounds check that prevents the array >>>>>>> from being overrun. >>>>>>> >>>>>>> This patch was prepared in response to >>>>>>> https://lkml.org/lkml/2020/8/18/505. >>>>>>> >>>>>>> Signed-off-by: Markus Mayer >>>>>> >>>>>> Your Signed-off-by does not match From field. Please run >>>>>> scripts/checkpatch on every patch you send. >>>>>> >>>>>> I fixed it up, assuming markus.mayer@broadcom.com is the valid email >>>>>> address. >>>>> >>>>> No. I have always been using mmayer@broadcom.com since it is shorter. >>>>> That's also what's in the MAINTAINERS file. Please change it back. I >>>>> accidentally used the long form for one of my e-mail replies which is >>>>> where the confusion must have originated. >>>> >>>> I'll drop the patch then. You need to resend with SoB matching email. >>> >>> Oh, I am starting to see what's happening here. This is new and >>> apparently due to some changes with the mail server setup on our end. >>> >>> I have this in my patch file: >>> >>> $ head 0001-memory-brcmstb_dpfe-fix-array-index-out-of-bounds.patch >>> From 6b424772d4c84fa56474b2522d0d3ed6b2b2b360 Mon Sep 17 00:00:00 2001 >>> From: Markus Mayer >>> Date: Fri, 21 Aug 2020 08:56:52 -0700 >>> >>> Sending patches like this used to work. Clearly our SMTP server has >>> now taken it upon itself to rewrite the sender e-mail address. I >>> wasn't expecting that. Let me look into it. Sorry for the hassle. It >>> was not intentional. >> >> Yes, if you used to use the SMTP relay server which did not require >> authentication for internal hosts, and now you use smtp.gmail.com with >> your broadcom.com username, the SMTP server will rewrite the From: to >> match the username used to authenticate with the server. > > Actually, it was the other way around. Connecting to smtp.gmail.com > does allow the "From:" header to be customized. The envelope sender, > i.e. the "From " line at the very beginning of the e-mail, might still > get rewritten, but that's okay since the "From:" header is left alone. > The internal SMTP server, however, which does not require > authentication, unexpectedly rewrites the "From:" header in the middle > of the e-mail header. > > Got it set up now in a way that should work. At least it did in my > test. I'll send out v3 of the patch momentarily, and then we'll know > for sure. Reason #42 why I hide behind my gmail.com account! Glad you sorted it out. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel