From: troy.kisky@boundarydevices.com (Troy Kisky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] RFC: ARM: dts: imx7d-sdb: remove 100k pull-down on USDHCx clock
Date: Thu, 15 Jun 2017 10:46:26 -0700 [thread overview]
Message-ID: <c69c5ffb-1142-74fa-4be4-1112c49ae67c@boundarydevices.com> (raw)
In-Reply-To: <AM3PR04MB306DAC69AE94A872373206280C00@AM3PR04MB306.eurprd04.prod.outlook.com>
On 6/14/2017 9:31 PM, A.s. Dong wrote:
> Hi Troy,
>
>> -----Original Message-----
>> From: Shawn Guo [mailto:shawnguo at kernel.org]
>> Sent: Thursday, June 15, 2017 11:39 AM
>> To: Troy Kisky; A.s. Dong; Frank Li
>> Cc: shawn.guo at linaro.org; Fabio Estevam; gary.bisson at boundarydevices.com;
>> linux-arm-kernel at lists.infradead.org
>> Subject: Re: [PATCH 1/2] RFC: ARM: dts: imx7d-sdb: remove 100k pull-down
>> on USDHCx clock
>>
>> On Wed, Jun 07, 2017 at 10:45:41AM -0700, Troy Kisky wrote:
>>> No i.mx6q board uses a 100k pull-down on clock, why should i.mx7d ?
>>>
>
> I saw the mx7d evk clk resistor pull-down is DNP,
> then why we disable internal pad pull-down?
That sounds like a very good reason to disable to me.
Why rely on a DNP? Also, consistency with imx6 is nice.
>
> Regards
> Dong Aisheng
>
>>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>>
>> Add Dong and Frank who may help to confirm.
>>
>> Shawn
>>
>>> ---
>>> arch/arm/boot/dts/imx7d-sdb.dts | 14 +++++++-------
>>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts
>>> b/arch/arm/boot/dts/imx7d-sdb.dts index 54c4540..cab9208 100644
>>> --- a/arch/arm/boot/dts/imx7d-sdb.dts
>>> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
>>> @@ -591,7 +591,7 @@
>>> pinctrl_usdhc1: usdhc1grp {
>>> fsl,pins = <
>>> MX7D_PAD_SD1_CMD__SD1_CMD 0x59
>>> - MX7D_PAD_SD1_CLK__SD1_CLK 0x19
>>> + MX7D_PAD_SD1_CLK__SD1_CLK 0x09
>>> MX7D_PAD_SD1_DATA0__SD1_DATA0 0x59
>>> MX7D_PAD_SD1_DATA1__SD1_DATA1 0x59
>>> MX7D_PAD_SD1_DATA2__SD1_DATA2 0x59
>>> @@ -605,7 +605,7 @@
>>> pinctrl_usdhc2: usdhc2grp {
>>> fsl,pins = <
>>> MX7D_PAD_SD2_CMD__SD2_CMD 0x59
>>> - MX7D_PAD_SD2_CLK__SD2_CLK 0x19
>>> + MX7D_PAD_SD2_CLK__SD2_CLK 0x09
>>> MX7D_PAD_SD2_DATA0__SD2_DATA0 0x59
>>> MX7D_PAD_SD2_DATA1__SD2_DATA1 0x59
>>> MX7D_PAD_SD2_DATA2__SD2_DATA2 0x59
>>> @@ -616,7 +616,7 @@
>>> pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
>>> fsl,pins = <
>>> MX7D_PAD_SD2_CMD__SD2_CMD 0x5a
>>> - MX7D_PAD_SD2_CLK__SD2_CLK 0x1a
>>> + MX7D_PAD_SD2_CLK__SD2_CLK 0x0a
>>> MX7D_PAD_SD2_DATA0__SD2_DATA0 0x5a
>>> MX7D_PAD_SD2_DATA1__SD2_DATA1 0x5a
>>> MX7D_PAD_SD2_DATA2__SD2_DATA2 0x5a
>>> @@ -627,7 +627,7 @@
>>> pinctrl_usdhc2_200mhz: usdhc2grp_200mhz {
>>> fsl,pins = <
>>> MX7D_PAD_SD2_CMD__SD2_CMD 0x5b
>>> - MX7D_PAD_SD2_CLK__SD2_CLK 0x1b
>>> + MX7D_PAD_SD2_CLK__SD2_CLK 0x0b
>>> MX7D_PAD_SD2_DATA0__SD2_DATA0 0x5b
>>> MX7D_PAD_SD2_DATA1__SD2_DATA1 0x5b
>>> MX7D_PAD_SD2_DATA2__SD2_DATA2 0x5b
>>> @@ -639,7 +639,7 @@
>>> pinctrl_usdhc3: usdhc3grp {
>>> fsl,pins = <
>>> MX7D_PAD_SD3_CMD__SD3_CMD 0x59
>>> - MX7D_PAD_SD3_CLK__SD3_CLK 0x19
>>> + MX7D_PAD_SD3_CLK__SD3_CLK 0x09
>>> MX7D_PAD_SD3_DATA0__SD3_DATA0 0x59
>>> MX7D_PAD_SD3_DATA1__SD3_DATA1 0x59
>>> MX7D_PAD_SD3_DATA2__SD3_DATA2 0x59
>>> @@ -655,7 +655,7 @@
>>> pinctrl_usdhc3_100mhz: usdhc3grp_100mhz {
>>> fsl,pins = <
>>> MX7D_PAD_SD3_CMD__SD3_CMD 0x5a
>>> - MX7D_PAD_SD3_CLK__SD3_CLK 0x1a
>>> + MX7D_PAD_SD3_CLK__SD3_CLK 0x0a
>>> MX7D_PAD_SD3_DATA0__SD3_DATA0 0x5a
>>> MX7D_PAD_SD3_DATA1__SD3_DATA1 0x5a
>>> MX7D_PAD_SD3_DATA2__SD3_DATA2 0x5a
>>> @@ -671,7 +671,7 @@
>>> pinctrl_usdhc3_200mhz: usdhc3grp_200mhz {
>>> fsl,pins = <
>>> MX7D_PAD_SD3_CMD__SD3_CMD 0x5b
>>> - MX7D_PAD_SD3_CLK__SD3_CLK 0x1b
>>> + MX7D_PAD_SD3_CLK__SD3_CLK 0x0b
>>> MX7D_PAD_SD3_DATA0__SD3_DATA0 0x5b
>>> MX7D_PAD_SD3_DATA1__SD3_DATA1 0x5b
>>> MX7D_PAD_SD3_DATA2__SD3_DATA2 0x5b
>>> --
>>> 2.7.4
>>>
>>>
>>> _______________________________________________
>>> linux-arm-kernel mailing list
>>> linux-arm-kernel at lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2017-06-15 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 17:45 [PATCH 1/2] RFC: ARM: dts: imx7d-sdb: remove 100k pull-down on USDHCx clock Troy Kisky
2017-06-07 17:45 ` [PATCH 2/2] RFC: ARM: dts: imx7d-sdb: swap pad settings for USDHCx 50Mhz and 100Mhz Troy Kisky
2017-06-15 3:39 ` Shawn Guo
2017-06-15 4:52 ` A.s. Dong
2017-06-15 3:38 ` [PATCH 1/2] RFC: ARM: dts: imx7d-sdb: remove 100k pull-down on USDHCx clock Shawn Guo
2017-06-15 4:31 ` A.s. Dong
2017-06-15 17:46 ` Troy Kisky [this message]
2017-06-27 5:32 ` A.s. Dong
2017-06-27 20:22 ` Troy Kisky
2017-06-27 20:30 ` Fabio Estevam
2017-06-27 20:49 ` Troy Kisky
2017-06-27 23:27 ` Fabio Estevam
2017-06-27 23:49 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c69c5ffb-1142-74fa-4be4-1112c49ae67c@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).