From: Krzysztof Kozlowski <krzk@kernel.org>
To: Markuss Broks <markuss.broks@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Maksym Holovach <nergzd@nergzd723.xyz>
Subject: Re: [PATCH v3 08/10] pinctrl: samsung: Add Exynos9810 SoC specific data
Date: Mon, 28 Oct 2024 08:30:39 +0100 [thread overview]
Message-ID: <c6dce2c7-5233-40a0-a530-fd6b31a3f694@kernel.org> (raw)
In-Reply-To: <20241026-exynos9810-v3-8-b89de9441ea8@gmail.com>
On 26/10/2024 22:32, Markuss Broks wrote:
> +};
> +
> +/* pin banks of exynos9810 pin-controller 2 (CHUB) */
> +static const struct samsung_pin_bank_data exynos9810_pin_banks2[] __initconst = {
> + EXYNOS850_PIN_BANK_EINTG(8, 0x000, "gph0", 0x00),
> + EXYNOS850_PIN_BANK_EINTG(5, 0x020, "gph1", 0x04),
> +};
> +
> +/* pin banks of exynos9810 pin-controller 3 (CMGP) */
> +static const struct samsung_pin_bank_data exynos9810_pin_banks3[] __initconst = {
> + EXYNOS850_PIN_BANK_EINTW(1, 0x000, "gpm0", 0x00),
> + EXYNOS850_PIN_BANK_EINTW(1, 0x020, "gpm1", 0x04),
> + EXYNOS850_PIN_BANK_EINTW(1, 0x040, "gpm2", 0x08),
> + EXYNOS850_PIN_BANK_EINTW(1, 0x060, "gpm3", 0x0C),
> + EXYNOS850_PIN_BANK_EINTW(1, 0x080, "gpm4", 0x10),
How did you implement previous feedback about lowercase hex?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-28 7:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 20:32 [PATCH v3 00/10] Add support for Exynos9810 SoC and Samsung Galaxy S9 (SM-G960F) Markuss Broks
2024-10-26 20:32 ` [PATCH v3 01/10] dt-bindings: arm: cpus: Add Samsung Mongoose M3 Markuss Broks
2024-10-27 19:59 ` (subset) " Krzysztof Kozlowski
2024-10-26 20:32 ` [PATCH v3 02/10] dt-bindings: hwinfo: samsung,exynos-chipid: Add Samsung exynos9810 compatible Markuss Broks
2024-10-27 19:51 ` Krzysztof Kozlowski
2024-10-27 19:55 ` (subset) " Krzysztof Kozlowski
2024-10-26 20:32 ` [PATCH v3 03/10] dt-bindings: pinctrl: samsung: Add compatible for Exynos9810 SoC Markuss Broks
2024-10-27 20:02 ` (subset) " Krzysztof Kozlowski
2024-10-26 20:32 ` [PATCH v3 04/10] dt-bindings: pinctrl: samsung: Add compatible for exynos9810-wakeup-eint Markuss Broks
2024-10-27 20:02 ` (subset) " Krzysztof Kozlowski
2024-10-26 20:32 ` [PATCH v3 05/10] dt-bindings: soc: samsung: exynos-pmu: Add exynos9810 compatible Markuss Broks
2024-10-27 19:59 ` (subset) " Krzysztof Kozlowski
2024-10-26 20:32 ` [PATCH v3 06/10] dt-bindings: arm: samsung: Document Exynos9810 and starlte board binding Markuss Broks
2024-10-27 19:59 ` (subset) " Krzysztof Kozlowski
2024-10-26 20:32 ` [PATCH v3 07/10] soc: samsung: exynos-chipid: Add support for Exynos9810 SoC Markuss Broks
2024-10-27 19:55 ` (subset) " Krzysztof Kozlowski
2024-10-26 20:32 ` [PATCH v3 08/10] pinctrl: samsung: Add Exynos9810 SoC specific data Markuss Broks
2024-10-27 20:02 ` (subset) " Krzysztof Kozlowski
2024-10-28 7:30 ` Krzysztof Kozlowski [this message]
2024-10-26 20:32 ` [PATCH v3 09/10] arm64: dts: exynos: Add Exynos9810 SoC support Markuss Broks
2024-10-27 20:00 ` (subset) " Krzysztof Kozlowski
2024-10-28 6:46 ` Krzysztof Kozlowski
2024-10-26 20:32 ` [PATCH v3 10/10] arm64: dts: exynos: Add initial support for Samsung Galaxy S9 (SM-G960F) Markuss Broks
2024-10-27 20:00 ` (subset) " Krzysztof Kozlowski
2024-10-28 6:50 ` Krzysztof Kozlowski
2024-10-28 9:05 ` Markuss Broks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6dce2c7-5233-40a0-a530-fd6b31a3f694@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=markuss.broks@gmail.com \
--cc=nergzd@nergzd723.xyz \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).