From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70F79C433FE for ; Thu, 17 Nov 2022 17:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D3FEjEtB6nFvfVDsEKchAssAYEBrBvO/mU2w7zCSHbA=; b=cNVCCfaLARYik5nwaAbxZ/T3ha wST26emIDQOYC73u4w45+WNBOY1TQoeMZl1mMAZy2ZCbN7BfACULkEAaoPbIFaeuS/c24l0/YMC7V 2eiK6Br9+xwY6cf26fltGANGO7eT4vwoCebwi39dHYzCw7LR1pk9aHT4pqVN45grkr03AXpXfl0XG 3lCJ8R364//1RGOgClSVl99Svk0btzjyeU7LWtv3SqHvhZrUxlhHwjMY2bDvlt5zD40xu39jMyfNX NM3tnHSy4TX212T9tCbIEcLHzI0xvDvgpQW+S3hqW7s/YWiHRwmkjE7FYCHKWsbRX+jvfF2AyDpYc QxpJ5nKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovj7R-00GWP7-Mm; Thu, 17 Nov 2022 17:56:09 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovj7M-00GWLl-KX; Thu, 17 Nov 2022 17:56:08 +0000 Received: from [192.168.1.102] (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BDCA929; Thu, 17 Nov 2022 18:55:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668707758; bh=GdPOoKRqrG2ufeGG/2SH9V/fWXWoBKC38Aw9FoNcfyA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=RFMPyXfbOKxmZOwkcsSeCt9YujWgYk8Et2/ySAHb5YtjlkpdkeZt8KCS07tioUone Pf4qq9KsOr2zL9mk99Wyfftk73nFOpuRKrbD0JTstUCgDzCYRA1SNi1sCG9YXM4F0N 2mhNLN+zB1z7Q5h0G1XbczuO1E+iSrbuV6BNp+lI= Message-ID: Date: Thu, 17 Nov 2022 23:25:48 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/3] Revert "staging: mmal-vchiq: Avoid use of bool in structures" To: Kieran Bingham , Broadcom internal kernel review list , Dan Carpenter , Dave Stevenson , Florian Fainelli , Greg Kroah-Hartman , Hans Verkuil , Mauro Carvalho Chehab , Ray Jui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-staging@lists.linux.dev References: <20221117160015.344528-1-umang.jain@ideasonboard.com> <20221117160015.344528-2-umang.jain@ideasonboard.com> <166870135963.50677.14827688186331561108@Monstersaurus> Content-Language: en-US From: Umang Jain In-Reply-To: <166870135963.50677.14827688186331561108@Monstersaurus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_095604_827482_25674D15 X-CRM114-Status: GOOD ( 20.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS2llcmFuLAoKT24gMTEvMTcvMjIgOTozOSBQTSwgS2llcmFuIEJpbmdoYW0gd3JvdGU6Cj4g UXVvdGluZyBVbWFuZyBKYWluICgyMDIyLTExLTE3IDE2OjAwOjEzKQo+PiBUaGlzIHJldmVydHMg Y29tbWl0IDY0MGU3NzQ2NmU2OWQ5YzI4ZGUyMjdiYzc2ODgxZjU1MDFmNTMyY2EuCj4+Cj4+IElu IGNvbW1pdCA3OTY3NjU2ZmZiZmEgKCJjb2Rpbmctc3R5bGU6IENsYXJpZnkgdGhlIGV4cGVjdGF0 aW9ucyBhcm91bmQKPj4gYm9vbCIpIHRoZSBjaGVjayB0byBkaXMtYWxsb3cgYm9vbCBzdHJ1Y3R1 cmUgbWVtYmVycyB3YXMgcmVtb3ZlZCBmcm9tCj4+IGNoZWNrcGF0Y2gucGwuIEl0IHByb21vdGVz IGJvb2wgc3RydWN0dXJlIG1lbWJlcnMgdG8gc3RvcmUgYm9vbGVhbgo+PiB2YWx1ZXMuIFRoaXMg ZW5oYW5jZXMgY29kZSByZWFkYWJpbGl0eS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogVW1hbmcgSmFp biA8dW1hbmcuamFpbkBpZGVhc29uYm9hcmQuY29tPgo+PiAtLS0KPj4gICAuLi4vc3RhZ2luZy92 YzA0X3NlcnZpY2VzL3ZjaGlxLW1tYWwvbW1hbC12Y2hpcS5jICAgIHwgMTIgKysrKysrLS0tLS0t Cj4+ICAgLi4uL3N0YWdpbmcvdmMwNF9zZXJ2aWNlcy92Y2hpcS1tbWFsL21tYWwtdmNoaXEuaCAg ICB8ICA0ICsrLS0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgOCBkZWxl dGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy92YzA0X3NlcnZpY2Vz L3ZjaGlxLW1tYWwvbW1hbC12Y2hpcS5jIGIvZHJpdmVycy9zdGFnaW5nL3ZjMDRfc2VydmljZXMv dmNoaXEtbW1hbC9tbWFsLXZjaGlxLmMKPj4gaW5kZXggY2I5MjFjOTQ5OTZhLi40YWJiNjE3OGNi OWYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy92YzA0X3NlcnZpY2VzL3ZjaGlxLW1t YWwvbW1hbC12Y2hpcS5jCj4+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy92YzA0X3NlcnZpY2VzL3Zj aGlxLW1tYWwvbW1hbC12Y2hpcS5jCj4+IEBAIC04NjMsOSArODYzLDkgQEAgc3RhdGljIGludCBw b3J0X2luZm9fZ2V0KHN0cnVjdCB2Y2hpcV9tbWFsX2luc3RhbmNlICppbnN0YW5jZSwKPj4gICAg ICAgICAgICAgICAgICBnb3RvIHJlbGVhc2VfbXNnOwo+PiAgIAo+PiAgICAgICAgICBpZiAocm1z Zy0+dS5wb3J0X2luZm9fZ2V0X3JlcGx5LnBvcnQuaXNfZW5hYmxlZCA9PSAwKQo+PiAtICAgICAg ICAgICAgICAgcG9ydC0+ZW5hYmxlZCA9IDA7Cj4+ICsgICAgICAgICAgICAgICBwb3J0LT5lbmFi bGVkID0gZmFsc2U7Cj4+ICAgICAgICAgIGVsc2UKPj4gLSAgICAgICAgICAgICAgIHBvcnQtPmVu YWJsZWQgPSAxOwo+PiArICAgICAgICAgICAgICAgcG9ydC0+ZW5hYmxlZCA9IHRydWU7Cj4+ICAg Cj4+ICAgICAgICAgIC8qIGNvcHkgdGhlIHZhbHVlcyBvdXQgb2YgdGhlIG1lc3NhZ2UgKi8KPj4g ICAgICAgICAgcG9ydC0+aGFuZGxlID0gcm1zZy0+dS5wb3J0X2luZm9fZ2V0X3JlcGx5LnBvcnRf aGFuZGxlOwo+PiBAQCAtMTMwNCw3ICsxMzA0LDcgQEAgc3RhdGljIGludCBwb3J0X2Rpc2FibGUo c3RydWN0IHZjaGlxX21tYWxfaW5zdGFuY2UgKmluc3RhbmNlLAo+PiAgICAgICAgICBpZiAoIXBv cnQtPmVuYWJsZWQpCj4+ICAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4+ICAgCj4+IC0gICAg ICAgcG9ydC0+ZW5hYmxlZCA9IDA7Cj4+ICsgICAgICAgcG9ydC0+ZW5hYmxlZCA9IGZhbHNlOwo+ PiAgIAo+PiAgICAgICAgICByZXQgPSBwb3J0X2FjdGlvbl9wb3J0KGluc3RhbmNlLCBwb3J0LAo+ PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE1NQUxfTVNHX1BPUlRfQUNUSU9OX1RZ UEVfRElTQUJMRSk7Cj4+IEBAIC0xMzU5LDcgKzEzNTksNyBAQCBzdGF0aWMgaW50IHBvcnRfZW5h YmxlKHN0cnVjdCB2Y2hpcV9tbWFsX2luc3RhbmNlICppbnN0YW5jZSwKPj4gICAgICAgICAgaWYg KHJldCkKPj4gICAgICAgICAgICAgICAgICBnb3RvIGRvbmU7Cj4+ICAgCj4+IC0gICAgICAgcG9y dC0+ZW5hYmxlZCA9IDE7Cj4+ICsgICAgICAgcG9ydC0+ZW5hYmxlZCA9IHRydWU7Cj4+ICAgCj4+ ICAgICAgICAgIGlmIChwb3J0LT5idWZmZXJfY2IpIHsKPj4gICAgICAgICAgICAgICAgICAvKiBz ZW5kIGJ1ZmZlciBoZWFkZXJzIHRvIHZpZGVvY29yZSAqLwo+PiBAQCAtMTUzMSw3ICsxNTMxLDcg QEAgaW50IHZjaGlxX21tYWxfcG9ydF9jb25uZWN0X3R1bm5lbChzdHJ1Y3QgdmNoaXFfbW1hbF9p bnN0YW5jZSAqaW5zdGFuY2UsCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICBwcl9lcnIoImZh aWxlZCBkaXNjb25uZWN0aW5nIHNyYyBwb3J0XG4iKTsKPj4gICAgICAgICAgICAgICAgICAgICAg ICAgIGdvdG8gcmVsZWFzZV91bmxvY2s7Cj4+ICAgICAgICAgICAgICAgICAgfQo+PiAtICAgICAg ICAgICAgICAgc3JjLT5jb25uZWN0ZWQtPmVuYWJsZWQgPSAwOwo+PiArICAgICAgICAgICAgICAg c3JjLT5jb25uZWN0ZWQtPmVuYWJsZWQgPSBmYWxzZTsKPj4gICAgICAgICAgICAgICAgICBzcmMt PmNvbm5lY3RlZCA9IE5VTEw7Cj4+ICAgICAgICAgIH0KPj4gICAKPj4gQEAgLTE3OTksNyArMTc5 OSw3IEBAIGludCB2Y2hpcV9tbWFsX2NvbXBvbmVudF9kaXNhYmxlKHN0cnVjdCB2Y2hpcV9tbWFs X2luc3RhbmNlICppbnN0YW5jZSwKPj4gICAKPj4gICAgICAgICAgcmV0ID0gZGlzYWJsZV9jb21w b25lbnQoaW5zdGFuY2UsIGNvbXBvbmVudCk7Cj4+ICAgICAgICAgIGlmIChyZXQgPT0gMCkKPj4g LSAgICAgICAgICAgICAgIGNvbXBvbmVudC0+ZW5hYmxlZCA9IDA7Cj4+ICsgICAgICAgICAgICAg ICBjb21wb25lbnQtPmVuYWJsZWQgPSBmYWxzZTsKPj4gICAKPj4gICAgICAgICAgbXV0ZXhfdW5s b2NrKCZpbnN0YW5jZS0+dmNoaXFfbXV0ZXgpOwo+PiAgIAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9zdGFnaW5nL3ZjMDRfc2VydmljZXMvdmNoaXEtbW1hbC9tbWFsLXZjaGlxLmggYi9kcml2ZXJz L3N0YWdpbmcvdmMwNF9zZXJ2aWNlcy92Y2hpcS1tbWFsL21tYWwtdmNoaXEuaAo+PiBpbmRleCA2 MDA2ZTI5MjMyYjMuLjcwZWRhNmNhYzFjNiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9zdGFnaW5n L3ZjMDRfc2VydmljZXMvdmNoaXEtbW1hbC9tbWFsLXZjaGlxLmgKPj4gKysrIGIvZHJpdmVycy9z dGFnaW5nL3ZjMDRfc2VydmljZXMvdmNoaXEtbW1hbC9tbWFsLXZjaGlxLmgKPj4gQEAgLTQ4LDcg KzQ4LDcgQEAgdHlwZWRlZiB2b2lkICgqdmNoaXFfbW1hbF9idWZmZXJfY2IpKAo+PiAgICAgICAg ICAgICAgICAgIGludCBzdGF0dXMsIHN0cnVjdCBtbWFsX2J1ZmZlciAqYnVmZmVyKTsKPj4gICAK Pj4gICBzdHJ1Y3QgdmNoaXFfbW1hbF9wb3J0IHsKPj4gLSAgICAgICB1MzIgZW5hYmxlZDoxOwo+ PiArICAgICAgIGJvb2wgZW5hYmxlZDoxOwo+IElzIHRoaXMgYSBkaXJlY3QgcmV2ZXJ0IHdpdGgg J2dpdCByZXZlcnQnID8KCgpOby4gSXQgaGFkIGNvbmZsaWN0cyBwbHVzIEkgYWRkZWQgdGhlICc6 MScgaW5pdGlhbGl6YXRpb24gdG8ga2VlcCB0aGUgCmxvZ2ljIHNhbWUgKGluIGNhc2UgJ2VuYWJs ZWQnIGdldHMgdXNlZCBkaXJlY3RseSkuIFNpbWlsYXIgcGF0dGVybiBjb21lIAp1cCB3aXRoOgog wqDCoMKgICgkKSBnaXQgZ3JlcCAnYm9vbCcgLS0gJyouW2hdJyB8IGdyZXAgJ1w6MScKClNvIGl0 IHNob3VsZG4ndCBiZSBhbiBpc3N1ZS4KCj4KPiBJIHdvdWxkIGV4cGVjdCB0aGlzIHRvIGJlCj4g CWJvb2wgZW5hYmxlZDsKCgpUcnVlIGJ1dCBpdCB3b24ndCBmdW5jdGlvbmFsbHkgbm90IGJlIHRo ZSBzYW1lIGluIG1hdHRlciBvZiAKaW5pdGlhbGl6YXRpb24uIFNob3VsZCB0aGUgaW5pdGlhbGl6 YXRpb24gYmUgc3BsaXQgdG8gc2VwYXJhdGUgcGF0Y2g/Cgo+Cj4KPj4gICAgICAgICAgdTMyIGhh bmRsZTsKPj4gICAgICAgICAgdTMyIHR5cGU7IC8qIHBvcnQgdHlwZSwgY2FjaGVkIHRvIHVzZSBv biBwb3J0IGluZm8gc2V0ICovCj4+ICAgICAgICAgIHUzMiBpbmRleDsgLyogcG9ydCBpbmRleCwg Y2FjaGVkIHRvIHVzZSBvbiBwb3J0IGluZm8gc2V0ICovCj4+IEBAIC04Myw3ICs4Myw3IEBAIHN0 cnVjdCB2Y2hpcV9tbWFsX3BvcnQgewo+PiAgIAo+PiAgIHN0cnVjdCB2Y2hpcV9tbWFsX2NvbXBv bmVudCB7Cj4+ICAgICAgICAgIHUzMiBpbl91c2U6MTsKPj4gLSAgICAgICB1MzIgZW5hYmxlZDox Owo+PiArICAgICAgIGJvb2wgZW5hYmxlZDoxOwo+IFNhbWUgaGVyZSBvZiBjb3Vyc2UuCj4KPj4g ICAgICAgICAgdTMyIGhhbmRsZTsgIC8qIFZpZGVvQ29yZSBoYW5kbGUgZm9yIGNvbXBvbmVudCAq Lwo+PiAgICAgICAgICB1MzIgaW5wdXRzOyAgLyogTnVtYmVyIG9mIGlucHV0IHBvcnRzICovCj4+ ICAgICAgICAgIHUzMiBvdXRwdXRzOyAvKiBOdW1iZXIgb2Ygb3V0cHV0IHBvcnRzICovCj4+IC0t IAo+PiAyLjM4LjEKPj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK