From mboxrd@z Thu Jan 1 00:00:00 1970 From: ray.jui@broadcom.com (Ray Jui) Date: Tue, 6 Dec 2016 09:28:33 -0800 Subject: [PATCH 2/5] ARM: BCM5301X: Specify USB controllers in DT In-Reply-To: <20161206171714.22738-2-zajec5@gmail.com> References: <20161206171714.22738-1-zajec5@gmail.com> <20161206171714.22738-2-zajec5@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/6/2016 9:17 AM, Rafa? Mi?ecki wrote: > From: Rafa? Mi?ecki > > There are 3 separated controllers, one per USB /standard/. With PHY > drivers in place they can be simply supported with generic drivers. > > Signed-off-by: Rafa? Mi?ecki > --- > arch/arm/boot/dts/bcm5301x.dtsi | 33 ++++++++++++++++++++++++++++++++- > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index f09a2bb..bfc98d19 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -248,8 +248,26 @@ > > #address-cells = <1>; > #size-cells = <1>; > + ranges; > > - phys = <&usb2_phy>; > + interrupt-parent = <&gic>; > + > + ohci: ohci at 21000 { > + #usb-cells = <0>; > + > + compatible = "generic-ohci"; > + reg = <0x00022000 0x1000>; Your label ohci at 21000 does not match the 'reg' at 0x22000. > + interrupts = ; > + }; > + > + ehci: ehci at 22000 { > + #usb-cells = <0>; > + > + compatible = "generic-ehci"; > + reg = <0x00021000 0x1000>; Looks like you got the label of ohci and ehci reversed? > + interrupts = ; > + phys = <&usb2_phy>; > + }; > }; > > usb3: usb3 at 23000 { > @@ -257,6 +275,19 @@ > > #address-cells = <1>; > #size-cells = <1>; > + ranges; > + > + interrupt-parent = <&gic>; > + > + xhci: xhci at 23000 { > + #usb-cells = <0>; > + > + compatible = "generic-xhci"; > + reg = <0x00023000 0x1000>; > + interrupts = ; > + phys = <&usb3_phy>; > + phy-names = "usb"; > + }; > }; > > spi at 29000 { >