From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D794BC32772 for ; Tue, 23 Aug 2022 13:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RdD6RjX0KQyDI1nhUcN5yWYmK7txOTAdPMH4YzjZxCs=; b=AJILDdGboKUT2N spI/UmXRpKwkIXSXg+anLLgr/+TM+XLQpHctbNxflbh0euRCxi1nuqvCvTrwvxDFQtB0TE5mWJqsL /zO+kpQih8L55489EyB2IKGff1b8fre3RmDKNUIy4rBytYe9AhE8cH1tK4dpG6H66/OG6ELmMA7YU MnRksieNTRW3VRyORBE3fj0qEvAhY/DhyuLbBX5Nqmd0zbzDrn0ipkI2JQt2Ix+XF1MrG/RfPGG2P IIrjEanfMf7Yd+5pZH/2hZaSUS4f8yPDsc4a6BQcEiaqy135oJEkCcQsvVu26jL/fQwUKiVpZ9Of+ Fyv16sMNvyBJuVmburvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQUBj-006P5T-Vi; Tue, 23 Aug 2022 13:43:28 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQUBc-006P0S-0S for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 13:43:23 +0000 Received: by mail-lf1-x12e.google.com with SMTP id z6so19726414lfu.9 for ; Tue, 23 Aug 2022 06:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=h32xyk5qVyHWCWQbdLOYmYDB3SfGv1Ihtw0UlxutFSs=; b=j7WUm0iTG96tPDzGkHP6hVuPCpr84UKH3TJFLWMgVEmePKBlnIJ84/ybGASHI/Mra0 RWoBVYr8ozv7fj7kVw9sz/+jeSaeJmZhqxjpClB6Y4Pc+TyxU6fwxL69LB6ZsgZVRpt4 +67/Na/EvQDPdnAMEKtFkqfBZswAXsGGgVkMUrh3xQhkqgayWbeoGv4EiDoKTDvt+g8m 7hnjfSGwI1hsTBEgbKg1rbjlb+j9eohQ8kbCn3L4Yx3sUt5sRi6aT75MLtTIBbihnk1+ mBcHTr2H03kYnjC9aBF8s/sJoqSZF4kD1p4pgs+Euu2pRgwNJ8d/HJ5bsCMgn8mWlLbR +QmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=h32xyk5qVyHWCWQbdLOYmYDB3SfGv1Ihtw0UlxutFSs=; b=yO86ymR4wW7FTe8T/LIlU7+fWPVVJs3RW2EgHcdievVjWip66gyMs29R+T31DtZWcx q6Im/z8AdWpQTwkOCPom/OUT8hE0Iqh5kkqphIO/d0mCXg/QPeY3s5qGobRXqcExDZ8G T/nrRl9AjIlRCO58WC/Bg8u7lW0OnqvV+PNsBGYWRk6DA7rdCwzaEszvxkOf9jUXKXOR l0Alh+VBgEWaMwKbAcLaWot1f7CP+fPKhOJRr+nx+9BWN8tYRz1rLxECD70gWeuUprrT xhyyySgKZy54BDBUamDR923xdQUWPk6anyVIcfT51cEy4iYzQnoobCJCsLXxmnfDAmpQ tmXw== X-Gm-Message-State: ACgBeo1Uin1q+ujrh/yv8zuYDKLtTDknN6GiVS7NXG8YP/HJjcCtAJul z2y9KDTQQTKcf5fhXEnKpLYfaw== X-Google-Smtp-Source: AA6agR5RZdIPZVcwdu1iI8zwdbElK6Q10jk3CELdg44yE6uN2YcKJda0sTTtvNcx5OKPyyPxtJP3ow== X-Received: by 2002:ac2:5097:0:b0:493:109:f190 with SMTP id f23-20020ac25097000000b004930109f190mr355159lfm.180.1661262195492; Tue, 23 Aug 2022 06:43:15 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id f1-20020a056512360100b00493014c3d7csm107114lfs.309.2022.08.23.06.43.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 06:43:14 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 16:43:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4 Content-Language: en-US To: Dario Binacchi , linux-kernel@vger.kernel.org Cc: Alexandre Torgue , Amarula patchwork , Marc Kleine-Budde , michael@amarulasolutions.com, Dario Binacchi , Krzysztof Kozlowski , Maxime Coquelin , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com References: <20220820082936.686924-1-dario.binacchi@amarulasolutions.com> <20220820082936.686924-4-dario.binacchi@amarulasolutions.com> From: Krzysztof Kozlowski In-Reply-To: <20220820082936.686924-4-dario.binacchi@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_064320_130959_7BD87B33 X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/08/2022 11:29, Dario Binacchi wrote: > Add pin configurations for using CAN controller on stm32f469-disco > board. They are located on the Arduino compatible connector CN5 (CAN1) > and on the extension connector CN12 (CAN2). > > Signed-off-by: Dario Binacchi > Signed-off-by: Dario Binacchi Do not ignore review. This is not correct. You are mixing copyright with SoC... > > + can2_pins_b: can2-1 { > + pins1 { > + pinmux = ; /* CAN2_TX */ > + }; > + pins2 { > + pinmux = ; /* CAN2_RX */ > + bias-pull-up; > + }; > + }; > + Don't ignore review. That's second one, so that's a no.. :( Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel