From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Trent Piepho <tpiepho@impinj.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH 2/2] nvmem: imx-ocotp: Support multiple word writes
Date: Tue, 6 Aug 2019 10:57:24 +0100 [thread overview]
Message-ID: <c74bed07-9a67-8ff8-2a6d-0fe98f5a6193@linaro.org> (raw)
In-Reply-To: <20190709183016.4789-2-tpiepho@impinj.com>
On 09/07/2019 19:30, Trent Piepho wrote:
> All the other nvmem drivers here support multiple words being read, and
> for writable memory, written in one call. This driver appears to be the
> only one with a single word write restriction. It makes the driver fail
> with generic userspace nvmem tools.
>
> It's easy to support multiple words to write so do that.
>
> The nvmem core verifies the write length against the word size, so that
> can be removed from the driver. But offset still needs to be checked.
>
> Also simplify the bank write code for imx7 to avoid a lot of
> duplication.
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Any Acks or Tested-by before I can push this would be really appreciated.
--srini
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-06 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 18:30 [PATCH 1/2] nvmem: imx-ocotp: Set type to OTP Trent Piepho
2019-07-09 18:30 ` [PATCH 2/2] nvmem: imx-ocotp: Support multiple word writes Trent Piepho
2019-08-06 9:57 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c74bed07-9a67-8ff8-2a6d-0fe98f5a6193@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).