From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1083C433FF for ; Tue, 6 Aug 2019 09:57:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B45BD20651 for ; Tue, 6 Aug 2019 09:57:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="apa9tvht"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dUYdusqu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B45BD20651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OMytlGoqWG1D2QEIq750qYyi7hyGEP7iKYCCnenNuVw=; b=apa9tvhtB91ZX98lShSMtkFfc 6ueqUYtnn+z4cjyQsGMA1NVfsZMP3prKPrlxO2J7pFDgCw2QfkIUiZCj9lD5k3rJ0EDAw4bLO1I2c nBevb5ufRinr8Re68VZupNzzMA0ObEg9HQVIW4Vf3RUfzSR5DvW9aHGA/yNvTTSKTTlD4dYnMF826 no+a1PF7hA+8AH38wOFAXpJfovoKoxPVFaauMfLtSawYP0jEsd297yPKvHfTiG8rRn7omk11SYbU3 OgKXIoBmo1qsisCVMTP2DbRfjfwPmrWQWgh0HKUuxnv1naFJhavVD8eoOk7wc7glt/UbYtvroqP6u N/ggBOvRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huwDn-0000qM-4O; Tue, 06 Aug 2019 09:57:35 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huwDi-0000pL-4o for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2019 09:57:32 +0000 Received: by mail-wm1-x344.google.com with SMTP id x15so77563799wmj.3 for ; Tue, 06 Aug 2019 02:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/Maji2RwwwtxnwYgjI3ukUF6tl3xJMB8QIi+/hRkUJQ=; b=dUYdusquMTgi5sgAluvwU2oAnGLw7yeqBk3Zk9kvngMNEoMzLJpIc68D8q1pnBYzQA 83bOfrGeXhqCp32Z9bFRfDjLqlutiKwYP26XXcol9haByP/hIpD7F7/tVenwSgvacIc1 7HHglIcSmnf6h3aiU2ROKUa5pRNzWVCREgVKwh1QVC6eKt1yE8ZdPagdrqez4WFva5ZE jK2wrNbgAZAkIQoVqlBqzNG4oUCrWJAnH2eYs6C9NzczpyPKMieySGg+QXA3PbAulN+v b9tRw+8Z4NTGdt/ZC70NTnxsFdB8qFFrfU1S7h1GBmkTCTd3aSTDSAYkFA/3jkOFgHAz W6Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/Maji2RwwwtxnwYgjI3ukUF6tl3xJMB8QIi+/hRkUJQ=; b=ZxSuAs8IDuPAObUaIxA7ZXaMe02WRWepFuLrt932lTdchjcIBxqKANBdLmd6vzkR1e v+AJPOsJpDE5ro6xOyrLl6CrZJQ0+SouXItQEI2AF0uyNjm9a7Q71JMWsdivODNUVrMn 317jPbB+mfTgferY/P0GsHcOVGOlrqSo54WDH7z9tfOlVNx61myH3Nmy35u951lZ+wHj +QkF3OUImaiEULdeowRXbnBucaJ0NUPwP3aHffvSNhnM4/MKfemVhscD2t4m3mVz5ATB AMhPrILsN1XT1dL+bTVtKp2mEmMqDMpj6tW+7CE+vtg/f7nmDHIublE+V/kgdAEg42qh pt8A== X-Gm-Message-State: APjAAAXpdl7Mf0RyYR0q3x9z4elVZ7w11PqwlaeVN2XFkpkIPIiBK6bX DZZ9Et0i769zACspuzbH0dmiJImUD+s= X-Google-Smtp-Source: APXvYqybHKczGO4ZhHJ8e7xW0i7iRDztl518SonFt/A7ij3dDpkl+aNGTA0/Cpvgp1ssSTDtuzAJfA== X-Received: by 2002:a1c:a481:: with SMTP id n123mr3542235wme.123.1565085446511; Tue, 06 Aug 2019 02:57:26 -0700 (PDT) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id q18sm107898732wrw.36.2019.08.06.02.57.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Aug 2019 02:57:25 -0700 (PDT) Subject: Re: [PATCH 2/2] nvmem: imx-ocotp: Support multiple word writes To: Trent Piepho , "linux-arm-kernel@lists.infradead.org" References: <20190709183016.4789-1-tpiepho@impinj.com> <20190709183016.4789-2-tpiepho@impinj.com> From: Srinivas Kandagatla Message-ID: Date: Tue, 6 Aug 2019 10:57:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190709183016.4789-2-tpiepho@impinj.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190806_025730_441545_3B643471 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Sascha Hauer , Shawn Guo , NXP Linux Team Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/07/2019 19:30, Trent Piepho wrote: > All the other nvmem drivers here support multiple words being read, and > for writable memory, written in one call. This driver appears to be the > only one with a single word write restriction. It makes the driver fail > with generic userspace nvmem tools. > > It's easy to support multiple words to write so do that. > > The nvmem core verifies the write length against the word size, so that > can be removed from the driver. But offset still needs to be checked. > > Also simplify the bank write code for imx7 to avoid a lot of > duplication. > > Cc: Srinivas Kandagatla > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Fabio Estevam > Signed-off-by: Trent Piepho Any Acks or Tested-by before I can push this would be really appreciated. --srini _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel