From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6031CCD1284 for ; Sun, 31 Mar 2024 23:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dz/4noxo4cYN+Uk/2HJAz5JM2SMa8bLWKN0PawxVD8Y=; b=l5yacdT3+x2dWo Re1Rno79H0Ezm0rkhS7ti7XMA5TSer58vwRaIIrDELcbxHVCx6Tv41llzQhiozvoJvi7GtuVv0tkl iAUIgYM0A2/Qz/CuuLyQiiKdkI5DT+eWho5h2f1CfxkMvOFkDQrKenCIrH9GvVNZ1jtOs9iGIuFW8 ExcvGwP/ZVTzRV2GlWk5+LDrnU4XLdX05FjWf/snlLFC2DCeVzvt2rGkvrV/sqThYPmdHj+0k9ymc Iill7swZnzEDV+l4rtauBqeR71Ee9N4ls75fpXzvHYm46Qjhqp/9CGx7TH2feY/CZNyK7gj1tUtTM ivmZLYN4lp1zVxld/CGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr4Fz-00000006S8P-1gtY; Sun, 31 Mar 2024 23:06:31 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr4Fw-00000006S6e-2iAA; Sun, 31 Mar 2024 23:06:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 14866CE0CE3; Sun, 31 Mar 2024 23:06:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC358C433F1; Sun, 31 Mar 2024 23:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711926381; bh=14qIqX8MDo3yXNFpqBzy/00s9TGjAWt6G7ERHC7x30A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gw6sdMmccfg6fv2rsBdDfRpSG7EMGTTmkv9GV0mfGfq78EG0Qa3zFW+rJUZzSqm/1 9rw6aVYZcX3zsaWf+T8zHt+KIJdjHHYF+3GyTxnvmPCDqh8zutCL1T5XgVQX8sf8Ub XCLjmRv0WFLzmR5UfSYpKO6zco0y/AHJCjO71mC+f9PpTO5gqM/B2OmeCNYooRVxo9 2mKSG0zoKqfErDvmrGPb305oT3IpOq+xTMdWPERY6pzWuFMWaE5sXg9Bo7xIRiphe7 ddcRd9uXmkpF6sUoIMIgiNFlwRzX4TbqA6IWQNgGTC8Bl/Jgmi+8lfUjtYJAAmr2Et fItqbas/oQN0g== Message-ID: Date: Mon, 1 Apr 2024 08:06:17 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 17/18] dt-bindings: pci: rockchip,rk3399-pcie-ep: Add ep-gpios property To: Krzysztof Kozlowski , Manivannan Sadhasivam , Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240330041928.1555578-18-dlemoal@kernel.org> From: Damien Le Moal Content-Language: en-US Organization: Western Digital Research In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240331_160628_868421_19398C8C X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/30/24 18:16, Krzysztof Kozlowski wrote: > On 30/03/2024 05:19, Damien Le Moal wrote: >> From: Wilfred Mallawa >> >> Describe the `ep-gpios` property which is used to map the PERST# input >> signal for endpoint mode. >> >> Signed-off-by: Wilfred Mallawa >> Signed-off-by: Damien Le Moal >> --- >> .../devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >> index 6b62f6f58efe..9331d44d6963 100644 >> --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >> +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >> @@ -30,6 +30,9 @@ properties: >> maximum: 32 >> default: 32 >> >> + ep-gpios: >> + description: Input GPIO configured for the PERST# signal. > > Missing maxItems. But more important: why existing property perst-gpios, > which you already have there in common schema, is not correct for this case? I am confused... Where do you find perst-gpios defined for the rk3399 ? Under Documentation/devicetree/bindings/pci/, the only schema I see using perst-gpios property are for the qcom (Qualcomm) controllers. The RC bindings for the rockchip rk3399 PCIe controller (pci/rockchip,rk3399-pcie.yaml) already define the ep-gpios property. So if anything, this patch should be probably be modified to move this property to the common schema in pci/rockchip,rk3399-pcie-common.yaml. No ? > > Best regards, > Krzysztof > -- Damien Le Moal Western Digital Research _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel