From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2457CCD193 for ; Wed, 18 Sep 2024 09:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CcXS7pKBmWCVMi0FiYuE7jrw1z1w0kyY8yOpJgkZTWg=; b=EPIvikw6Oj5IGI6CcBvejA8V9F a7J/7b/Rr6pdxHUJSjRyvNaNuRIPLPPUdGCF6j9JeaIZ/PCiL1FUU8xJ3L1dW8qmNzXGBkPF8Kl71 sDjt8pDvGDCgKFyHv88/rxJEIs/+Gzz8yQwoXrmIkv+KhPSlVS6XVc362m3t5yytUJdTjhmZmWr9d xbq7tptdSNPXSP+QJE4x5ZFFhZvONJWF/kYSbBKyfIfRymcNnObwxlXz22XMYX1T1GFOKvMhSrdhE ISwuXTZVdl/fxDInRjhqu6wy2z7mqkgjVQlzT1qxW4g+winu54J6iPqyvT3vW7nC6k/x/q4BbBBAZ u7wMRCdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqqzQ-00000007vMc-0GTy; Wed, 18 Sep 2024 09:28:48 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqqyI-00000007vH2-2yO6 for linux-arm-kernel@lists.infradead.org; Wed, 18 Sep 2024 09:27:40 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1726651654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CcXS7pKBmWCVMi0FiYuE7jrw1z1w0kyY8yOpJgkZTWg=; b=hFeOihVPMGvcGl4yvu0jpqU+l3bTHwD0UqT3ybAR184ENHUaLim/C2bL85ZB/mLxyHwjCp hBURPWpy5BgCPnu1sdzYGqxe2s3wBB3UkBWKKgOouBeAi2TqBjkqy+ek7Dd3sVNlRjO+nq 0eTSlaeZgcH7hUQfpFbMV/IItqmdcq+K2mwUXS5Vtvlw6PNLtPQXxwz0T6Q7w1FRN2yTIu 133JxZbTm+8P1KTH8/qcl8hPZYC/vv6goOJ6Vt1/Jgaoht/qRb9DyfJvzazkZGDyZnD4qN 9ilXSe+sf92BsH+goOkgDaebiqL/xoqbqDvnufuyRnB4y4X9KSRgwNNakSXeEQ== Date: Wed, 18 Sep 2024 11:27:31 +0200 From: Dragan Simic To: Andrey Skvortsov Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Ond=C5=99ej_Jirman?= Subject: Re: [PATCH] arm64: dts: sun50i-a64-pinephone: Add mount matrix for accelerometer In-Reply-To: References: <20240916204521.2033218-1-andrej.skvortzov@gmail.com> <6e5d0e9978bff30559c17f30d1495b59@manjaro.org> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240918_022739_408177_686179AD X-CRM114-Status: GOOD ( 25.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Andrey, On 2024-09-17 19:56, Andrey Skvortsov wrote: > On 24-09-16 23:08, Dragan Simic wrote: >> On 2024-09-16 22:45, Andrey Skvortsov wrote: >> > From: OndÅ™ej Jirman >> > >> > accelerometer is mounted the way x and z-axis are invereted, x and y >> > axis have to be spawed to match device orientation. >> > The mount matrix is based on PCB drawing and was tested on the device. >> >> This commit summary should be copyedited for grammar and style. If >> you want, I can provide a copyedited version? > > It would be helpful to avoid further grammar/style problems in the > commit message. Thanks in advance. Alright, here's how it could be worded... First, the patch summary should use the common prefix, together with a bit of rewording, so the patch summary should read like this: arm64: dts: allwinner: pinephone: Add mount matrix to accelerometer The patch description should be reworded like this, reflown into proper line lengths, of course: The way InvenSense MPU-6050 accelerometer is mounted on the user-facing side of the Pine64 PinePhone mainboard requires the accelerometer's x- and y-axis to be swapped, and the direction of the accelerometer's y-axis to be inverted. Rectify this by adding a mount-matrix to the accelerometer definition in the PinePhone dtsi file. [andrey: Picked the patch description provided by dsimic] Fixes: 91f480d40942 ("arm64: dts: allwinner: Add initial support for Pine64 PinePhone") Cc: stable@vger.kernel.org Please note the Fixes tag, which will submit this bugfix patch for inclusion into the long-term/stable kernels. Also note that the patch description corrects the way inversion of the axis direction is described, which should also be corrected in the patch itself, as described further below. After going through the InvenSense MPU-6050 datasheet, [1] the MPU-6050 evaluation board user guide, the PinePhone schematic, the PinePhone mainboard component placement, [2] and the kernel bindings documentation for mount-matrix, [3] I can conslude that only the direction of the accelerometer's y-axis is inverted, while the direction of the z-axis remain unchanged, according to the right-hand rule. >> > Signed-off-by: Ondrej Jirman >> > Signed-off-by: Andrey Skvortsov >> > --- >> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> > b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> > index bc6af17e9267a..1da7506c38cd0 100644 >> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> > @@ -229,6 +229,9 @@ accelerometer@68 { >> > interrupts = <7 5 IRQ_TYPE_EDGE_RISING>; /* PH5 */ >> > vdd-supply = <®_dldo1>; >> > vddio-supply = <®_dldo1>; >> > + mount-matrix = "0", "1", "0", >> > + "-1", "0", "0", >> > + "0", "0", "-1"; >> > }; >> > }; With the above-described analysis in mind, the mount-matrix should be defined like this instead: mount-matrix = "0", "1", "0", "-1", "0", "0", "0", "0", "1"; Please also note the line indentation that was changed a bit. [1] https://rimgo.reallyaweso.me/vrBXQPq.png [2] https://rimgo.reallyaweso.me/uTmT1pr.png [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/iio/mount-matrix.txt