From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3452C52D6D for ; Sat, 3 Aug 2024 08:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sCg1QVf69WV5BKyj0Bz6F+tGawADHTPiS5wm9bbqpj4=; b=QH6GDgrpfJinCy7/Dv0ujl6ROX 5dT+tDMIz6+/hxcyHdJZ/h07W2l8WSMqDyRdV6XRxWGh/9cAECdu6Jim/GccG/TBOTy42Ihts2Xrd SNsLvEjmeoOFxsJbDBkVqYfhiaSQytfQZuioEJEiQdI20xWEviho+JNQINJ2f2HvCdsrLVyP4dlPo J/sDZBhKQLkPDVONy18yfEtfXu7lnYn2QCxC5rjUaXadUYD2A/166K5zJaYULjhBfHavd4a8VxKWi lddPsYK+8DwsbSFxO/k9gGiPxVWgQ72MCPOVJsVZ+bNkVpTOGMsD+CRm9/WcmNfTAZ/VSX4a2tsB2 F+Nnjlag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa9tV-0000000B2FB-1lF3; Sat, 03 Aug 2024 08:13:41 +0000 Received: from fout1-smtp.messagingengine.com ([103.168.172.144]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa9t0-0000000B29h-0JrF; Sat, 03 Aug 2024 08:13:11 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id BF0F0138FD79; Sat, 3 Aug 2024 04:13:08 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute4.internal (MEProxy); Sat, 03 Aug 2024 04:13:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1722672788; x=1722759188; bh=sCg1QVf69WV5BKyj0Bz6F+tGawADHTPiS5wm9bbqpj4=; b= foAR1euZsEklJ2VYaRRfjKL1MD/JLYGXZFenHUzaZz8RDoIwcXQ1ePV3DpiLXwR0 PdLlWsfw6ryEwEWXdo68vNf6P1kI5fvApTIX8c0iDAf3dRNfH4wE48Bpcj+RYvlz MFzu/UGdxKNXbZR0Gv8PJZTMeNVFPD8reWsOloMByXxA8gEK4PRhOoRw/iS36dSY p2ZUFKuQfI8I6MoiSPPFqgRtMUTBsKhLzJ8ccqnqFfTVm/oNrsbV2e5kFbx9tOoX uswafvgCd/v19CQ99PWQvEgkpWNRnamGK0blOHWNeF2tfRVahnAjLqLY1oezpYcS XzxbcQxUsiLiMDzq998eag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722672788; x= 1722759188; bh=sCg1QVf69WV5BKyj0Bz6F+tGawADHTPiS5wm9bbqpj4=; b=N mz9zZ1va3nyzLqX7qEb/4LHiKSFpgbb/5/isTz3YA9uqm3u0rkDQw/3qKl7xFzGZ fQBCNH0O1YAgSPK1bnWgas2r0ZhjbnR9m6lai0MEiIakAN6XPO2gX6zl1CMIdwvE 41LSbe1pPPdvY8tM9vSAZyZw2SEOTohL/1tNqwJ0eX8UZ4MRMGsslVUpzqeQ1Fa+ M8IJy14I+Zn2QeSfFlDisPhWlyinANPzlIb8qGr+en0nC8uycjWlx+pr+0g4Cgf3 uPFUxbcUTpZjHhC+RdCqXhug6gZgBBfO15o3ri6qlMUfTUF+py5ZNMIIFDEQD0YL AY1n63pAK1sChmoqpcKKQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrkedugddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefggfevudegudevledvkefh vdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7E37CB6008D; Sat, 3 Aug 2024 04:13:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Sat, 03 Aug 2024 10:12:47 +0200 From: "Arnd Bergmann" To: "Jakub Jelinek" , "Rudi Heitbaum" Cc: "Arnd Bergmann" , "Catalin Marinas" , "Will Deacon" , "Huacai Chen" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Andreas Schwab" , "Florian Weimer" , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, "WANG Xuerui" , "Masami Hiramatsu" , linux-kernel@vger.kernel.org, loongarch@lists.linux.dev Message-Id: In-Reply-To: References: <20240801123305.2392874-1-arnd@kernel.org> Subject: Re: [PATCH] syscalls: fix syscall macros for newfstat/newfstatat Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240803_011310_448059_FC2EFF88 X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 3, 2024, at 10:00, Jakub Jelinek wrote: > On Sat, Aug 03, 2024 at 05:14:41AM +0000, Rudi Heitbaum wrote: >> With this patch to kernel 6.11-rc1 the error whilst compiling gcc-14.2 for >> aarch64 with libsanitizer has changed from '__NR_newfstatat' to >> '__NR_fstat', so some change, but still fail8ng. >> >> sanitizer_syscall_linux_aarch64.inc:13:23: error: '__NR_newfstatat' was not declared in this scope >> 13 | #define SYSCALL(name) __NR_ ## name >> | ^~~~~ >> >> sanitizer_syscall_linux_aarch64.inc:13:23: error: '__NR_fstat' was not declared in this scope >> 13 | #define SYSCALL(name) __NR_ ## name >> | ^~~~~ > Thanks for the report! Yes, I think I messed it up again by changing both fstatat and fstat. Our internal names in the kernel are a bit inconsistent and I failed to realize that only newfstatat uses the "new" name in the user-facing macro. > Probably it would be useful to check > echo '#include ' | gcc -E -dD -xc - | grep '#define __NR_' | sort > for all arches between 6.10 and the latest git, diff them and resolve any > unintended differences. Right, I should have done that before the original series really: I spent a lot of time validating the kernel's internal changes for consistency (which found a dozen bugs that were unrelated to my series) but missed the unintended changes to the external header contents. I'll do that now and send another fixup. Arnd