[PATCH] KVM: arm64: Remove unneeded semicolon

[PATCH] KVM: arm64: Remove unneeded semicolon

[cgel.zte]

From: Changcheng Deng <deng.changcheng@zte.com.cn>

Fix the following coccicheck review:
./arch/arm64/kvm/psci.c: 379: 3-4: Unneeded semicolon

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
 arch/arm64/kvm/psci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c
index 0a00ef250725..3b16dae4ab3d 100644
--- a/arch/arm64/kvm/psci.c
+++ b/arch/arm64/kvm/psci.c
@@ -376,7 +376,7 @@ static int kvm_psci_1_x_call(struct kvm_vcpu *vcpu, u32 minor)
 				ret = 0;
 			}
 			break;
-		};
+		}
 		fallthrough;
 	default:
 		return kvm_psci_0_2_call(vcpu);
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] KVM: arm64: Remove unneeded semicolon

[Marc Zyngier]

On 2022-02-23 09:27, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
> 
> Fix the following coccicheck review:
> ./arch/arm64/kvm/psci.c: 379: 3-4: Unneeded semicolon
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
>  arch/arm64/kvm/psci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c
> index 0a00ef250725..3b16dae4ab3d 100644
> --- a/arch/arm64/kvm/psci.c
> +++ b/arch/arm64/kvm/psci.c
> @@ -376,7 +376,7 @@ static int kvm_psci_1_x_call(struct kvm_vcpu
> *vcpu, u32 minor)
>  				ret = 0;
>  			}
>  			break;
> -		};
> +		}
>  		fallthrough;
>  	default:
>  		return kvm_psci_0_2_call(vcpu);

Thanks for that. You may want to check why your script didn't pick
this particular instance of the same defect:

diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c
index b43adf7dc29f..0d48d1e7291d 100644
--- a/arch/arm64/kvm/psci.c
+++ b/arch/arm64/kvm/psci.c
@@ -438,7 +438,7 @@ int kvm_psci_call(struct kvm_vcpu *vcpu)
  		return kvm_psci_0_1_call(vcpu);
  	default:
  		return -EINVAL;
-	};
+	}
  }

  int kvm_arm_get_fw_num_regs(struct kvm_vcpu *vcpu)

I'll squash it into you patch and push it into -next.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel