From: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
To: Lee Jones <lee@kernel.org>
Cc: <ukleinek@kernel.org>, <alexandre.torgue@foss.st.com>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <jic23@kernel.org>,
<daniel.lezcano@linaro.org>, <tglx@linutronix.de>,
<robh@kernel.org>, <catalin.marinas@arm.com>, <will@kernel.org>,
<devicetree@vger.kernel.org>, <wbg@kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<linux-pwm@vger.kernel.org>, <olivier.moysan@foss.st.com>
Subject: Re: [PATCH v4 2/8] mfd: stm32-lptimer: add support for stm32mp25
Date: Fri, 25 Apr 2025 14:50:06 +0200 [thread overview]
Message-ID: <c78c1c19-cf11-4146-acda-fd435add6808@foss.st.com> (raw)
In-Reply-To: <20250424130112.GD8734@google.com>
On 4/24/25 15:01, Lee Jones wrote:
> On Fri, 04 Apr 2025, Lee Jones wrote:
>
>> On Fri, 14 Mar 2025, Fabrice Gasnier wrote:
>>
>>> Add support for STM32MP25 SoC.
>>> A new hardware configuration register (HWCFGR2) has been added, to gather
>>> number of capture/compare channels, autonomous mode and input capture
>>> capability. The full feature set is implemented in LPTIM1/2/3/4. LPTIM5
>>> supports a smaller set of features. This can now be read from HWCFGR
>>> registers.
>>>
>>> Add new registers to the stm32-lptimer.h: CCMR1, CCR2, HWCFGR1/2 and VERR.
>>> Update the stm32_lptimer data struct so signal the number of
>>> capture/compare channels to the child devices.
>>> Also Remove some unused bit masks (CMPOK_ARROK / CMPOKCF_ARROKCF).
>>>
>>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
>>> ---
>>> Changes in V4:
>>> - Add DIEROK, ARROK status flags, and their clear flags.
>>> Changes in V2:
>>> - rely on fallback compatible as no specific .data is associated to the
>>> driver. Compatibility is added by reading hardware configuration
>>> registers.
>>> - read version register, to be used by clockevent child driver
>>> - rename register/bits definitions
>>> ---
>>> drivers/mfd/stm32-lptimer.c | 33 ++++++++++++++++++++++++++-
>>> include/linux/mfd/stm32-lptimer.h | 37 ++++++++++++++++++++++++++++---
>>
>> At least the Clocksource driver depends on this.
>>
>> I need Acks from the other Maintainers before I can merge this.
>
> Suggest you resubmit the set as a [RESEND] to re-gain traction.
>
Hi Lee,
Thanks for suggesting.
I recently found I needed to add a small delay in clocksource driver. So
I just have sent a V5.
Best Regards,
Fabrice
next prev parent reply other threads:[~2025-04-25 14:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 17:14 [PATCH v4 0/8] Add STM32MP25 LPTIM support: MFD, PWM, IIO, counter, clocksource Fabrice Gasnier
2025-03-14 17:14 ` [PATCH v4 1/8] dt-bindings: mfd: stm32-lptimer: add support for stm32mp25 Fabrice Gasnier
2025-03-14 17:14 ` [PATCH v4 2/8] " Fabrice Gasnier
2025-04-04 14:40 ` Lee Jones
2025-04-24 13:01 ` Lee Jones
2025-04-25 12:50 ` Fabrice Gasnier [this message]
2025-03-14 17:14 ` [PATCH v4 3/8] iio: trigger: " Fabrice Gasnier
2025-03-15 12:56 ` Jonathan Cameron
2025-03-27 16:36 ` Fabrice Gasnier
2025-03-31 10:04 ` Jonathan Cameron
2025-03-14 17:14 ` [PATCH v4 4/8] clocksource: " Fabrice Gasnier
2025-04-08 14:48 ` Fabrice Gasnier
2025-03-14 17:14 ` [PATCH v4 5/8] pwm: stm32-lp: " Fabrice Gasnier
2025-04-04 15:07 ` Uwe Kleine-König
2025-03-14 17:14 ` [PATCH v4 6/8] arm64: defconfig: enable STM32 LP timer clockevent driver Fabrice Gasnier
2025-03-14 17:14 ` [PATCH v4 7/8] arm64: dts: st: add low-power timer nodes on stm32mp251 Fabrice Gasnier
2025-03-14 17:14 ` [PATCH v4 8/8] arm64: dts: st: use lptimer3 as tick broadcast source on stm32mp257f-ev1 Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c78c1c19-cf11-4146-acda-fd435add6808@foss.st.com \
--to=fabrice.gasnier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=ukleinek@kernel.org \
--cc=wbg@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).