From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 829FDC433EF for ; Thu, 23 Dec 2021 02:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=THfnvBUZC8H5GrOmjPM6WrUVitAq+9ZZQtScQEDvUz4=; b=m2AwP5dIDGusMNkVnOsytAAEKE zSziW+T6L9usEQQHWddcJ9pFBwOksFFRQQVmgGxNi5aaUaE5BfPnzsVzsQlfG5YuUVNMlQcfipL0V 1T0x9gGk9gvaAafqTgU+4ZuHk86YS7XMk5W3UaSm6xqY11wA6r2weOGn4nku8t7dIp4cyxQfuW/Eb w8Dl7c5K8Ak/FXV0eD8R02WIE0Iuk8P6Z9nrPhYW1P0JpQEBck9NRaNdjdJXUZv/76Fqr7cunmfy4 wPxEXMvxjrpATkj/lbyMeNN+fOamrV6ua3l3StsuubiUMKiylGrPBwAmsGpGoMNykIx6M05rAnaPg YPKmmGmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0DYB-00BkK2-Ad; Thu, 23 Dec 2021 02:09:47 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0DY5-00BkIV-U6; Thu, 23 Dec 2021 02:09:43 +0000 Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4JKD844RkLz1DK6h; Thu, 23 Dec 2021 10:06:28 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 23 Dec 2021 10:09:38 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 23 Dec 2021 10:09:37 +0800 Subject: Re: [PATCH v18 01/17] x86/setup: Move CRASH_ALIGN and CRASH_ADDR_{LOW|HIGH}_MAX to asm/kexec.h To: Borislav Petkov CC: Thomas Gleixner , Ingo Molnar , , "H . Peter Anvin" , , Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , , Catalin Marinas , Will Deacon , , Rob Herring , Frank Rowand , , "Jonathan Corbet" , , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , "John Donnelly" References: <20211222130820.1754-1-thunder.leizhen@huawei.com> <20211222130820.1754-2-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Thu, 23 Dec 2021 10:09:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_180942_181852_3F74270F X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/12/23 4:43, Borislav Petkov wrote: > On Wed, Dec 22, 2021 at 09:08:04PM +0800, Zhen Lei wrote: >> From: Chen Zhou >> >> We want to make function reserve_crashkernel[_low](), which is implemented > ^^ > > Please use passive voice in your commit message: no "we" or "I", etc, > and describe your changes in imperative mood. My bad language habits. I've made this mistake several times. > > Also, pls read section "2) Describe your changes" in > Documentation/process/submitting-patches.rst for more details. > > Bottom line is: personal pronouns are ambiguous in text, especially with > so many parties/companies/etc developing the kernel so let's avoid them > please. OK, I'll check the description of the other patches. > >> by X86, available to other architectures. It references macro CRASH_ALIGN > > "x86" OK > >> and will be moved to public crash_core.c. But the defined values of >> CRASH_ALIGN may be different in different architectures. So moving the >> definition of CRASH_ALIGN to asm/kexec.h is a good choice. >> >> The reason for moving CRASH_ADDR_{LOW|HIGH}_MAX is the same as above. > > This commit message needs to say something along the lines of: > > "Move CRASH_ALIGN and ... to the arch-specific header in preparation > of making reserve_crashkernel[_low]() generic, used by other > architectures." OK, I will use this one, thanks. By the way, patch 0004-0006 were written based on your suggestion. Can you take a moment to review it? I think I forgot to add "Suggested-by". > > or so. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel