From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77230C4332F for ; Thu, 22 Dec 2022 14:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VOlqNpib3eStkHlWKftmrvCGq70d4rKDINH3Q2c6iPI=; b=wnWr3MUdzQGcvH efmyFX0SSJc5ZxyZaW9JiE0YI7mvFWP5t+urJ2SJqAq1qshYZBFXkW2qQBNb1ZkKlhx6ngCU6UA7h 0zOwpxIJVa+yv99gO6Kad77yY5CkqZgou6A6fk8xOjt23DsVgsDd+YCNPZRmT91WN6JTt76COYOCo xsG1KNYM7E/uMJzAilSbnnrvHwzNQ9LgekNSW++h1E1FG8Ys+A1XZP+a8R6Odt3lBR5AJnFgmTvSS VwUjdi0mGdG1JSaptAdkgVT/an+CM0Kctqv4mlstaKRhjQcNUF5GACYTQJfQ4bve1nhpOYky4Dfgj gKXxzKAUsUm29Rwb+5Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8MQA-00Csun-PW; Thu, 22 Dec 2022 14:19:43 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8M8B-00CiB8-T7 for linux-arm-kernel@lists.infradead.org; Thu, 22 Dec 2022 14:01:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 264B3B81DAA; Thu, 22 Dec 2022 14:01:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AB8FC433F0; Thu, 22 Dec 2022 14:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671717665; bh=9W4DMIktV9wOqRKH4YYw4WT/SWQbRbPoXOqm82vucUE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lbKbbvOc7Dt/TGiJmMSbe8HWrzqafnohDwNLbSQvcX5O7YpTUNciD+qt09v73OKuW IENYZma6VGJwJws24sPpOubRvbWMifmhnaoklBN+HpeAJ1OF4Y4AGVzbbFhr7Rjt+Y uniwF5BYyAiG7SMOQ15flJzSt7wVlN5cLthFFSw4qzMRbP0+BrzhkFJ8ypXIHLsALi EXo436Nqx8DquvzbD6iiTz74HQegYehQsKIcCNehHBde3AskcUMUGgytMVpd2hVDez KcSCDjqjwadrcljlUac/HZcpAZj9B24VYFveW++EFuWdhYPciqOEWPsviyZ7JH12+k +l0AK36+PNejw== Message-ID: Date: Thu, 22 Dec 2022 15:01:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 1/2] arm: dts: arm: add arm corstone500 device tree Content-Language: en-US To: Emekcan Aras , Rob Herring , Krzysztof Kozlowski , Liviu Dudau , Lorenzo Pieralisi , Sudeep Holla , Miguel Silva Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221222123244.147238-1-emekcan.aras@arm.com> <20221222123244.147238-2-emekcan.aras@arm.com> From: Krzysztof Kozlowski In-Reply-To: <20221222123244.147238-2-emekcan.aras@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221222_060108_418579_C346A986 X-CRM114-Status: GOOD ( 23.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/12/2022 13:32, Emekcan Aras wrote: > Corstone500[0] is a platform from arm, which includes Cortex-A cores and > ideal starting point for feature rich System on Chip (SoC) designs > based on the Cortex-A5 core. Use subject prefixes matching the subsystem (git log --oneline -- ...). You got this comment already and you did not follow it. > > These device trees contains the necessary bits to support the > Corstone 500 FVP (Fixed Virtual Platform) and the > FPGA MPS3 board. > > 0: https://developer.arm.com/documentation/102262/0000 > > Signed-off-by: Emekcan Aras > --- > arch/arm/boot/dts/Makefile | 3 +- > arch/arm/boot/dts/corstone500.dts | 182 ++++++++++++++++++++++++++++++ > 2 files changed, 184 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/corstone500.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 6aa7dc4db2fc..4dc4df0707dc 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1465,7 +1465,8 @@ dtb-$(CONFIG_ARCH_VEXPRESS) += \ > vexpress-v2p-ca5s.dtb \ > vexpress-v2p-ca9.dtb \ > vexpress-v2p-ca15-tc1.dtb \ > - vexpress-v2p-ca15_a7.dtb > + vexpress-v2p-ca15_a7.dtb \ > + corstone500.dtb Wrong order. v is not before c. > dtb-$(CONFIG_ARCH_VIRT) += \ > xenvm-4.2.dtb > dtb-$(CONFIG_ARCH_VT8500) += \ > diff --git a/arch/arm/boot/dts/corstone500.dts b/arch/arm/boot/dts/corstone500.dts > new file mode 100644 > index 000000000000..bcca7d736c85 > --- /dev/null > +++ b/arch/arm/boot/dts/corstone500.dts > @@ -0,0 +1,182 @@ > +// SPDX-License-Identifier: GPL-2.0 or MIT > +/* > + * Copyright (c) 2022, Arm Limited. All rights reserved. > + * > + */ > + > + Second ignored comment. I'll stop review. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel