From: Neil Armstrong <narmstrong@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Da Xue <da@libre.computer>
Subject: Re: [PATCH] spi: meson-spicc: save pow2 datarate between messages
Date: Wed, 10 Aug 2022 17:51:33 +0200 [thread overview]
Message-ID: <c7bfda2e-8135-fd2e-5d2b-5f547215bb18@baylibre.com> (raw)
In-Reply-To: <YvPFZZ2HT2zK9XjQ@sirena.org.uk>
On 10/08/2022 16:49, Mark Brown wrote:
> On Wed, Aug 10, 2022 at 04:40:04PM +0200, Neil Armstrong wrote:
>
>> I don't think it's worth adding so much code for this since we already
>
> I don't recall the code for clock providers being that hard? They're
> generally pretty small, some of the ASoC CODEC drivers did something
> similar.
Seems over-engineering to me, but I can explore this path if it's the best
route to follow.
>
>> had an open-coded function which perfectly worked before.
>
> Except in the cases it didn't...
It did but wasn't generic enough to take the new clock path introduced
in the new SoCs.
>
>> I'm perfectly OK to remove the CCF driver for the legacy clock path
>> and return back to the old open coded calculation since it perfectly
>> worked and stop using the legacy clock path for new SoCs since it would
>> never be selected anyway...
>
> It does seem better to go the clock provider route TBH.
I'm afraid this won't fix the problem since CCF won't set the clock again
if the rate is already ok in it's cache, we'd still need to save the divider
value and restore it after the reset as I did on this exact patch.
>
>> ... but GX SoCs are broken so it would need an intermediate fix until
>> I push the refactoring to cleanup all this.
>
> I'm trying to figure out if this is actually fixing the problem or just
> papering over one case where things happened to go badly.
It does, when clk_set_rate() is called, the datarate field would be the
same as after the previous call.
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-10 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 15:20 [PATCH] spi: meson-spicc: save pow2 datarate between messages Neil Armstrong
2022-08-09 15:27 ` Mark Brown
2022-08-10 9:17 ` Neil Armstrong
2022-08-10 12:37 ` Mark Brown
2022-08-10 14:01 ` Neil Armstrong
2022-08-10 14:31 ` Mark Brown
2022-08-10 14:40 ` Neil Armstrong
2022-08-10 14:49 ` Mark Brown
2022-08-10 15:51 ` Neil Armstrong [this message]
2022-08-10 16:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7bfda2e-8135-fd2e-5d2b-5f547215bb18@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=broonie@kernel.org \
--cc=da@libre.computer \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox