From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF83C43381 for ; Mon, 11 Mar 2019 08:06:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 670C7206BA for ; Mon, 11 Mar 2019 08:06:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kmrr9vrS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 670C7206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LbZv+jHA+hZBJReHE9orQMC/oRFxDImB4U1r0kBgTNU=; b=kmrr9vrSFt49F+GF/bPFD7a2l W+nbM/lniwqXAhn9RDIZgholPc2bPewNZaHm/sceuwtnqEhBNBsnVsuCK9VRVKBjgjT7oj4WDnPxJ Lb4g9xhlnZFOSJGgsLJcOtfejBrUZ0x85/XbW8EafunDDKLLvvRQEvJH1WdDhmOblkugOF66/DHsr RqQqo7sWtVxkiFEOpmM3gtlxcnigDwkxBxhREhKQma2EOHLBkZxHQ3rFik6jJGBOEGNoSQd8SMCcu 1wpQWbrQI3edzFwqeYifZgnEx5f8hqxQjabTl9dN3dQL486MAeucUtZHgOfI/WtutvaQzYc1KVkek /AKCIhWyw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3FxO-00023k-9p; Mon, 11 Mar 2019 08:06:46 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3FxJ-00022A-BP for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2019 08:06:43 +0000 Received: by mail-ed1-f67.google.com with SMTP id m35so3169712ede.10 for ; Mon, 11 Mar 2019 01:06:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hPXF5PngqF1AmgyWUQxnYlVcu/aGY/4pbfB3NhnZRkc=; b=PyiSEDSw+8VXWj1mAUu5QjhOiB6hC6SgM0xYe7VMINvB99LbgMgjbQ4gtnzNCkHlfg EEA17w0C3emopEki0z141fOd1NUoRHvsJjzFUVMkadZPFm+cPxyT9nlkLKkTQdGYgBcs MuphWOMCB7+jZxVJR9P8Haesrgdf04UJ+xmzUUNZokV6/lV37/cAKmr5Ye/kikeAf+5A vTQ9MeeJIoGh/ORI4VU28PecI667wKoiw8QHDWAQhYEFZh035laz/v+zDOZX8sRqkNyg slS/eZc45XSSIiw4y8fgf6NsPNQfLXD4MU1XPPV9aufx9CfSNVUT1NgobNADilegq1eW gDQQ== X-Gm-Message-State: APjAAAWshcgWUMfglW1FXFDFi/AJZbFGWXqiy1lZKQJFGn5ltSMPUCl+ hFMnNL2rX8icrlMSWAJ2lGZTeQ== X-Google-Smtp-Source: APXvYqwpZtYZ0ioqyO+Odt4tgsZnXR6AxI5xO7z9rh2XuLBmfd2y57h0vQN+AyQ/PW4lKNdYGOnt2w== X-Received: by 2002:aa7:c705:: with SMTP id i5mr1468624edq.14.1552291598291; Mon, 11 Mar 2019 01:06:38 -0700 (PDT) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id s24sm4383011edd.23.2019.03.11.01.06.37 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 01:06:37 -0700 (PDT) Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B To: Chunfeng Yun References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> <1552282383.10179.21.camel@mhfsdcap03> From: Hans de Goede Message-ID: Date: Mon, 11 Mar 2019 09:06:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552282383.10179.21.camel@mhfsdcap03> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_010641_392043_3F83A676 X-CRM114-Status: GOOD ( 21.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 11-03-19 06:33, Chunfeng Yun wrote: > Hi, > > On Fri, 2019-03-08 at 13:07 +0100, Hans de Goede wrote: >> Hi, >> >> On 08-03-19 07:13, Chunfeng Yun wrote: >>> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for >>> usb-b-connector >>> >>> Signed-off-by: Chunfeng Yun >>> --- >>> .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt >>> index a9a2f2fc44f2..7a07b0f4f973 100644 >>> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt >>> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt >>> @@ -17,6 +17,16 @@ Optional properties: >>> - self-powered: Set this property if the usb device that has its own power >>> source. >>> >>> +Optional properties for usb-b-connector: >>> +- id-gpios: gpio for USB ID pin. >> >> What about boards where the ID pin is *not* connected to a GPIO, >> but e.g. to a special pin on the PMIC which can also detect >> an ACA adapter ? Currently this case is handled by extcon >> drivers, but we have no way to set e.g. vbus-supply for the >> connector. Maybe in this case the usb-connector node should >> be a child of the PMIC node ? > Yes, it would be, PMIC is in charger of detecting the status of ID pin Ok, then I think this should be documented too. >> And in many cases there also is a mux to switch the datalines >> between the host and device(gadget) controllers, how should >> that be described in this model? See the new usb-role-switch >> code under drivers/usb/roles >> >> In some cases the mux is controlled through a gpio, so we >> may want to add a "mux-gpios" here in which case we also >> need to define what 0/1 means. > I'm not sure, the mux seems not belong to this connector, > and may need another driver to register usb-role-switch, > similar to: > > [v2,2/2] usb: typec: add typec switch via GPIO control > https://patchwork.kernel.org/patch/10834327/ Right the mux/role-switch will need a driver, but the "owner" of the usb_connector, e.g. the PMIC or the owner of the id GPIO pin needs to know which device is the role-switch so that it can set the role correctly based on the id-pin. Your binding already contains Vbus info, allowing the owner of the usb_connector to enable/disable Vbus based on the id-pin, but the owner will also be responsible for setting the role-switch. Note we cannot simply assume there will be only one role-switch, we really need some link from the usb_connector to the role-switch (or if it is a GPIO driven role-switch simply a role-switch-gpios member in the usb_connector). Regards, Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel