Re: [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings

[John Clark <inindev@gmail.com>]

On 5/6/25 11:44 AM, Conor Dooley wrote:
> On Tue, May 06, 2025 at 07:41:14AM -0400, John Clark wrote:
>> Add device tree binding for the Luckfox Omni3576 Carrier Board with
>> Core3576 Module, based on the Rockchip RK3576 SoC.
>>
>> Signed-off-by: John Clark <inindev@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 455fbb290b77..826dede32145 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -715,6 +715,16 @@ properties:
>>             - const: lckfb,tspi-rk3566
>>             - const: rockchip,rk3566
>>   
>> +      - description: Luckfox Core3576 Module
>> +        items:
>> +          - const: luckfox,core3576
>> +          - const: rockchip,rk3576
>> +
>> +      - description: Luckfox Omni3576 Carrier Board
>> +        items:
>> +          - const: luckfox,omni3576
>> +          - const: rockchip,rk3576
> 
> Not sure this is correct, does the module not have to be attached to
> this particular carrier to be used?

The compute module and the carrier board together like the E25. 
Presumably the compute module would be used in other applications
but the carrier board is not useful without it.

Is the E25 done correctly here?  I can copy this format:

model = "Radxa E25 Carrier Board";
compatible = "radxa,e25", "radxa,cm3i", "rockchip,rk3568";
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts?h=v6.15-rc5

compatible = "radxa,cm3i", "rockchip,rk3568";
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi?h=v6.15-rc5

- description: Radxa Compute Module 3 (CM3)
items:
   - enum:
       - radxa,cm3-io
   - const: radxa,cm3
   - const: rockchip,rk3566

- description: Radxa CM3 Industrial
items:
   - enum:
       - radxa,e25
   - const: radxa,cm3i
   - const: rockchip,rk3568
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/rockchip.yaml?h=v6.15-rc5

> 
>> +
>>         - description: Lunzn FastRhino R66S / R68S
>>           items:
>>             - enum:
>> -- 
>> 2.39.5
>>