From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBD32ECAAA1 for ; Tue, 30 Aug 2022 17:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5oFiiWt2f0sEhaG5T3SHyWe56Eyw4yw0o/csrslMJJQ=; b=dZT+MkzcU1syCG g16CNgiAZMD0s2KaKS1nM3WfBjpGuSzU161bJy/psaSkMhBRD12lLluaBK/TB/IF0d900hfn4JWaL 4aUA7sUdGoSGwpgjYEJwjHEbOWtiEm/BIkU3g+a2gtL3jXBSbPq1bUebpTdRZhIFC8Z5Lu5cfwGRt 7OqbXDK2g49TxZIZPEbp/6q5+dwbyXFR9IDK607koIL6K7nJJ+wYTE8RHOSqkU06DRr0CuLjkQtjP GnNg0v0tYubytRO6N7J6r1Q5zgvE5CfS8YsT+0MJBY9aE7Jkj/JzPcgqkxa8n0PntGf2JdswnKL2A z7jNWjC0RqrsNhxfeLOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oT4pK-000k5x-Fl; Tue, 30 Aug 2022 17:15:02 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oT4pE-000k2M-V8 for linux-arm-kernel@lists.infradead.org; Tue, 30 Aug 2022 17:14:59 +0000 Received: by mail-lf1-x132.google.com with SMTP id w8so7385658lft.12 for ; Tue, 30 Aug 2022 10:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=wqM8poQSBkP5+AJNOGOym7LP5PEFsyVQuT3qGSt/MeQ=; b=t8SfeBC0CMrKUskuld6g6k95a+OrKLt1l4p4i4wYP5WfVoRA9m4tYKjPyeefFS2Sth W1k3LmTakdmvBcyR4Of4koYIRweWQg1g2QJ4DIBUy63ug74x8XdiZhKyg5c8s9mnL3w2 OMf8+BGfeuk97J9Kb/7Bciy1t29Izl5eUd7Qfwrs+K2XPZlN3lCL1uoP3U+yPLarKhbI j3hiitXgHkTlYj/jZcEyCynSBMBxjlotKnR9RFOh5Z8i37jEyurjLHMi7qvxxj4/VDl9 rN1+tbMgUjAexZWmGr9d34icgOVS3D99IvFNGEc29Q7A7JRku2sQ4VSnOgO7GnRMm0bX UwqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=wqM8poQSBkP5+AJNOGOym7LP5PEFsyVQuT3qGSt/MeQ=; b=aiySo4fGusZC54QHABuZMNqXcMdfWG5cQ8iRFpX0hrFE+c9RFQGyv0Wcl4sYffxTrf tLSUOl5F9Pv7nd/DGRNgpLn0AEgn7hDtH1Ntes3kp3oJAyhBLoLFJyO6Q0zmFLHUGlKG G9vm85CFxNuQFvKQMNtS1ewRkGkZl1jq2hllg3GWCJst0l05xZQ1w72Klgs1/Bwd7iVo ZQnNO0k/1vfmhJx9Begfk0bWfNLshBt1e8vJF/lBwnl8b0VzLqikP/hOr/Vul7P7H118 tgBnHwZBXSYw9d30g5U3n9FepNY9GOGXSqs7i4vsJgUVvUzsISxdpE6ZzDooX2gGmqNW Uyfg== X-Gm-Message-State: ACgBeo0tYZMTvw2o0mYvt7HkbENh3VpA7At0cmQOFX7Jlgl+Tm2zVR00 qLUmaO5Gddb/Y/6MqFZ3q118WQ== X-Google-Smtp-Source: AA6agR7f3qJImjMtLOVfjApYz2NAbNuJJj7Daybtc1K7dNVuZS10wfEilsUloLI82Iu8FA5wnfynyQ== X-Received: by 2002:a05:6512:159b:b0:492:c1c0:5aab with SMTP id bp27-20020a056512159b00b00492c1c05aabmr7875077lfb.523.1661879694642; Tue, 30 Aug 2022 10:14:54 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id c17-20020a05651200d100b00492ea54beeasm384652lfp.306.2022.08.30.10.14.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 10:14:53 -0700 (PDT) Message-ID: Date: Tue, 30 Aug 2022 20:14:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH net-next v2 5/5] dt-bindings: net: altera: tse: add an optional pcs register range Content-Language: en-US To: Maxime Chevallier , davem@davemloft.net, Rob Herring Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20220830095549.120625-1-maxime.chevallier@bootlin.com> <20220830095549.120625-6-maxime.chevallier@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20220830095549.120625-6-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220830_101457_052888_D1DDC413 X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/08/2022 12:55, Maxime Chevallier wrote: > Some implementations of the TSE have their PCS as an external bloc, > exposed at its own register range. Document this, and add a new example > showing a case using the pcs and the new phylink conversion to connect > an sfp port to a TSE mac. > > Signed-off-by: Maxime Chevallier > --- > V1->V2 : > - Fixed example > > .../devicetree/bindings/net/altr,tse.yaml | 29 ++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/altr,tse.yaml b/Documentation/devicetree/bindings/net/altr,tse.yaml > index 1676e13b8c64..4b314861a831 100644 > --- a/Documentation/devicetree/bindings/net/altr,tse.yaml > +++ b/Documentation/devicetree/bindings/net/altr,tse.yaml > @@ -39,6 +39,7 @@ allOf: > properties: > reg: > minItems: 6 > + maxItems: 7 > reg-names: > minItems: 6 > items: > @@ -48,6 +49,7 @@ allOf: > - const: rx_resp > - const: tx_csr > - const: tx_desc > + - const: pcs > > properties: > compatible: > @@ -58,7 +60,7 @@ properties: > > reg: > minItems: 4 > - maxItems: 6 > + maxItems: 7 > > reg-names: > minItems: 4 > @@ -69,6 +71,7 @@ properties: > - const: rx_resp > - const: tx_csr > - const: tx_desc > + - const: pcs > - const: s1 > So now 8 items? > interrupts: > @@ -122,6 +125,30 @@ required: > unevaluatedProperties: false > > examples: > + - | > + tse_sub_0: ethernet@c0100000 { > + compatible = "altr,tse-msgdma-1.0"; > + reg = <0xc0100000 0x00000400>, > + <0xc0101000 0x00000020>, > + <0xc0102000 0x00000020>, > + <0xc0103000 0x00000008>, > + <0xc0104000 0x00000020>, > + <0xc0105000 0x00000020>, > + <0xc0106000 0x00000100>; > + reg-names = "control_port", "rx_csr", "rx_desc", "rx_resp", "tx_csr", "tx_desc", "pcs"; > + interrupt-parent = <&intc>; > + interrupts = <0 44 4>,<0 45 4>; > + interrupt-names = "rx_irq","tx_irq"; > + rx-fifo-depth = <2048>; > + tx-fifo-depth = <2048>; > + max-frame-size = <1500>; > + local-mac-address = [ 00 0C ED 00 00 02 ]; 00 00 00 00 00 00 (easier to spot that it is invalid) Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel