* [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
@ 2024-10-06 13:13 SurajSonawane2415
2024-10-11 7:47 ` Lee Jones
2024-10-11 9:09 ` (subset) " Lee Jones
0 siblings, 2 replies; 10+ messages in thread
From: SurajSonawane2415 @ 2024-10-06 13:13 UTC (permalink / raw)
To: pavel, lee
Cc: matthias.bgg, angelogioacchino.delregno, linux-leds, linux-kernel,
linux-arm-kernel, linux-mediatek, SurajSonawane2415
Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
to resolve the following warning:
drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
error: uninitialized symbol 'ret'.
Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
access.
Signed-off-by: SurajSonawane2415 <surajsonawane0215@gmail.com>
---
drivers/leds/rgb/leds-mt6370-rgb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c
index 10a0b5b45..87805c21e 100644
--- a/drivers/leds/rgb/leds-mt6370-rgb.c
+++ b/drivers/leds/rgb/leds-mt6370-rgb.c
@@ -587,7 +587,7 @@ static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev)
struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
struct mt6370_priv *priv = led->priv;
struct mc_subled *subled;
- int i, ret;
+ int i, ret = 0;
mutex_lock(&led->priv->lock);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-06 13:13 [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear SurajSonawane2415
@ 2024-10-11 7:47 ` Lee Jones
2024-10-11 13:20 ` Suraj Sonawane
2024-10-11 9:09 ` (subset) " Lee Jones
1 sibling, 1 reply; 10+ messages in thread
From: Lee Jones @ 2024-10-11 7:47 UTC (permalink / raw)
To: SurajSonawane2415
Cc: pavel, matthias.bgg, angelogioacchino.delregno, linux-leds,
linux-kernel, linux-arm-kernel, linux-mediatek
On Sun, 06 Oct 2024, SurajSonawane2415 wrote:
> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
> to resolve the following warning:
> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
> error: uninitialized symbol 'ret'.
> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
> access.
>
> Signed-off-by: SurajSonawane2415 <surajsonawane0215@gmail.com>
Real names only. Please update your .gitconfig.
> ---
> drivers/leds/rgb/leds-mt6370-rgb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c
> index 10a0b5b45..87805c21e 100644
> --- a/drivers/leds/rgb/leds-mt6370-rgb.c
> +++ b/drivers/leds/rgb/leds-mt6370-rgb.c
> @@ -587,7 +587,7 @@ static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev)
> struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
> struct mt6370_priv *priv = led->priv;
> struct mc_subled *subled;
> - int i, ret;
> + int i, ret = 0;
>
> mutex_lock(&led->priv->lock);
>
> --
> 2.34.1
>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-11 7:47 ` Lee Jones
@ 2024-10-11 13:20 ` Suraj Sonawane
0 siblings, 0 replies; 10+ messages in thread
From: Suraj Sonawane @ 2024-10-11 13:20 UTC (permalink / raw)
To: Lee Jones
Cc: pavel, matthias.bgg, angelogioacchino.delregno, linux-leds,
linux-kernel, linux-arm-kernel, linux-mediatek
On 11/10/24 13:17, Lee Jones wrote:
> On Sun, 06 Oct 2024, SurajSonawane2415 wrote:
>
>> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
>> to resolve the following warning:
>> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
>> error: uninitialized symbol 'ret'.
>> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
>> access.
>>
>> Signed-off-by: SurajSonawane2415 <surajsonawane0215@gmail.com>
>
> Real names only. Please update your .gitconfig.
>
>> ---
>> drivers/leds/rgb/leds-mt6370-rgb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c
>> index 10a0b5b45..87805c21e 100644
>> --- a/drivers/leds/rgb/leds-mt6370-rgb.c
>> +++ b/drivers/leds/rgb/leds-mt6370-rgb.c
>> @@ -587,7 +587,7 @@ static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev)
>> struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
>> struct mt6370_priv *priv = led->priv;
>> struct mc_subled *subled;
>> - int i, ret;
>> + int i, ret = 0;
>>
>> mutex_lock(&led->priv->lock);
>>
>> --
>> 2.34.1
>>
>
Thanks for the feedback. I'll update my .gitconfig to use my real name
for future patches.
Best regards,
Suraj Sonawane
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-06 13:13 [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear SurajSonawane2415
2024-10-11 7:47 ` Lee Jones
@ 2024-10-11 9:09 ` Lee Jones
2024-10-11 13:22 ` Suraj Sonawane
1 sibling, 1 reply; 10+ messages in thread
From: Lee Jones @ 2024-10-11 9:09 UTC (permalink / raw)
To: pavel, lee, SurajSonawane2415
Cc: matthias.bgg, angelogioacchino.delregno, linux-leds, linux-kernel,
linux-arm-kernel, linux-mediatek
On Sun, 06 Oct 2024 18:43:37 +0530, SurajSonawane2415 wrote:
> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
> to resolve the following warning:
> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
> error: uninitialized symbol 'ret'.
> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
> access.
>
> [...]
Applied, thanks!
[1/1] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
commit: b5a5659aebfffbcddb81abafe042fb4044b6ff9e
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: (subset) [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-11 9:09 ` (subset) " Lee Jones
@ 2024-10-11 13:22 ` Suraj Sonawane
2024-10-15 8:58 ` Lee Jones
0 siblings, 1 reply; 10+ messages in thread
From: Suraj Sonawane @ 2024-10-11 13:22 UTC (permalink / raw)
To: Lee Jones, pavel
Cc: matthias.bgg, angelogioacchino.delregno, linux-leds, linux-kernel,
linux-arm-kernel, linux-mediatek
On 11/10/24 14:39, Lee Jones wrote:
> On Sun, 06 Oct 2024 18:43:37 +0530, SurajSonawane2415 wrote:
>> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
>> to resolve the following warning:
>> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
>> error: uninitialized symbol 'ret'.
>> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
>> access.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
> commit: b5a5659aebfffbcddb81abafe042fb4044b6ff9e
>
> --
> Lee Jones [李琼斯]
>
Thank you! I'm glad the patch was applied. I'll ensure future patches
follow the necessary guidelines.
Best regards,
Suraj Sonawane
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-11 13:22 ` Suraj Sonawane
@ 2024-10-15 8:58 ` Lee Jones
2024-10-16 4:21 ` [PATCH v2] " Suraj Sonawane
2024-10-16 4:25 ` (subset) [PATCH] " Suraj Sonawane
0 siblings, 2 replies; 10+ messages in thread
From: Lee Jones @ 2024-10-15 8:58 UTC (permalink / raw)
To: Suraj Sonawane
Cc: pavel, matthias.bgg, angelogioacchino.delregno, linux-leds,
linux-kernel, linux-arm-kernel, linux-mediatek
On Fri, 11 Oct 2024, Suraj Sonawane wrote:
> On 11/10/24 14:39, Lee Jones wrote:
> > On Sun, 06 Oct 2024 18:43:37 +0530, SurajSonawane2415 wrote:
> > > Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
> > > to resolve the following warning:
> > > drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
> > > error: uninitialized symbol 'ret'.
> > > Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
> > > access.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
> > commit: b5a5659aebfffbcddb81abafe042fb4044b6ff9e
> >
> > --
> > Lee Jones [李琼斯]
> >
> Thank you! I'm glad the patch was applied. I'll ensure future patches follow
> the necessary guidelines.
Sorry, this is a tooling error. The patch was not meant to be applied.
Please resubmit it using your updated .gitconfig file.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-15 8:58 ` Lee Jones
@ 2024-10-16 4:21 ` Suraj Sonawane
2024-10-16 7:53 ` (subset) " Lee Jones
2024-10-16 4:25 ` (subset) [PATCH] " Suraj Sonawane
1 sibling, 1 reply; 10+ messages in thread
From: Suraj Sonawane @ 2024-10-16 4:21 UTC (permalink / raw)
To: lee
Cc: angelogioacchino.delregno, linux-arm-kernel, linux-kernel,
linux-leds, linux-mediatek, matthias.bgg, pavel,
surajsonawane0215
Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
to resolve the following warning:
drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
error: uninitialized symbol 'ret'.
Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
access.
Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
---
V1 : https://lore.kernel.org/linux-arm-kernel/83572cde-19a1-4089-b02b-361a8ef40bee@gmail.com/T/
V2 : Updated .gitconfig to use the real name "Suraj Sonawane" as per the feedback.
drivers/leds/rgb/leds-mt6370-rgb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c
index 10a0b5b45..87805c21e 100644
--- a/drivers/leds/rgb/leds-mt6370-rgb.c
+++ b/drivers/leds/rgb/leds-mt6370-rgb.c
@@ -587,7 +587,7 @@ static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev)
struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
struct mt6370_priv *priv = led->priv;
struct mc_subled *subled;
- int i, ret;
+ int i, ret = 0;
mutex_lock(&led->priv->lock);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH v2] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-16 4:21 ` [PATCH v2] " Suraj Sonawane
@ 2024-10-16 7:53 ` Lee Jones
2024-10-16 12:13 ` Suraj Sonawane
0 siblings, 1 reply; 10+ messages in thread
From: Lee Jones @ 2024-10-16 7:53 UTC (permalink / raw)
To: lee, Suraj Sonawane
Cc: angelogioacchino.delregno, linux-arm-kernel, linux-kernel,
linux-leds, linux-mediatek, matthias.bgg, pavel
On Wed, 16 Oct 2024 09:51:42 +0530, Suraj Sonawane wrote:
> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
> to resolve the following warning:
> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
> error: uninitialized symbol 'ret'.
> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
> access.
>
> [...]
Applied, thanks!
[1/1] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
commit: 6cbf5c99541ac681cf5c6155b582dfbcd879eae3
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: (subset) [PATCH v2] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-16 7:53 ` (subset) " Lee Jones
@ 2024-10-16 12:13 ` Suraj Sonawane
0 siblings, 0 replies; 10+ messages in thread
From: Suraj Sonawane @ 2024-10-16 12:13 UTC (permalink / raw)
To: Lee Jones
Cc: angelogioacchino.delregno, linux-arm-kernel, linux-kernel,
linux-leds, linux-mediatek, matthias.bgg, pavel
On 16/10/24 13:23, Lee Jones wrote:
> On Wed, 16 Oct 2024 09:51:42 +0530, Suraj Sonawane wrote:
>> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
>> to resolve the following warning:
>> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
>> error: uninitialized symbol 'ret'.
>> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
>> access.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
> commit: 6cbf5c99541ac681cf5c6155b582dfbcd879eae3
>
> --
> Lee Jones [李琼斯]
>
Thanks a lot!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
2024-10-15 8:58 ` Lee Jones
2024-10-16 4:21 ` [PATCH v2] " Suraj Sonawane
@ 2024-10-16 4:25 ` Suraj Sonawane
1 sibling, 0 replies; 10+ messages in thread
From: Suraj Sonawane @ 2024-10-16 4:25 UTC (permalink / raw)
To: Lee Jones
Cc: pavel, matthias.bgg, angelogioacchino.delregno, linux-leds,
linux-kernel, linux-arm-kernel, linux-mediatek
On 15/10/24 14:28, Lee Jones wrote:
>> On 11/10/24 14:39, Lee Jones wrote:
>>> On Sun, 06 Oct 2024 18:43:37 +0530, SurajSonawane2415 wrote:
>>>> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
>>>> to resolve the following warning:
>>>> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
>>>> error: uninitialized symbol 'ret'.
>>>> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
>>>> access.
>>>>
>>>> [...]
>>> Applied, thanks!
>>>
>>> [1/1] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
>>> commit: b5a5659aebfffbcddb81abafe042fb4044b6ff9e
>>>
>>> --
>>> Lee Jones [李琼斯]
>>>
>> Thank you! I'm glad the patch was applied. I'll ensure future patches follow
>> the necessary guidelines.
> Sorry, this is a tooling error. The patch was not meant to be applied.
>
> Please resubmit it using your updated .gitconfig file.
Thank you. I have updated my .gitconfig to use my real name "Suraj
Sonawane" as requested and have resubmitted the patch.
Best regards,
Suraj Sonawane
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-10-16 12:15 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-06 13:13 [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear SurajSonawane2415
2024-10-11 7:47 ` Lee Jones
2024-10-11 13:20 ` Suraj Sonawane
2024-10-11 9:09 ` (subset) " Lee Jones
2024-10-11 13:22 ` Suraj Sonawane
2024-10-15 8:58 ` Lee Jones
2024-10-16 4:21 ` [PATCH v2] " Suraj Sonawane
2024-10-16 7:53 ` (subset) " Lee Jones
2024-10-16 12:13 ` Suraj Sonawane
2024-10-16 4:25 ` (subset) [PATCH] " Suraj Sonawane
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).