From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 156FEC30653 for ; Thu, 4 Jul 2024 09:03:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cx3d5CxqTkB14K4gwBHdHmuzRMB2FNvR/ektMnAQxOM=; b=EAqRX5fQoyUhzb1VK66yK8nSjr zIKJS8gRS4LujC2LrOiMNfJTnzyqE0sNiEZsuit0GJQydmXenv7ze1NiO+q7/YzjyUuKkNbEs1m4u Ypt1C4WDkXhGKxDCpv4mi/sskHws7UvQincKglbpiIQYQOsyldq9ShYHxuEeWaquUtH7iTlzw2Z2t NYbzMo1qWs51qtzPDgD1F3+/6qwxg3Y58E0T4n7hjwrHHITsUffxeano038y1dca9ogTNyVILv6aG 1TelYbrypHK4d4/iOfWLZWdLqf3I5ih6YTp32S8hKPtSsTFLlE7zuDrQwPHJY+CevdR78fbFw6YHq Uz5ySwPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPIN3-0000000ChBc-2KWu; Thu, 04 Jul 2024 09:03:17 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPIMq-0000000Ch9E-2yyH for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2024 09:03:05 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-36799fb93baso315525f8f.0 for ; Thu, 04 Jul 2024 02:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720083783; x=1720688583; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Cx3d5CxqTkB14K4gwBHdHmuzRMB2FNvR/ektMnAQxOM=; b=e6pr3IHpxYal61bDSbJPsTmGa+TXMjjbqGgmKVnE5f4jh35wsQFQxR8aSemuTyoGgR J3vd029N4IqxQI1JBai+rBI4etiPc8CleaCwWyAAz0bsrxkdmMaD+OJLVV4pkmWGMNbX QCRYbRhx7H2cwonBbi6Ba7uiJiR1BKGzT/rydP8KCBBjFQfSICmwcI7kjF/vU92ZGrYK q2CM+N7wy4WRGKtwjTRv5GnHhUdNXtuKxqk/IvL+vl6HgOqz0dmBYoZI0rYsFa+WROPQ Qj7ALc583dGtXSXX1gu3nRZ0CA/FrzEq2FZsl7+vkMGB5MBM/k7HAlUTS10lOsYRq/we 9Vig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720083783; x=1720688583; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cx3d5CxqTkB14K4gwBHdHmuzRMB2FNvR/ektMnAQxOM=; b=FrdiSzKqD+3KKyyK9B2Rcy6YrrQ37Wnhx/BYoMsRJFIQrfokK9b9NkqP2HrG61kzk0 WL3AXsgpKNb4P8N/s1pUWl8WvPaHbtQfMxrmRRHQgnR6iQ9fhVX/JR/6UHiFY5PFR3SE W37yZO7cTiMrFToHYBu8wGicHDKFJ7ipY+fUCfhDZUIm9gVyO+QJHOnImECFfty2uqkn L3Ba94UK3TsLJk5ptT/Sxny/TP/GduQYkrapUznZYiEizIHngIwMiBq5+XBMuljeF4Ez IKPFZBwdW79Oj+nSJld0FsjKNYlGFMKwSKF4Zudh85CI3msNS1yE+AqqVXXJ12eeWDYb Tlwg== X-Forwarded-Encrypted: i=1; AJvYcCWoIJSWs1P0PvSEosFYlQyDOtvLXWg7lPwN8pctyZB6GK5BzoDagaIDlJO+qC8waE6+32WpWj9wl/fDU2638ek7cBTKL1L8ra4zushi0RPeN6ISAFk= X-Gm-Message-State: AOJu0YxrN/nM6xNVjE4Vqfxt7C/xLqR/6KYi+4Mi1hqT3zT21CBCRInm hcEzgGaM9eM64yZiR1EoMa+iiOM0oJMRAl1VUbQyLB966OPOWuPa X-Google-Smtp-Source: AGHT+IE5rRRgQ+3VAktBOrwvlEMxaYncLW64BefnBB2CyyVIkKT2zQeyktZpK58oIjvjEAzP4/eFaw== X-Received: by 2002:a5d:608e:0:b0:367:9877:750e with SMTP id ffacd0b85a97d-3679dd3df99mr753973f8f.25.1720083782983; Thu, 04 Jul 2024 02:03:02 -0700 (PDT) Received: from ?IPV6:2a02:8389:41cf:e200:2c0f:6313:4446:a47? (2a02-8389-41cf-e200-2c0f-6313-4446-0a47.cable.dynamic.v6.surfer.at. [2a02:8389:41cf:e200:2c0f:6313:4446:a47]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3679c9008b0sm1194575f8f.80.2024.07.04.02.03.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 02:03:02 -0700 (PDT) Message-ID: Date: Thu, 4 Jul 2024 11:03:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] mfd: rohm-bd9576: Constify struct regmap_config To: Matti Vaittinen , Support Opensource , Lee Jones , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Xu Yilun , Tom Rix Cc: linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20240703-mfd-const-regmap_config-v1-0-aa6cd00a03bd@gmail.com> <20240703-mfd-const-regmap_config-v1-6-aa6cd00a03bd@gmail.com> <0acd9da5-80ec-4a45-b00a-8e28ab4e345a@gmail.com> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: <0acd9da5-80ec-4a45-b00a-8e28ab4e345a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_020304_772406_39FB3E46 X-CRM114-Status: GOOD ( 20.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/07/2024 06:50, Matti Vaittinen wrote: > On 7/3/24 18:37, Javier Carrasco wrote: >> `bd957x_regmap` is not modified and can be declared as const >> to move its data to a read-only section. >> >> Signed-off-by: Javier Carrasco >> --- >>   drivers/mfd/rohm-bd9576.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c >> index 3a9f61961721..634c65c7d108 100644 >> --- a/drivers/mfd/rohm-bd9576.c >> +++ b/drivers/mfd/rohm-bd9576.c >> @@ -57,7 +57,7 @@ static const struct regmap_access_table >> volatile_regs = { >>       .n_yes_ranges = ARRAY_SIZE(volatile_ranges), >>   }; >>   -static struct regmap_config bd957x_regmap = { >> +static const struct regmap_config bd957x_regmap = { >>       .reg_bits = 8, >>       .val_bits = 8, >>       .volatile_table = &volatile_regs, >> > > Thanks a ton Javier. This looks good to me but if you feel like going an > extra mile while you are at it... Do you think this could be extended to: > > > diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c > index 3a9f61961721..17323ae39803 100644 > --- a/drivers/mfd/rohm-bd9576.c > +++ b/drivers/mfd/rohm-bd9576.c > @@ -57,7 +57,7 @@ static const struct regmap_access_table volatile_regs = { >         .n_yes_ranges = ARRAY_SIZE(volatile_ranges), >  }; > > -static struct regmap_config bd957x_regmap = { > +static const struct regmap_config bd957x_regmap = { >         .reg_bits = 8, >         .val_bits = 8, >         .volatile_table = &volatile_regs, > @@ -65,7 +65,7 @@ static struct regmap_config bd957x_regmap = { >         .cache_type = REGCACHE_MAPLE, >  }; > > -static struct regmap_irq bd9576_irqs[] = { > +static const struct regmap_irq bd9576_irqs[] = { >         REGMAP_IRQ_REG(BD9576_INT_THERM, 0, BD957X_MASK_INT_MAIN_THERM), >         REGMAP_IRQ_REG(BD9576_INT_OVP, 0, BD957X_MASK_INT_MAIN_OVP), >         REGMAP_IRQ_REG(BD9576_INT_SCP, 0, BD957X_MASK_INT_MAIN_SCP), > @@ -76,7 +76,7 @@ static struct regmap_irq bd9576_irqs[] = { >         REGMAP_IRQ_REG(BD9576_INT_SYS, 0, BD957X_MASK_INT_MAIN_SYS), >  }; > > -static struct regmap_irq_chip bd9576_irq_chip = { > +static const struct regmap_irq_chip bd9576_irq_chip = { >         .name = "bd9576_irq", >         .irqs = &bd9576_irqs[0], >         .num_irqs = ARRAY_SIZE(bd9576_irqs), > > > Yours, >     -- Matti > Sure, I will generalize it and update the series to cover regmap_irq and regmap_irq_chip as well, of course including these two cases too. Best regards, Javier Carrasco