From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBDB5C433ED for ; Tue, 11 May 2021 10:19:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D84261925 for ; Tue, 11 May 2021 10:19:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D84261925 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/HUIwT2LgU9kxgDHtLXJpYiYjDQJ26rZXa1Ie5L0E/4=; b=X73lwXOrgasK3stKLaYfi3I2i qF1sNMfaLQyTuG38ADAuXiOdBH33i2ITs/mAIwaUMrJnYyPN3gf/DaXKhH/kPkQDB6iulwmKmWVV0 tl4gxo5j5ihDbtxoOG0XdQdjceuUhrMr0Nb5g1t6LfEl4w+EnPhbNXtFfj17aBsiufZt3BIgb/XkY On9/c3crlEwW3N4hZbSq30K3g5E72dva7j7PxADgdzhfv187CeS20t7SRMhorod4gw0jlQC+HLaX3 5FDh0I8Ct2g4jAupscXGy++mijADcfmKF5UVxRRSAFnnpUbr4XWlmB7L/OCEmBIvVyVJ7U0SHv+t+ I2fOo1DeQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgPSe-00GslW-TV; Tue, 11 May 2021 10:17:57 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgIvt-00GAcO-0m for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 03:19:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:Date:Message-ID:From: References:Cc:To:Subject:Sender:Reply-To:Content-ID:Content-Description; bh=jn09UUEkWkY9EMWJioc6BNoSpap1fc2aLbPACepQi+o=; b=2hFw93ij/8rlDJFLoki5Hf3f1k MhQ3n3B33TcrSX8yLZKDadjSR7mZ0EMokYhPloKeL2q11v+mwemWJU6G3cGtdRNJk2hio8LzTv7fl RFD2Ndcm/ZQ2BoYQzu5oVYvzk/BIqou04OCuLnaN6c7S4wcdyfcBb36iGn6tjfv/kd6ZwVpdKk8aN 1b+e/f3RRQ6moxCgK9UR9yzflQ/eIu8x1mVoGJpYJ3hEc8ZtJ5n5yrgTEqobXZLEJR1bvQvxgSKnk yfk62MhGggSseZzuuFGu1vN3wA9Qgrh+maU94bQs/CPda4AG8wHvw9zRPUG8q/7wPy8a/C4UvTIb5 44i8VcwQ==; Received: from mail-bn8nam12on2088.outbound.protection.outlook.com ([40.107.237.88] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgIvl-009H9t-OV for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 03:19:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YO8xQmC4TFaYH5CjfzkbGk6ejujf6u4LxXlO+gxjyttfVEk2M7eHEy1aDVpra5ASNV6BqU/f7/AAgk9nVKcvkaFQ+1ckWJThAmKaJna4PX+rG80IJmwnyLfeAaEFE4flhEA1Hy2OxZeU9ZI5Fq5CBjnb+odHcUbhw8bu0W8gJBeYcol/OAeL+83zyFST16Zs1VHIQATgxoldwU81LEFucM9JpD2k0azj1bvSvQzb1Wd94XyLHfWKf1puSlsUCRPpLCtVAzFWKhSnyJXyS+Xp59H+/3mOaHtSocpyBZRvWSqNxJi7GlA9T6yYXBVMXfYoeIOmgpndQe+/MBz8rZfeLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jn09UUEkWkY9EMWJioc6BNoSpap1fc2aLbPACepQi+o=; b=Xe+ln82PXXv6RhPrHpKn9NqOqsYbVpAzzx7a+VAGfQx6F4YJ0iOcR/i46LOPmhy//53Sz8t8GDD8YmfiPKEGMxwhKw2AfhL3ZHd0Ju552JR0D7GgLEWwfj0Ze9kfYGu52xHTpJAF6O0MF0pQSyRCefz7KtjkDMJihkVq/1IMAMt47OV/DMaR66YnWO8bBtIPiC/VGd96CFQvog5ukVoWgABL40c+p1UBMOArwjaZBPeTYG5AHJSr8koDLjPGAdrZNutXsg91sF+Dwk4blXmiykPkI1Nr/WleR3eoI/vro29ynUg8avrQp8Bs7KbntXmiqlXZ16f6KIjllwg1AmNwyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jn09UUEkWkY9EMWJioc6BNoSpap1fc2aLbPACepQi+o=; b=H1jlQHaf6xwWJqO3BC2WNPaWwtBrE0KTe+KF0ls5H7vUnUmGr5dN5gagjeCb7eEp4RnSsKtRBoNOQzExKhSSOEwP4PlT/PtgI2DXV6JyuRI/jcnKLRCv55FQ+qcDykCLHIlcOvP3HBGhx9NNnMT0SJ4azHbv9tndgAjteobmFpU= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=windriver.com; Received: from MWHPR1101MB2351.namprd11.prod.outlook.com (2603:10b6:300:74::18) by CO1PR11MB4772.namprd11.prod.outlook.com (2603:10b6:303:97::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May 2021 03:19:29 +0000 Received: from MWHPR1101MB2351.namprd11.prod.outlook.com ([fe80::c156:455d:860e:ba87]) by MWHPR1101MB2351.namprd11.prod.outlook.com ([fe80::c156:455d:860e:ba87%4]) with mapi id 15.20.4108.031; Tue, 11 May 2021 03:19:29 +0000 Subject: Re: [PATCH v2 3/3] audit: Use syscall_get_return_value to get syscall return code in audit_syscall_exit To: Paul Moore Cc: oleg@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, Eric Paris , linux-audit@redhat.com, linux-kernel@vger.kernel.org References: <20210423103533.30121-1-zhe.he@windriver.com> <20210423103533.30121-3-zhe.he@windriver.com> From: He Zhe Message-ID: Date: Tue, 11 May 2021 11:19:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [60.247.85.82] X-ClientProxiedBy: SJ0PR05CA0024.namprd05.prod.outlook.com (2603:10b6:a03:33b::29) To MWHPR1101MB2351.namprd11.prod.outlook.com (2603:10b6:300:74::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [128.224.162.175] (60.247.85.82) by SJ0PR05CA0024.namprd05.prod.outlook.com (2603:10b6:a03:33b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.20 via Frontend Transport; Tue, 11 May 2021 03:19:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0725d13f-5b25-4160-ebe4-08d9142b96a1 X-MS-TrafficTypeDiagnostic: CO1PR11MB4772: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RrboQVA0q1ci8W1M+TL1MDAWPRJBAJFTsHtM5xSNG870pWOxlNZvG+9pnNdO6UxKOlpICC/TEnXG5RbHwCE+XEco8M7LU3MIFEwr4viOIB6vcwmTkMTsW9Ow2UzfSqnI313yrQQd3CnFkoIXw5zUemlm/eXBJdy5i53gZMWC4zlPFbifzGVyXxeziNfzrhOHWVOjnwXBmDMP6fhWzKsKbaxsM+3CbZRv4ENyEnyafuVjPxJzG3LLa0Z6tlRDVKMM7s3t8+HtL9+8qBBks66g2oMVwzFEtMPeuYCdE+/4V23XKZEq4cYOV4MdczHXyWeFLbEjKB/PmcJxmgb5T2ivPDtfoJ/OYJOj7+cj41ArKrzn8P4Tl9tD0be1LU/Hh9EQciRJiV33CEW14SdQkPf+5oJs8u8KVN2ACT99rJzJhX5E1MkY82yhl7rWC9Lp7objnp5RHIuPN9nld6R+KA7+dQDtr1KMTxIOLmyZXVmjiGpYJQX8VnKYQsi5x9va355ODGf/V7fzyX1jTvM3WRkcr4wvD1Z20uYtpehZ4BCb/FFiAFcOItKAf/vtCyC4ngzv7jbTgKCNdKFK6OIxznkbAj4IPfTghLWXQXwPpEcniVomFAWH6gV9mpCe5ow1myqXVMUjsSazt+3SbhLJQ4RaUqcyhu6HqTZS4oYgGk1BxvYfvc5MB9IMkRc/RFeXQhpoJ0UUDMSSRY8PjUFQ6oQMjFouMnMf/8SLP4soWA7dCJ50PuF1DTm1xbLb+MmuncyXQ+vduSmufnP4yCXxEnUkuKE1GmZaXpHx+ELuRAUTvelBpHnMnyQoU6McofWE0u2S X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1101MB2351.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39850400004)(346002)(366004)(376002)(2616005)(66946007)(956004)(26005)(31686004)(4326008)(16576012)(478600001)(6666004)(316002)(8676002)(8936002)(6916009)(83380400001)(52116002)(6706004)(66556008)(53546011)(36756003)(966005)(66476007)(2906002)(86362001)(6486002)(38350700002)(38100700002)(5660300002)(31696002)(186003)(16526019)(78286007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?L0NYQ3lIdTFuYkQyTXRLU0JPT05LejZUNzd2a3lpMFRlVWZRbEdlTzUxMUJT?= =?utf-8?B?Yk1zTmVPRHVReUw5UWNPSWZNcnVodVJuTFZtWU51WlI5ZHBOMmE1NHNMcWxG?= =?utf-8?B?TmY2bHFXOXNPcHpmckI0U1hwSGVOMTlGeS9XdGVuSXVhM3QwcEsrVkR0TStF?= =?utf-8?B?N0hLYmdPQmdyUEFhTStBN3NnSnlVNXJLZDUwdUdFN1dNRnQxYUhZbmxiZktl?= =?utf-8?B?b0NvUHAvMHZJUVNqdWdwS1gvWGdycVVncTh1U1ZGTDl4d3hZSjNreDVrakxs?= =?utf-8?B?NXZoRDl4UEJxWTlRdmxHbE5zSFRGa2I0T1dMT1NmOW5CVS9paGpUaklCdUFj?= =?utf-8?B?aEsxbjc5OVhsUnhSb3M2WEI5QjhxVHFwUWZqa2FPT3Q4ZCt1MUJkNy91dmcz?= =?utf-8?B?MURhV2F5Q2pTN3orSkUyUVlOK3kyVERDMVhwMTIwV1d1eTMrTUNHeVMrMnlR?= =?utf-8?B?VUxKOHBsbXJrQmt0d2pFbmVvelZKUER6WWlnRlNXc0hkVDBYZzE3ZkJpSTFR?= =?utf-8?B?SmpBZVJBMFRKZFRCbDEyM1JmNVdPYnl2RGtsQ1RLTW1FVzlQOXRTUzJqOWZu?= =?utf-8?B?WXhtbXVjOGlqSWZwQm9Ja3lOVjBLL0g3anFnOHpheHVaYzdUZk84NURKeFZW?= =?utf-8?B?ZWEwT2ZpUWUzT2Qzc2RObWV2UzkrakwyNlFwelpUMHBNZ0kzZ3BFcjZtd2VH?= =?utf-8?B?N29vcmlzamhLSEtwQ1dacDBHTWJGaHRpTUdQd2Z1MWl0ME82TEF0QW9FbVpR?= =?utf-8?B?eHl1bU1ITGRscHMweHgra3BmSDkveE5UYit1TzdlWjFBbDIwemtjbDd5VlE2?= =?utf-8?B?U05wMzMycWs1SVN0ZEI5Y3M3ZjZ1Ny94cHBEa2JuQkhGaGo5V1JtL0hVKzZW?= =?utf-8?B?bTlsSGFDbEljZE9NdEF0YkMzeW92R2VtNDlZSjE3Rm9OK0NWcjNubE1BMmNN?= =?utf-8?B?K0xMQ2VkMDAwSW9jTnMyQmIxMSs5bWxraDFSem9vQm10Rzg3Sm5XRERhVTQ2?= =?utf-8?B?enhWVUJXOFVyK0JuYnNRM25MM2g4QjJhLyt1S1B2VUNUN29JWkkrYjBwUDgy?= =?utf-8?B?cHovR2tZdEZzYUxJeHZmaDRDOE9EYmdSN3Q4NTZTSnZlUVRzdjFocHBuWW5N?= =?utf-8?B?dnAzM2pEVGZYZ1RMVW9jS1Zmckh6M0tYdGRteEFhMCtXQkprOW1ab1RxYUVE?= =?utf-8?B?RXlPSDJhbGRmaGNVRmloMm9oYTN3ZGhHVU9kQkZFMXZpUklwSUhnN3RMV3Nt?= =?utf-8?B?dG93emI4M3lBR3dvcE9LVUIvVXM3a3FuWG5aMExlemt5bkoydzh1U1hManYx?= =?utf-8?B?ejR6Zkg5bTJ5KzFWeXdOQXVscmt5QUFJbDB6akhnWWM2V0VZUUlsa05LL1pQ?= =?utf-8?B?ZWJTUzhkN2JGT0xSYUFVcG1pTU15d29jOUtNOENTQ2V1YjUxZy9Ec2l3QlpH?= =?utf-8?B?TGE4TitLNFdSRTYwazZNSDE3bGxWbE9rNGhCWkEySnplaGVscGRRbE03cGc3?= =?utf-8?B?UUdVRWdHcWozUzQ1bERjUnlRS0FiZDlDNEp5OHJsZHowdy9pY0FqdE8wQkZs?= =?utf-8?B?UGc2RTgvREFLTHZ2b2FFQkJUTVl6MnpJdldUTDhGaW5KbUhCMlQ5c1dOVGk1?= =?utf-8?B?ZkowaXdMb1ZCZVU2VnpmdVptajdrUWNnU3ZrWjRXYzhVYnlhVWF6WDJ4aytN?= =?utf-8?B?eFFGclJ3RlFLTndGb0piSjdSd0UvTHNRMnpxcUxuaXV3R3QzbmxURXZPRTJm?= =?utf-8?Q?guHmxgl7slUfyfVj/AGBxRiqyr3ATcCFcWmTh1o?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0725d13f-5b25-4160-ebe4-08d9142b96a1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2351.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2021 03:19:29.4278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DRhSiEoghj6i6icqV1A3XpJSnSaeoLQAMmfVSPDCYV985OhEowoVrZvFDptToZwt1gragB5rgyUlUvc5YJ41Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_201933_912674_850EC82B X-CRM114-Status: GOOD ( 19.87 ) /bin/ln: failed to access 'reaver_cache/texts/20210510_201933_912674_850EC82B': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_201933_912674_850EC82B X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/11/21 6:38 AM, Paul Moore wrote: > On Fri, Apr 23, 2021 at 6:36 AM He Zhe wrote: >> regs_return_value for some architectures like arm64 simply retrieve >> register value from pt_regs without sign extension in 32-bit compatible >> case and cause audit to have false syscall return code. For example, >> 32-bit -13 would be treated as 4294967283 below. >> >> type=SYSCALL msg=audit(1611110715.887:582): arch=40000028 syscall=322 >> success=yes exit=4294967283 >> >> We just added proper sign extension in syscall_get_return_value which >> should be used instead. >> >> Signed-off-by: He Zhe >> --- >> v1 to v2: No change >> >> include/linux/audit.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Perhaps I missed it but did you address the compile error that was > found by the kernel test robot? I sent a patch adding syscall_get_return_value for alpha to fix this bot warning. https://lore.kernel.org/lkml/20210426091629.45020-1-zhe.he@windriver.com/ which can be found in this mail thread. > > Regardless, one comment inline below ... > >> diff --git a/include/linux/audit.h b/include/linux/audit.h >> index 82b7c1116a85..135adbe22c19 100644 >> --- a/include/linux/audit.h >> +++ b/include/linux/audit.h >> @@ -334,7 +334,7 @@ static inline void audit_syscall_exit(void *pt_regs) >> { >> if (unlikely(audit_context())) { >> int success = is_syscall_success(pt_regs); > Since we are shifting to use syscall_get_return_value() below, would > it also make sense to shift to using syscall_get_error() here instead > of is_syscall_success()? In [PATCH v2 1/3], is_syscall_success calls syscall_get_return_value to take care of the sign extension issue. Keeping using is_syscall_success is to not potentially changing other architectures' behavior. Thanks, Zhe > >> - long return_code = regs_return_value(pt_regs); >> + long return_code = syscall_get_return_value(current, pt_regs); >> >> __audit_syscall_exit(success, return_code); >> } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel