From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BB4FC77B7D for ; Thu, 18 May 2023 05:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kOfPattY3nalc5spYlB34QIeP9jdfILC1Soyuam+38w=; b=ieeMnOI0eGtwXA FAWZPLU9tSG2ypn8vU/nJ5YAk25i6yqXx9tdC9GTp+55eEQJgpNGX+KK84owOKFRjaAqCzDG72lVY fOO+PKuM23dGRNnFLpEcoratwRdq33cUPBKZYCHtdSa1kVCysumxOh+n7VbtqL5vU+HPAaQnJ9kFI RXt7l+zgJWvuHaBSlXkVx9C80zZ+Xef7J6059UFfYzevIkXWtM3PNkpE6WxeWJQVg8lOMVah03Xw+ 4JhePxVKDTIodsMbZ/APAA7e129r9SOe3pU2dgLIGUrk/T4K0wBlvP1FVx0dEh6/HOPWY4HMdIefL Y2UvEdonptHleiWlOt9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzWNC-00Bxgy-0o; Thu, 18 May 2023 05:40:22 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzWN6-00Bxfl-2K for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 05:40:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1684388416; x=1715924416; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=TqTEpCWhNlyUvaXBb+Rnpd9foTksOS044EeU9FQSrjw=; b=GBBWrOuo6+I5vGsVlV7tmZ6/aKNgEsIqmsZ85Y+vALZvGUqn2Yzo4Pgs 7d3Y3r7ptL0bTCV7lgAJ8xAN3WeQ6/iZtNUtXXv8sOO8gEmO01AnAvtgH z3d6KD+gkxDh4APiZhXnCAVQ7HC3APiR1B7HNio9GVkc4yuawIgsNrviY xzc7hqQqiW+9uz4+VMJB/TUSFuxMmy12MjEgiXCiatTKApjybPjoe3g/p rWRz3p+4ezQ+vgCeHFe3MsNYFH6aHULw9C6oeuh1TnNNXu/w2b1ljck+D fzo2ZxT36JjQW+EGQewEA/R+zyQPeHnLcwDASMIniMjDSEEyYsT6Gyq2y g==; X-IronPort-AV: E=Sophos;i="5.99,284,1677567600"; d="scan'208";a="216033529" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 May 2023 22:40:09 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 17 May 2023 22:40:08 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 17 May 2023 22:40:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mOz/ctZaB8yJ/SYrR/dMiy9gNjRyaX+f07/jO0Cfxo99vFRv06PjAvKLwyJSejhjAS4fmMKPBorDkPBsuVy92mgDFbXurumiq2VUtNXSJ7lopgt2WpB714+d/FhLlP7EwtSEpvAY89xw2ZbuBIegdnBtp4iTikSL+N+dqZljfDck8eWq8js43FDWt7q8zYsAqHVG0LyZyD6P7v9f0SeOiBMJjyVUeykUIKO730+5n4SbpUinPrLrr9QjfBRfM3h5WdOeKk2bXXFyJd14ORy0H8J5kUkKW/8frPm1mbMwUCxxjjycvC3kP2LLOyGz/us3Uxin6BS4pQE2TIs8jJ9Svw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TqTEpCWhNlyUvaXBb+Rnpd9foTksOS044EeU9FQSrjw=; b=Pfhc7P4MZcArg11yGrewj/lZnVXysjjEe+lplk1KNl9pE8M3/L5rerrk7niR8ixM+YJUWQNYNiR0iJmvuZH5TTFvfvCUuoD6XSA6Ry4WMlCCXzBeASny1S/u/oWt2O/pqBYCQPmaoZ8KDZybbrXeen+6rmV8BMKvuSal/nHx3g7geJYTADPdwybUUvI2Bov6Nf4A2HxhjliSnY+E1o+5NDgv5QcnzhvQaocLQeM3R3cUhDOkdMx5kAoB+879CVvnK6DxbPhchzx/+M3DizZhNx7mPvLE4geqHct8vv+SEyx6vdueeK134AUmbfYvwV2bIyHm+esuFWezFsMxpho4ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TqTEpCWhNlyUvaXBb+Rnpd9foTksOS044EeU9FQSrjw=; b=o25vYWf4KBfiEu9hc6kqa1VanfD9v7m/WnL/ZkHHlrl88B+SYNiUPCTbFM3bHugDIKdLHATnl5Mgg/vrHicV6gHEnmDxGftsgnryYtUr0qBLjnxydnjSnXMci766ktSuR3DA+Fyjnh/zR/4wqPc510cBX7S87QyPDLFn0Bg1jmM= Received: from SJ2PR11MB7648.namprd11.prod.outlook.com (2603:10b6:a03:4c3::17) by BY1PR11MB8054.namprd11.prod.outlook.com (2603:10b6:a03:52f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Thu, 18 May 2023 05:40:01 +0000 Received: from SJ2PR11MB7648.namprd11.prod.outlook.com ([fe80::27bf:a69f:806f:67be]) by SJ2PR11MB7648.namprd11.prod.outlook.com ([fe80::27bf:a69f:806f:67be%5]) with mapi id 15.20.6411.019; Thu, 18 May 2023 05:40:01 +0000 From: To: , , , , , , , CC: , , , Subject: Re: [PATCH 1/3] pinctrl: at91-pio4: Enable Push-Pull configuration Thread-Topic: [PATCH 1/3] pinctrl: at91-pio4: Enable Push-Pull configuration Thread-Index: AQHZiUsv0c7YVchK7UeIf2o6Dg8HNg== Date: Thu, 18 May 2023 05:40:01 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ2PR11MB7648:EE_|BY1PR11MB8054:EE_ x-ms-office365-filtering-correlation-id: 169d91e5-4465-4290-181d-08db576252e8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lhz6PKUn9ruiIHnuC5xpKOLQLzruy8CSnB/pURpJmBsTFjJBZLSxM5WqHWkgBK8OQxJdYJ3c+IO1oBRFilwk6ADzgQgSDX6bGIaEVGQcg18qtZ8XJN+pKophf5Vw8jO48Yzlym80yQQNfcdQG/tsi/5QIcyqUU+MqA/TYIoDjTuM76NtftEQsIHs+Jzm2BCeDpp8M+joX0sYLvnx40D6yh6hDBUBRq9WqeYxnQF+1MmKaKwWv+DfvLh9ZZpeYxy9Nss/KD2xIgakDrO4xzxuaemcsf+YZ5Tf3tCBH92daZnlk+Gslp9D5ujEkzsL0PkPwOPYCl4d4hW6yKaQyBOG0Cs0nJDEQ/8SMqg7oaMnSqVg+BqOIOvIGzpJd4c8gSnHHqP33gbDDWZLsGy1JpDTYaJ09kjeBsF4jAdj3RN9ukacaVV+Mex7ncKLOXdSuGpPpcdaLGdOo/yE+4zglAT2AE+0zNvL65NCeXOZ/fMF+FgvyYnbV/RX1/i8ZtfFumBRNUlOxMTN13H3yOqjCigJm1dLA/ZH9RnOBHGkbEjqCK0L6wV6oLJ0KRq5PlSaLwv4hkdeTi1wA1tgRru3Lxwi4JgIdhZWUQ5QDKPESJAXuXS8O0jEAjbq0KmU53NzoKhJfXKSODw2+F4YyImG30O763JgxVl/RRiDSoBvnJDmwXyxfs4KdT+6Z2Z43B9+LyXY x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7648.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(346002)(39860400002)(376002)(451199021)(316002)(6636002)(4326008)(36756003)(2906002)(31686004)(8676002)(5660300002)(8936002)(478600001)(41300700001)(64756008)(76116006)(91956017)(66946007)(66556008)(86362001)(110136005)(66446008)(6486002)(71200400001)(26005)(6506007)(6512007)(83380400001)(53546011)(54906003)(186003)(31696002)(38070700005)(122000001)(38100700002)(2616005)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MTZmNVNkYUlGWEorVTRjcTZZV1MyRXU0UTZOL3RzL1FJN2NhR2tDVjVxY0kz?= =?utf-8?B?VmgxTlJzZFFpSXFHNm53UGxWZnIycGkyTVRaRitxdHE5WVp1QWgvdUxIWVp4?= =?utf-8?B?RXAvSHEvSkFQaGpFQTlKUmJhWVVhZ0FrVytpYitTUG1kaUd5WHZuTUdxTEZQ?= =?utf-8?B?L01YTTZRMFBYdVNETFhCdCs5aWdpdmoraXpvWXkzeThGcTN1dWNjNTJ3ZEVC?= =?utf-8?B?ZDdzRGpRczRRc1F0c2VOZ3hGSThDQjRYZWZVaHlsVmc3eG5YN1JZcytaQWlE?= =?utf-8?B?bG5jL3hUUmtWTThFU0V2enUzQ0JsZWFjQlZpcm9tQmFRT2MrZHY3RjFxbXN6?= =?utf-8?B?aldDTENnRitGZ1VxTzRBamhheS9FbFhRaEgzSmR0dkRPS2NGak13Q20vMGJ6?= =?utf-8?B?L2hXYjZlaTNmOWxlNnRuTyt2VWU5VHM1dUlvZjUvcnVsQnYwRDdYbDhmM1Y5?= =?utf-8?B?aSt6aWIydlhMbm1xaGxzZXYzVURublFOYjVidFVRTkYxZTdPR0FBMXc5aStz?= =?utf-8?B?V2J1bVU2QlJJbnllN2IwTWZhbENwdFVLQTlwNGhDUEV6c1NBSUlXcUJjWllU?= =?utf-8?B?TjRXdWd0S3J1ZlQ4NzVxa1VaRmJ4bVZzUUJKTUpjcEhDRXBTeHdhVWJzQ29v?= =?utf-8?B?bjAwT2NnbzRNSm5uSFhuUHR0SFhVNS9najJETkd3MUdMa0hWREpsMERlbXBU?= =?utf-8?B?eEd1azFzRzFROEVCSG4rREQyRDN1dmsyYVRQTG9iT09HRGlGNktzOVZXN0Rp?= =?utf-8?B?em12Sys4ZGNxbXBPdzZpM0tld3d1RmdVVFdqdk1qYXoxcC9EVjBXbXIyZm9P?= =?utf-8?B?VDJpazdZZzRueGdNTkFGL04xRmVsSjVHVHVmMXlNL2FlUDIxMkpGZndNNnNN?= =?utf-8?B?R1g4aTVCdXg1Nlp2MVp5ODVQUnJCN2JBUzBFeVpoaUhEYWppYUVscTlNTWUx?= =?utf-8?B?Q1ordnVkakJkN0ZpT01Ud2ZiRzRLL1hITElWSU1VWC9DU081LzVWS3lrZ1pM?= =?utf-8?B?Nm5CT21vd05UaHpoWndlSGlxUCt5UTZyUzhRZ0pEZk1pcXhhWlFiSDZNNys1?= =?utf-8?B?b3V2Q1JMd0x2eTlxZVlpcG9LQU5zZmViRGw3cjhJQllNa1NCUXNvTjJHcm5q?= =?utf-8?B?TEFxSFBEWlpqTlN5dzhKZTd5Z3ZVZERFcnROM1hEVERPbjBwVzJ6THgyTzkz?= =?utf-8?B?a0srbkNHTVZ2NnltREp6QmYvcGwzdThoNUN5VG1ZdFVKcDZQVlV0K3NLVzVX?= =?utf-8?B?WVg5L2lLZWZtbWVWS3FOOC8zNFFOdk9hSmhWK2tDRGxLT1BJTGNxMG5yVlRT?= =?utf-8?B?RWVocGlXQ3l6OGN4V250cklFTU9hUHp6VHlzZzJOWW1VYUlmanhnRDBuQVhT?= =?utf-8?B?SjR0Mm1qQUx6ekc4L0ZFK2crblFQL3JYbUtJcUlmL3dmOWNkTUFTL2JGU090?= =?utf-8?B?a1dVcDFVNURHNWRsemx6bnVxL0gxNzlib0NNUUNEdEpValBnRGtNQXgvZUw1?= =?utf-8?B?amV4VFJYQzdISVJjTnp2dVg0bS9penRtRE5YRlBYZnJQWEowb29ibWRlcy96?= =?utf-8?B?dnBmVTlyUmNQNncxd2psVGdqNHVVdWx0YzR2ZzF4dmZYYWxabjB3cDUwYjZ0?= =?utf-8?B?N1oxbUJWLytHMnNGVElwMWd6OGJUSCtVdk1yMG1hWlRhdkJENnhUUXdaMkNs?= =?utf-8?B?a0doSyt6N21XcDhCMFJ0RHduV3NtMjlhWXZ3Qm1KYzcyZ0xzUHRIb08rei8x?= =?utf-8?B?NmpHVGFMbmhFZElzaUNDbDJRUEo4cHJYOURXK1pEZVlLUDR6Qkt2c1RadTBV?= =?utf-8?B?SkhLTWdYYis3OXNmUkN6SDZ6enFxOUh4SGNYbHVRcmI5dmluM3Z1WWlFcm85?= =?utf-8?B?MzhIN3NsVis4clhGSGFEdTRYZUNXeDlMbzh4YUtrQk4yOGZ0Q1ozdnlFblgz?= =?utf-8?B?cWZoVjBldWJ1c29TT0VRZkxqM25HYUNyK1cvK0k4Mldod0pHNGNPZ25PWWZH?= =?utf-8?B?MkRidXd1NjZwcFlJU01iMC8rRE1DZzVhWm1ycXN2NWtZMzhnSURVazlkSXVw?= =?utf-8?B?blYzTTZ2Qm15TmtqMTM2QkVFTkdFclZZdW1yL2J1Q0hpb3Y1SG53QzJtdlYv?= =?utf-8?Q?7H9MgS9BW27fSqriGYhiXdbkL?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7648.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 169d91e5-4465-4290-181d-08db576252e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2023 05:40:01.1847 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AfvT+wnuenEBjUd9BZLRNAQAF7qQXJzM1sesiwgFVAHwlAbb9y+44W+2BTmSRw0oEVKcyrCb2E08qOgacaory0CTfuqtyjn8e+Q4DXTWDYw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8054 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_224016_847660_34D6991A X-CRM114-Status: GOOD ( 20.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17.05.2023 14:54, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner > > Enable push-pull configuration. Remove integer value argument from > open-drain configuration as it is discarded when pinconf function is > called from gpiolib. AFAICT it is still taken into account when passed tough drive-open-drain DT property but at the moment there are no device trees using this property. > Add push-pull do debug and get functions. > > Signed-off-by: Ryan Wanner > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c > index 2fe40acb6a3e..3c39d62bbc3c 100644 > --- a/drivers/pinctrl/pinctrl-at91-pio4.c > +++ b/drivers/pinctrl/pinctrl-at91-pio4.c > @@ -762,6 +762,11 @@ static int atmel_conf_pin_config_group_get(struct pinctrl_dev *pctldev, > return -EINVAL; > arg = 1; > break; > + case PIN_CONFIG_DRIVE_PUSH_PULL: > + if (res & ATMEL_PIO_OPD_MASK) > + return -EINVAL; > + arg = 1; > + break; > case PIN_CONFIG_INPUT_SCHMITT_ENABLE: > if (!(res & ATMEL_PIO_SCHMITT_MASK)) > return -EINVAL; > @@ -827,10 +832,10 @@ static int atmel_conf_pin_config_group_set(struct pinctrl_dev *pctldev, > conf &= (~ATMEL_PIO_PUEN_MASK); > break; > case PIN_CONFIG_DRIVE_OPEN_DRAIN: > - if (arg == 0) > - conf &= (~ATMEL_PIO_OPD_MASK); > - else > - conf |= ATMEL_PIO_OPD_MASK; > + conf |= ATMEL_PIO_OPD_MASK; > + break; > + case PIN_CONFIG_DRIVE_PUSH_PULL: > + conf &= (~ATMEL_PIO_OPD_MASK); > break; > case PIN_CONFIG_INPUT_SCHMITT_ENABLE: > if (arg == 0) > @@ -948,6 +953,8 @@ static void atmel_conf_pin_config_dbg_show(struct pinctrl_dev *pctldev, > seq_printf(s, "%s ", "debounce"); > if (conf & ATMEL_PIO_OPD_MASK) > seq_printf(s, "%s ", "open-drain"); > + if (!(conf & ATMEL_PIO_OPD_MASK)) else would fit better here. > + seq_printf(s, "%s ", "push-pull"); > if (conf & ATMEL_PIO_SCHMITT_MASK) > seq_printf(s, "%s ", "schmitt"); > if (atmel_pioctrl->slew_rate_support && (conf & ATMEL_PIO_SR_MASK)) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel