From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BB32C54E5D for ; Tue, 19 Mar 2024 06:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NHp17qkmzwObk7stMAfC2dvFuhnZE4soTlLJCugjCvs=; b=uGVlUKnTmXqqOn oxhYd9siLk8N9KaTRpvqXsLMih9hqpqZ2gNLlsQ/ofkC5ovt7Awqm1xPbiG6JaUa1sUhYTfzff2Or 7nJpNX7n4ceiO/QUxVQph6h4FWWQWbH+UFVYGCBrR2Ea7hkroPeL6fF7wHJTQfCP9Vt2XpGigBeSs Dwk96PCGqAOUO/4sVGPDGG7TfHHE8tsHCo4XdejbZYY9rzJpjgjig6kozoSVs/eoLHX6KLKEjdZFS 443FysMMCWTv6FKkON291G4+WVH0StbN+eru8uDG43ICxah/+ABC6wtamzL3qErL5nv96oQu22fUk Rrza8nWZa3IZGdYscEYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmTBm-0000000BYKQ-0Gp2; Tue, 19 Mar 2024 06:43:10 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmTBa-0000000BYG0-25Lr for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2024 06:43:07 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6e709e0c123so2145806b3a.1 for ; Mon, 18 Mar 2024 23:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710830576; x=1711435376; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MekR1vkf79zx6hDhHO4dw0XGgAfid+zxEfjnfq9iFoY=; b=kHOUC+0XS3ndPFNjy0dUNSM70iAmGMbzYAaD8699SALtTTgWxbIyxT5vbOIKjp/pqy +9iB7DEHracj4W/9IAf9LzhYkIiA5KpHQwFN2W7Gad780t9qOgtBueSPhiF/S76sDzOI toK+cQySffACS255l9j5SRNYFlB7BhYbgJea4w4RU/JOImHJIpgekwR8XD9ebpmBrgax RDv1fZ1gZtTwBUSRzzPb4B58Hynbqc/7WOTdvEdbp6a9g9bbUM+FKLlL76g7DIqMy5ZW IF3BqisDdpVNIs7VjO6B1lITt5xdZbUIVnhQOuHVuxi6iNjGPntPlGuWQkM3lI0uoBXX ctQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710830576; x=1711435376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MekR1vkf79zx6hDhHO4dw0XGgAfid+zxEfjnfq9iFoY=; b=eZmt0u2w9/QXDjkBECP+UkRtGKNZfugnq0nSG2jmGuCkIMXrfWy4Oof97Ibv3jeNMg Y4LFPbsvjSASPkpKUSfOoyfdOohyzuH4kw9R2gBGaB+qC71y9qRWHiX6/tVdvhUW0bGY DwmsjEWkopoVzOsgw2IphIE62ckLhBXdNVHIEaj3tNv8ZbW46415/vQtlKollPfp3M6d yXidvlIntvSc3JSVucBmbLzYQNDAZVKR9LsXB42plzaLAJnbJ9F2TC5KyBoZYI1oNjqP nQsaf0iSbI/xooRXCodU6vj0kg5RAwQeN7nKcYNv5cx4cENdxKjEaUjvyEeKtDgJxhjW zibQ== X-Forwarded-Encrypted: i=1; AJvYcCXR+tU9Nmp6/MOl7INrY+5YOvre+dt03B4eUmcYU8xlgDZpNnA8b3mxtiOEjlGH4vSEK8yt8ZjslKs/YrUGFYdo54MViyJ6idYBA3C1EuU250TUgQY= X-Gm-Message-State: AOJu0YynOUvY9CyNsSfTXNYUO0EALD4P63z/5wrA/DL4yVyh07awCmau 7VR9qVYJVxDXiFz4ErmEQJxdFUSEOlwVdu9sBiekmnQ+73tpXOL7 X-Google-Smtp-Source: AGHT+IELy+WEtoYME8bn4yLFQ+wqr8qOT2Cs6dmJHNy7S8i5urAB8y1ed9hdTxndDnXa/NFifvMK5Q== X-Received: by 2002:a05:6a00:1ad3:b0:6e6:4679:fa8b with SMTP id f19-20020a056a001ad300b006e64679fa8bmr2033581pfv.4.1710830576427; Mon, 18 Mar 2024 23:42:56 -0700 (PDT) Received: from [172.16.116.58] ([103.15.228.94]) by smtp.gmail.com with ESMTPSA id i3-20020a056a00004300b006e56e5c09absm9215698pfk.14.2024.03.18.23.42.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 23:42:56 -0700 (PDT) Message-ID: Date: Tue, 19 Mar 2024 12:12:37 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] dt-bindings: misc: Add mikrobus-connector Content-Language: en-US To: Krzysztof Kozlowski , open list Cc: jkridner@beagleboard.org, robertcnelson@beagleboard.org, lorforlinux@beagleboard.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Vaishnav M A , Mark Brown , Johan Hovold , Alex Elder , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/TEXAS INSTRUMENTS K3 ARCHITECTURE" , "open list:SPI SUBSYSTEM" , "moderated list:GREYBUS SUBSYSTEM" , Vaishnav M A , "Russell King (Oracle)" References: <20240317193714.403132-1-ayushdevel1325@gmail.com> <20240317193714.403132-2-ayushdevel1325@gmail.com> <1be08004-fe29-4e0b-b0c9-7cc7af15d0b0@linaro.org> From: Ayush Singh In-Reply-To: <1be08004-fe29-4e0b-b0c9-7cc7af15d0b0@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_234259_261104_4155D041 X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/19/24 11:33, Krzysztof Kozlowski wrote: > On 17/03/2024 20:37, Ayush Singh wrote: >> Add DT bindings for mikroBUS interface. MikroBUS is an open standard >> developed by MikroElektronika for connecting add-on boards to >> microcontrollers or microprocessors. >> > ... > >> +title: mikroBUS add-on board socket >> + >> +maintainers: >> + - Ayush Singh >> + >> +properties: >> + compatible: >> + const: mikrobus-connector >> + >> + pinctrl-0: true >> + pinctrl-1: true >> + pinctrl-2: true >> + pinctrl-3: true >> + pinctrl-4: true >> + pinctrl-5: true >> + pinctrl-6: true >> + pinctrl-7: true >> + pinctrl-8: true >> + >> + pinctrl-names: >> + items: >> + - const: default >> + - const: pwm_default >> + - const: pwm_gpio >> + - const: uart_default >> + - const: uart_gpio >> + - const: i2c_default >> + - const: i2c_gpio >> + - const: spi_default >> + - const: spi_gpio >> + >> + mikrobus-gpios: >> + minItems: 11 >> + maxItems: 12 > I don't see any of the issues resolved which I raised at v3. I think > Russell pointed that you do not have EEPROM and that some pins are > optional. You do not allow that. So this patchset does not contain any EEPROM code. The bindings describe mikroBUS connector and not mikroBUS addon board. While it is optional for the mikroBUS addon board to not use sone pins (aka NC), the pins still exist on the connector on the device side. It is not optional to have pins in the host device. > Plus I don't see him being Cced but he had quite detailed look and > comments at your patchset, so *you are supposed to Cc* him. > > I also do not see Rob's comments fully addressed. > > Do not send next versions before resolving previous discusssion. I apologize, I thought he was on the list by get_maintainers.pl, but it seems I was mistaken. I will try to remember going forward. >> + >> + i2c-adapter: >> + description: i2c adapter attached to the mikrobus socket. >> + $ref: /schemas/types.yaml#/definitions/phandle >> + >> + spi-controller: >> + description: spi bus number of the spi-master attached to the mikrobus socket. >> + $ref: /schemas/types.yaml#/definitions/phandle >> + >> + uart: >> + description: uart port attached to the mikrobus socket >> + $ref: /schemas/types.yaml#/definitions/phandle >> + >> + pwms: >> + description: the pwm-controller corresponding to the mikroBUS PWM pin. >> + maxItems: 1 >> + >> + spi-cs: >> + description: spi chip-select numbers corresponding to the chip-selects on the mikrobus socket. >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + items: >> + - description: chip select corresponding to CS pin >> + - description: chip select corresponding to RST pin >> + >> +required: >> + - compatible >> + - pinctrl-0 >> + - pinctrl-1 >> + - pinctrl-2 >> + - pinctrl-3 >> + - pinctrl-4 >> + - pinctrl-5 >> + - pinctrl-6 >> + - pinctrl-7 >> + - pinctrl-8 >> + - i2c-adapter >> + - spi-controller >> + - spi-cs >> + - uart >> + - pwms >> + - mikrobus-gpios >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + mikrobus { >> + compatible = "mikrobus-connector"; >> + pinctrl-names = "default", "pwm_default", "pwm_gpio","uart_default", "uart_gpio", "i2c_default", > Please properly wrap your code according to Linux and DTS coding style > documents. > > > Best regards, > Krzysztof > Ayush Singh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel