From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68E87EB64DB for ; Thu, 15 Jun 2023 05:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ce/nkBvGSMKhVSsL0JliJ0FArkR2wvtIdSTpbywDYV4=; b=TkNQzC3ISy2MBt o/uBYFem1EBF7vKGub5oG375IOi8fn49Ikzt5RTgCZHuwCxrlUVxoLh9wJi05BGeKFpheiJERFsYl uODZABx+usEK0eS5siuom223C3vggCEfiEU75bSOLQgUbnNgNVNOh1AMQ2N4U/Ad43HWC/OhzF4a7 G9JEB35QeyHCiE3kxOGLKdR7kA3VRaYbNC/eztSRqnGN58TuGc+xbWpHV0y2JE77qw6kM2O6kNlEP R9WdohC+eFtXD291NTasNZv4BOO0TAZkqqREsqMqHBrypFipmCqSBMFVL8bzo3Dnb1hPxvoPsekKD r1QDHBLsdCbJXmRzkIcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9fuY-00DmEA-05; Thu, 15 Jun 2023 05:52:46 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9fuU-00DmDa-2Z for linux-arm-kernel@lists.infradead.org; Thu, 15 Jun 2023 05:52:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686808362; x=1718344362; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=C7aF0yWfV1s1VE1VWExjYLax2b0knlBo4p9+gKyeABY=; b=01G1cyOk+Sxw+3XJAfaW6NNgPXhs/IVke/B9WOGMciUU6keYK60DJ+h9 2PN0WtT+A6rjCTWepaO/Ot5gwr5wbekVqkWuYrYeY1mVfSh+dRMRrA+RF TM/uAtZuW3bC8/J17WwWbm1aMYBCQyItRf9ifoqat6o1NCCvqd/Y3/ag7 Y3JXxdTt8KH2LeniGV0GU0v8RwDw2+JvBrxJN4pYWp+xWBb87fvKH9PzP UyQ7HCe3WS/ZGvOBQ0RtmP7fa/OnlYA27DwXIbIwQt3RZjLrrYzlO9bMF hiixdys15l2gI3CLuUnsG3uohSIk0h58FM9T4d+9/4bhq0+9QwcVtN5ys A==; X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="217955968" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 Jun 2023 22:52:40 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 14 Jun 2023 22:52:33 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 14 Jun 2023 22:52:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c+akLWvHGV9Eplo3ptX18v1E/h67Y41HMci42yK9Jikv1zhksUZSIy6le7CLi3BpsL0jGcSr0nTCXiyYyfycYZbRXLHXkNgXFzUWCPWVoq99JkB1tBXR01oh5+lf08Wb5wvoLi8EAzI0fyVcR+4FQS8Ck/iDkrKAULYW6nTL39I+WhNipwei3TgHXBYio6rShazHy3jEeCs5pLbw9e01xTLqXlSqQ2rSzJ+b9wIUo0+UF4ut0xpG1N+D7PfpPTca/ElrEJwc3mPG8FIcEei4JC+OG2EwKpkYxl7/eqPPf7Xi5iWt60iFetVKry0dHMvljdDMPssrwRDClbPo/bibHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C7aF0yWfV1s1VE1VWExjYLax2b0knlBo4p9+gKyeABY=; b=Wn5RtAfPoVOHwxdxkh+yj0eo2zWxGvwch9nBXgXUS36H0MOGgQ87Mv5IxgLGUCWBBeUuBBhZZRBUZvROyqTw8C9LBmz/m4OLKuBiCAw08IrRfWO82BVW6w6tSJrWuvJ3axcWxxJ4lL9UmMs1aJ5ehXM2pNVYynjlK3CCWxAv4t3yPyV6blYiXK8hrrgf24a2jKoAaKVk0MHMA3zfSS3Ugdzmn4+v2q1YfMZxkatv9F1QLBpoaPQhA6Rn4ivfB6ERHXLhAAWNf9fHQ5J57XTSBdT37JgJ4HfnuRmkUL25rld5AB99w2q6HgF92aPndRrZkEx43rOS889DEY5dn4/EmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C7aF0yWfV1s1VE1VWExjYLax2b0knlBo4p9+gKyeABY=; b=vYhCajh6lb5N5tBpc1VnAtl8fziK95uxtfyvTeyf2qmqJBgCl2ixeJ9ydddC9jPv2pFYs7eaYKeIYUzXpdc9lQ6lz1uhtOQrLH3VkxSoN++Eni1QxS7sNpPewxvty1RivGnzAjMjdsLpWQ08+ELhhrYAicHlqiF8DfuFTsuLyR8= Received: from IA1PR11MB6193.namprd11.prod.outlook.com (2603:10b6:208:3eb::19) by MW4PR11MB7077.namprd11.prod.outlook.com (2603:10b6:303:223::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.26; Thu, 15 Jun 2023 05:52:31 +0000 Received: from IA1PR11MB6193.namprd11.prod.outlook.com ([fe80::fae1:9490:ead6:1009]) by IA1PR11MB6193.namprd11.prod.outlook.com ([fe80::fae1:9490:ead6:1009%4]) with mapi id 15.20.6477.028; Thu, 15 Jun 2023 05:52:31 +0000 From: To: , , , , , , , , , , , , , , CC: , , , , , , Subject: Re: [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC Thread-Topic: [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC Thread-Index: AQHZncWR2rtrJdjaJEKmZ/pOm5WbTq+J3RiAgAGCgQA= Date: Thu, 15 Jun 2023 05:52:31 +0000 Message-ID: References: <20230613070426.467389-1-manikandan.m@microchip.com> <20230613070426.467389-6-manikandan.m@microchip.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6193:EE_|MW4PR11MB7077:EE_ x-ms-office365-filtering-correlation-id: 467745ad-941f-4ea4-41b3-08db6d64b57e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IBEW70U5QxuspkwT3LdsXRA8qb+u0thhHCpELb7xxU/J9Z4DhwX+SBJafjbZt5JrYGoFC10Gj3Kx87AdmLs7y8JyGkU4RNy0hZlkIOL0S/H9YPrL6OVsIU0I0prevCeUYDJD0Ig1YXf7cx4gGs0PzO2Ahcn7XzQMn5ci1o1XJwrXRX0+lEl1V1g4UHMTL30dFLO7hVEPkgSKRBv/Ixo8KCwXxEmf6aV+UAuC+z59QVQOMsrMR+WjbM+v7+PhjC27W1AMZQZZxgPDrAGfyz5Lc8htx2wPe9/uBt9st7BXIT5qnZT7bL8eG7xkU7fgelF7cLOL+nRHgCD/mS5oxqmLUonOrVmEBz0oeKumArUuR55otmyNkigr9GQBaIBt+MWYTTcucrf310oS0E/4slsVViThLUteLHIvDzv+Bdnxcimr+cjduzKixPxlYrUSSj1KxFMQ9YwtFLPn2OZSu9Qvj4eePcKVbyPcA/eNflhQDfn79a2mSTAVufMko2oJXSMn/TUUS6NcSPlBqnyngv6bk7fk/ownwSJ2PoEek7GIpcrHUwChgrmpX9pJSD8TzBUMB7g56cPZWkF4Y9Y9+Gx+9uUKyvtbYXzvKv1KphLo0DTrowy6qelf9jMLegG81s+lPuBGhEsWM+zO0z8o2d5W99obiUYez+vSrmV4pZ4YEec= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6193.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(366004)(136003)(346002)(39860400002)(451199021)(2906002)(41300700001)(7416002)(5660300002)(38070700005)(8936002)(8676002)(36756003)(86362001)(31696002)(71200400001)(6486002)(107886003)(478600001)(83380400001)(186003)(26005)(6512007)(6506007)(53546011)(64756008)(66556008)(2616005)(31686004)(66446008)(66476007)(66946007)(76116006)(91956017)(921005)(4326008)(122000001)(110136005)(38100700002)(54906003)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OENNTU5uNXhHTm5GcnhUNW5QSUovRGJ5YkhxMVUyS1VUdEFFNDMyT0ZFRUJz?= =?utf-8?B?blpwWDRtTjFTZDVRenJ0MHFJYUZqRjdsNTcxM2lCL2dQSHpKRGpLNHg0SERD?= =?utf-8?B?b3QwN2lIUkVDaFdabjBrQS9sZWRZMnNjd2xDZndFVEpiL21pdHJibDRBQnpV?= =?utf-8?B?TVZEQnUxSXZvQzdPcGFkeFl4aU9DZkpFa2V0N1hDaEpzb1ZhRlFrUHJid0VN?= =?utf-8?B?MHdvUnBiWHNYelNGRVJ0Z1lqRnhYcUlPclc4Tk5qVG13eE1PZlpGeWwzYUhr?= =?utf-8?B?d1hGbld6VWF4dlcySlhOZW9Vdk1GbUdNbkZOUXl0a1FuZktRSHlSQzE0WGIw?= =?utf-8?B?d01ZNDF3TzkxQktoQ2Z4TUU4bml5MUk0YUR1RDFlRlVCQ3ZYN2gvc2k3YzVS?= =?utf-8?B?dElEaFF0eDN1aTdkb25QU1gwTTUyemM2eXVaMlJmSzRQaUd5K2NRSWM3Z0Ur?= =?utf-8?B?bU53eWpQUTRVbkZDSStDbWpXaGxSZ2x1VkVVbVRqSXkxamhVMFBUTmNDbnpm?= =?utf-8?B?eFVLcFRzSTh5djM3MnVKRExmWXRJOXBLVEh5aHlyT3daOERnV3JYbWgzTzJH?= =?utf-8?B?REw5aHUrNEJ3UmlFNTNQUGxudjN0SU8vOXlSRTFKY1VGaHJqdjNaYjFocW01?= =?utf-8?B?czJkQXlxTFRrYTR2aHB6bmoyKzNMZ0JGbmkwcDVPT3d3bkpzTFdKMGc1Wkhh?= =?utf-8?B?RVB5QkJxdGVENFR4djhEUlRIcGczV3Z0WmZtZlcrTVFsRWZ2SzRqcDdvUWUw?= =?utf-8?B?WUJiRkgyeGJNaTFIQlZmUlNZc3IvVytOTEp1TGhuWVNrajkvZE1Da2NnQnJn?= =?utf-8?B?ejdHQU9vZ3NXNUpEMU1icE9xVllFUHM2MXpmOSt2ZE1uUm9yZkNjSndEb1NY?= =?utf-8?B?TzE4MUMxUmJVc29wc1k2cURjd1ZVcmkvdlZLaUtLMUluOWxaVzZBM3J3RjU3?= =?utf-8?B?OXkza1F4OVB0VnFabDNsQXV2cVNXK1FCbFBNYUtud01oWWE2amNNS0EyQitr?= =?utf-8?B?cDJWTFYwdXREU3dGaW9qRE9hNm51Skx6bFVoQjdZRkY0QWpiNzV4MkdTcDAr?= =?utf-8?B?RlBOMlI0a2VlSzVJeWZ3cEhJeXF3QTFpK1R4SGV2LzZZQmpsNXBDRE5PMXF1?= =?utf-8?B?dnVZQ29CRWRxWGNLNUpCdTM2QmpHKytHU2VuRURmNkptQXRtZUM0em9vRUhj?= =?utf-8?B?alZRTzhqZUNZNmNINmJSOHR4VEtTQUI3T0kzWDdsSlBaRTdISEhUbDhKeWN2?= =?utf-8?B?cmJrYUM0dGxhVUMvMXdwQmo5VVFka3lzT3dZUGVnc0wzelNteGFJNEFKNk9w?= =?utf-8?B?d2RiZkI1QjNFbFY5UDErbkNEM0svK1FtZ1Z5eDNWL3V5ZFRCNDE3UUdObGVv?= =?utf-8?B?M0JLOFIrcmV2WFVXYjB0YzNVbkQyVHpWTmVLTFJGeTdoMXlscERJNUNPMTJm?= =?utf-8?B?SDIrVEQ3b0hscXo5QjBibVozQklVNFhqSW1kNmlmTDRIS2FTaE15cXUzWEdp?= =?utf-8?B?ZUN1cGgyZkI3MVJURVJpMkFTUGxMTkdsb0s1TDJIMEllL012RG1Wak55Wk91?= =?utf-8?B?amFOVDNPd0plM2YzdkM0TWJucklpcytDTUliRFhNc1dodWJsaGRacHQydUND?= =?utf-8?B?aFJsd09xZ2FCUytRYlVCbzR4TWdrM09SSkdGbko4RTJSMm02U1ZVNW9BWVdM?= =?utf-8?B?eWhZTGRDRXhGYVJrNUdsSnBtRWVtem1pVWZmSlZOMTlFMk5YbGtBbmRVNEtZ?= =?utf-8?B?YXFxRk1XV29YOG41NFgvM25mYWtodTdKb1B2eEYxeUtCUWFHVVo1WWZXeWRB?= =?utf-8?B?eXB6MUJtMEhVUnRuZEVndkhlaGt5SWdFTWFRTlUvb25qeVFkVHN2c1VQaWNM?= =?utf-8?B?UXN2UmQ2ODdRRWdMY0lpc1UwR1ZOK010ek43YnN4MG01eENOV1AzSHFpbjIy?= =?utf-8?B?ejNoSDJqSVNjdGVQbnFHSUJwT2huWDZxenRheWNudWtQd2MvUWRCRU4wSjlI?= =?utf-8?B?Sk1VekpkalhGRWJLdlhPT2ZXQVJOVy9Ta2pPOU55emx1M2RtOE9UL3BTeTBL?= =?utf-8?B?YlJLajkvbVl6bVBHcXJZaDVmVE92VmV5bjFCVWNGY3ZOR0IvaEYzemZ0a2N6?= =?utf-8?Q?TcnPnnkcF48uIh3J2ZmThNE3+?= Content-ID: <6381083E74C32F41B9B972FF04B67E52@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6193.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 467745ad-941f-4ea4-41b3-08db6d64b57e X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 05:52:31.1874 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7wnb+9HAsTuCWTLhkoWbfYGV8h6g5MFQ6XzBsd7jwRnZOx8K9ZMVSW2BSeIqrtqAmjoO4jIKcCkxftBvZ+Bxa48R76t6ralKgJwzaU6v4Pc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7077 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_225242_873736_84995356 X-CRM114-Status: GOOD ( 17.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/06/23 12:19, Claudiu Beznea - M18063 wrote: > On 13.06.2023 10:04, Manikandan Muralidharan wrote: >> From: Durai Manickam KR >> >> Add compatible string check to differentiate XLCDC and HLCDC code >> within the atmel-hlcdc driver files. >> >> Signed-off-by: Durai Manickam KR >> Signed-off-by: Manikandan Muralidharan >> --- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 +++++++ >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 1 + >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c >> index d7ad828e9e8c..fbbd2592efc7 100644 >> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c >> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c >> @@ -761,6 +761,13 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) >> if (!dc) >> return -ENOMEM; >> >> + /* SAM9X7 supports XLCDC */ >> + if (!strcmp(match->compatible, "microchip,sam9x7-xlcdc")) > > This could be avoided if ix_xlcd in added in driver data. Sure, I will check for the feasibility of the code. Thank you > >> + dc->is_xlcdc = true; >> + else >> + /* Other SoC's that supports HLCDC IP */ >> + dc->is_xlcdc = false; >> + >> dc->desc = match->data; >> dc->hlcdc = dev_get_drvdata(dev->dev->parent); >> dev->dev_private = dc; >> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h >> index aed1742b3665..804e4d476f2b 100644 >> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h >> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h >> @@ -451,6 +451,7 @@ struct atmel_hlcdc_dc { >> u32 imr; >> struct drm_atomic_state *state; >> } suspend; >> + bool is_xlcdc; >> }; >> >> extern struct atmel_hlcdc_formats atmel_hlcdc_plane_rgb_formats; > -- Thanks and Regards, Manikandan M. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel