From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02ED4C433EF for ; Thu, 13 Jan 2022 12:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AqB2V6oFnSbXj6JQun7k4w26OSv1fqWZBLsbVNxCFuE=; b=g7hf5QTBCjeD4V 28MwYTeArtswo2fIe4GtrXdEhXYzITk4MqF5TpxrF2L6NcKSld3osbSfDe+lLjR3qdhJsRiPQuNTd rFHTEMa8HDliHhZGMZ1u8vHqF+4Jhm17qRtCxbxVu3WPUAGAx/nPm564s1hPUZza8pg2xStwCKWFx vcf+L1apZC72mLMjk1CNrvfKZC+COq7BGx+oNkp1ee3pk5tz+rMcn56af8xJKlyohXs4ADviDH1he u6yz5rvGYPulxhKuJdl2+JuMJcq4fO/7131sSu+0uSqDK17wgzSKNemn6fpniZUMvs2eE2TzExo7F VBN+nxEQ6yDilyboGQOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7za0-005vrG-Ha; Thu, 13 Jan 2022 12:51:49 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7zPD-005sNz-7q for linux-arm-kernel@lists.infradead.org; Thu, 13 Jan 2022 12:40:41 +0000 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id DE5C53F1C7 for ; Thu, 13 Jan 2022 12:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642077637; bh=NtF9Qcv8dCyv4imQqdPZ0gphBbiJgf6BkMwibu0qdek=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FylfRzFpYWYgd4WO09AQsPJqT5Q1Ge7coeHBZga3wuxwXc2pUqBtINPpHyQkh5mbF Q2hmNQOuK7lk6TAJ0wVYyPnJCmJ3PRV2QilTTkRgDU8Xn6oPKKTYP/dHXw3FcT7wvV KgiP0gTBbg/AcgEGSwu4FTriqdMU1Nl46Wcql9FomQViOjrThtg1EBARDEJndnH0nL LlZNysBO3TuD9KHm52N6FAr8Qhje1+5ihw0yCJ5cL7+LEeSr3gF3Vj0xvr2zzu439J 0ZDTKrNbv53U7UhsyUCNQu1Q7yp4/VLJgNppWQuEtA547Jx3Y75VIaTzk8leaS+2yg MqsxOSBIo5sqg== Received: by mail-ed1-f72.google.com with SMTP id ec25-20020a0564020d5900b003fc074c5d21so5164985edb.19 for ; Thu, 13 Jan 2022 04:40:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NtF9Qcv8dCyv4imQqdPZ0gphBbiJgf6BkMwibu0qdek=; b=t6b9ys2fxtYonB0A+dnEM4nwaN1o2XDNEjzYuhh+IySPRafaeo1hAn4rXENk6+EjTZ dBMYswtcJo/rTzgrkNg2HqTvJYQMI8a/7iIEHixwk8HxGHmQZy0MKGtNd3ImkfYtg7+Y /ZC/tS6qQa+DTRFQjxQIW86y3B8moB/Fffr88ZGgDxIdDX7CtiN9n7nqHJwYejicSUnF vOrMoY1ip+icOi3p5Q7jSeH4AxancQ7wilwok3QaWjFLxejaJK9OYQUxrwiUiKenMsXR 93SXFaYbzBP2HRngaQbNSpt2SQ6bWkfxpRYj3bQvNXrX5guDyRcyFwJ7/Q6TbIWH0HIY 7qJg== X-Gm-Message-State: AOAM5307wpnAdcK9uAzgxyicpaOJXGzF3/BKwvve3rvsAJcGnFfGXHYo OL0TotTujrQqhOneNc5jOE9+Blg3zD6A8U/kuDV+A723T7hmkdMrC+ETEMmG77rNdmO25S4/qSr Vqx+I22M2YPfj3Ueb51QOT9c6RAhxdJEXBPxLe1AbDUd5y64FGagO X-Received: by 2002:a05:6402:655:: with SMTP id u21mr4010418edx.30.1642077637574; Thu, 13 Jan 2022 04:40:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJzysO4hAvoMYoJ/ruIH66z8VzH4bfZ21Ozb1u+/RRfHvZ0YP4DJm75J85RG/HrmE+6HlqV7UQ== X-Received: by 2002:a05:6402:655:: with SMTP id u21mr4010406edx.30.1642077637409; Thu, 13 Jan 2022 04:40:37 -0800 (PST) Received: from [192.168.0.29] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id sa13sm858440ejc.28.2022.01.13.04.40.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 04:40:37 -0800 (PST) Message-ID: Date: Thu, 13 Jan 2022 13:40:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 01/23] dt-bindings: clock: Document FSD CMU bindings Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-2-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220113121143.22280-2-alim.akhtar@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_044039_619396_2DA6D8B9 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/01/2022 13:11, Alim Akhtar wrote: > Add dt-schema documentation for Tesla FSD SoC clock controller. > > Cc: linux-fsd@tesla.com > Signed-off-by: Alim Akhtar > --- > .../bindings/clock/tesla,fsd-clock.yaml | 212 ++++++++++++++++++ > 1 file changed, 212 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml > > diff --git a/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml b/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml > new file mode 100644 > index 000000000000..58f341e5004d > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml > @@ -0,0 +1,212 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/tesla,fsd-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tesla FSD (Full Self-Driving) SoC clock controller > + > +maintainers: > + - Alim Akhtar > + - linux-fsd@tesla.com > + > +description: | > + FSD clock controller consist of several clock management unit > + (CMU), which generates clocks for various inteernal SoC blocks. > + The root clock comes from external OSC clock (24 MHz). > + > + All available clocks are defined as preprocessor macros in > + 'dt-bindings/clock/fsd-clk.h' header. > + > +properties: > + compatible: > + enum: > + - tesla,fsd-clock-cmu > + - tesla,fsd-clock-imem > + - tesla,fsd-clock-peric > + - tesla,fsd-clock-fsys0 > + - tesla,fsd-clock-fsys1 > + - tesla,fsd-clock-mfc > + - tesla,fsd-clock-cam_csi > + > + clocks: > + minItems: 1 > + maxItems: 6 > + > + clock-names: > + minItems: 1 > + maxItems: 6 > + > + "#clock-cells": > + const: 1 > + > + reg: > + maxItems: 1 > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: tesla,fsd-clock-cmu > + Nitpick: Drop the white-spaces between if-then. It's easier to spot the if-blocks if they are together. > + then: > + properties: > + clocks: > + items: > + - description: External reference clock (24 MHz) > + Drop this whitespace as well. Rest looks good to me, except the discussion about the compatible. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel