From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69024C27C77 for ; Mon, 17 Jun 2024 08:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gOtB6hLjDe2q1k9n9j8GrerUfufcZavMvVvl5T64NeQ=; b=Lfv3eFDiOAlTJ7cxJtyM9jO6Q1 /Sc92r/0EbVT2qZCwOi3uNLzFzXmQCYBnnhJwGrFOiUa2NFadzPrTduSuJebtJZCJq39Fap2RSsDL n89qqeETeqCa6jvnQZlURx9Pu3z0Nbf72EsBQExGOCgAfDHlAxGHJVazewv38orULlANIPX/R3cE5 6cCVa3mioZzuzEMh6SnIunsn26yyrkahNMuYB8okIAwZqdJfKFKtRwyJCsfEspVjCeVW0vUMRLO6J 1HrCaAFEF6m2LnRuwB51jTePrAS+IuXV/AVyA4/GaGDmkRV92rOK+sV33oe2iAcDpLU2RlAZDuiQ3 kHRPURFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ7lU-00000009raq-0XwH; Mon, 17 Jun 2024 08:31:00 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6bQ-00000009aHm-1LWg for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 07:16:34 +0000 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2ec002caeb3so53964771fa.2 for ; Mon, 17 Jun 2024 00:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1718608590; x=1719213390; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gOtB6hLjDe2q1k9n9j8GrerUfufcZavMvVvl5T64NeQ=; b=QD28XMJiDL0QCNMUYaeA/TWaGgxRCWLa0hBjRddBSLDIxkhegj+eyoJjR6F+5qQiyu LQY8PWJZjEMKtURuQKNw+Bu8nXlrYst5d37BqXdkqR8Jq7/qxpxb3wFGFQ4hFO0YqmdT zqVN24xaFO3H44DQII6ryS6aDjgXdTzu9ubeZPvZEC0ScJ+q+xLfJFtg93LSOF/flAdE Nw5dnk3h7J+e5MIPYA6K9hdRZqmFYBc5Tsbn8iNFdJnEqRx+Gfcf3MS+MC73V/45WoTw IApWVCmW5kBbpX2j6aOGA5WCTGK4H+JhSIyikVGgK7y/btfUY4zIXBfkoUfw4S+ghR1V SInA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718608590; x=1719213390; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gOtB6hLjDe2q1k9n9j8GrerUfufcZavMvVvl5T64NeQ=; b=wWILwwfoUWcwNWQbJagHBvUHKsEui/FHTPReGBFUgMklGTZwiOZvcBZV0N1WnRT39w UUkI/hV6kmGCxo72/rZUbWUyqhprxO0HChoMDZNsNs/rLkcHYoSUBFK5POGfFqq+4p7g qPJhEUANYIlRs+vbTYrkWKqu3uZK9XqmHVTXLvFQSxRT69ln4NcS6pLCGPY/4CYDMo98 I/+O40nGcydPgdCrUZYU6ik4ZaaaAu5V1NO+L4qza9mz404t49nHTtt88C0ZjvU0+TQb F5aVKCS+pxir1BpgLL3foeEn02cRSqw/Hjth6oezrKrNiQqLbdkO2rL1Y3rMiX2piHyA 6fbg== X-Forwarded-Encrypted: i=1; AJvYcCX/khPvodOCj+gU+Ksm1dNoDHsY2RRx3aC7lTPekRH7Ku4DYTm6AP1tqJY80EJK9hRMtKKhurPU4s1lZ+CBCisRFuZ14Jttzvu7DQe2oB08ArhpWcQ= X-Gm-Message-State: AOJu0Yy+cQAy7ZtbBEosvJIy+qJgM3MKdQErZ4SLpyYVtUIL2OHGSgCC GnB3GKZoQ8KRZcnzt1WIA1Rd69acE6dRLroSTrcUkcNv0Ughzl/4wkkkk2ozgl0= X-Google-Smtp-Source: AGHT+IHlanuvFDHlcHk0QHuwXweE3e5izwPD+BY+hJiW1cVcoATK8SU76Wd3c4dYNArqQvVGdfRmkA== X-Received: by 2002:a2e:a0d0:0:b0:2ec:30cd:fd7a with SMTP id 38308e7fff4ca-2ec30cdfe89mr4497991fa.49.1718608589940; Mon, 17 Jun 2024 00:16:29 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750acf32sm11244173f8f.49.2024.06.17.00.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 00:16:29 -0700 (PDT) Message-ID: Date: Mon, 17 Jun 2024 10:16:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/12] dt-bindings: mfd: renesas,rzg3s-vbattb: Document VBATTB Content-Language: en-US To: Krzysztof Kozlowski , geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea References: <20240614071932.1014067-1-claudiu.beznea.uj@bp.renesas.com> <20240614071932.1014067-4-claudiu.beznea.uj@bp.renesas.com> <936beb9a-2701-476c-8f5a-4b6b06d4f87d@kernel.org> From: claudiu beznea In-Reply-To: <936beb9a-2701-476c-8f5a-4b6b06d4f87d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_001632_485808_7DA32F5E X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16.06.2024 10:38, Krzysztof Kozlowski wrote: > On 14/06/2024 09:19, Claudiu wrote: >> From: Claudiu Beznea > >> + >> +maintainers: >> + - Claudiu Beznea >> + >> +properties: >> + compatible: >> + items: >> + - const: renesas,rzg3s-vbattb >> + - const: syscon >> + - const: simple-mfd > > No, mfd does no look good. That's not a simple device anymore and you > claim here child does not need vbat bclk, power domains and resets? That > would be a big surprise, although technically possible. I wasn't sure how this MFD will be received by the Renesas maintainers so I kept it simple for this version. In theory the VBAT clk, power domain and resets are specific to VBAT module itself but, indeed, the child cannot work w/o these. > > Please clarify: which of parent resources are needed for children? VBAT clock, power domain are needed. Reset, too. In the current implementation the reset is deasserted though parent by calling the syscon_node_to_regmap(np->parent) in the clock driver. > > ... > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + vbattb: vbattb@1005c000 { >> + compatible = "renesas,rzg3s-vbattb", "syscon", "simple-mfd"; >> + reg = <0x1005c000 0x1000>; >> + ranges = <0 0 0x1005c000 0 0x1000>; >> + interrupts = ; >> + interrupt-names = "tampdi"; >> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>; >> + clock-names = "bclk"; >> + power-domains = <&cpg>; >> + resets = <&cpg R9A08G045_VBAT_BRESETN>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + status = "disabled"; > > Drop Could you please clarify this? Would you want me to drop the full node (same for clock-controller node)? Can you point me an example that you are thinking about? Thank you, Claudiu Beznea > >> + >> + vbattclk: clock-controller@1c { >> + compatible = "renesas,rzg3s-vbattb-clk"; >> + reg = <0 0x1c 0 0x10>; >> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>; >> + clock-names = "bclk", "vbattb_xtal"; >> + #clock-cells = <0>; >> + power-domains = <&cpg>; >> + status = "disabled"; > > Drop > >> + }; >> + }; >> + >> +... > > Best regards, > Krzysztof >