From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Marek Vasut <marex@denx.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
Alexandre Torgue <alexandre.torgue@st.com>,
Patrick Delaunay <patrick.delaunay@st.com>,
Patrice Chotard <patrice.chotard@st.com>
Subject: Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
Date: Thu, 14 Jan 2021 16:11:25 +0100 [thread overview]
Message-ID: <c893ad3e-dba2-e1b2-ed7a-24937532d0e6@foss.st.com> (raw)
In-Reply-To: <20201229175521.268234-1-marex@denx.de>
Hi Marek
On 12/29/20 6:55 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
>
> Fixes: ac68793f49de ("ARM: dts: stm32: Add DHCOM based PicoITX board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> index 25528a1c096f..757707766fa0 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> @@ -49,7 +49,7 @@ &gpioa {
> */
> usb-port-power-hog {
On my tree this node is "usb-port-power". Do you want to update the node
name too ? I can do it directly during the merge if you want.
(Note, it is the case for DRC02 hog update).
regards
alex
> gpio-hog;
> - gpios = <13 GPIO_ACTIVE_LOW>;
> + gpios = <13 0>;
> output-low;
> line-name = "usb-port-power";
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-14 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 17:55 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2020-12-29 17:55 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
2021-01-14 15:11 ` Alexandre TORGUE [this message]
2021-01-14 17:08 ` [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-14 17:11 ` Alexandre TORGUE
2021-01-14 17:13 ` Marek Vasut
2021-01-14 17:37 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c893ad3e-dba2-e1b2-ed7a-24937532d0e6@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=patrice.chotard@st.com \
--cc=patrick.delaunay@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox