From: Stephen Boyd <sboyd@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
andrew@codeconstruct.com.au, conor+dt@kernel.org,
devicetree@vger.kernel.org, dmitry.baryshkov@linaro.org,
joel@jms.id.au, krzk+dt@kernel.org, lee@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
p.zabel@pengutronix.de, robh@kernel.org
Subject: RE: [PATCH v7 3/3] clk: aspeed: add AST2700 clock driver.
Date: Fri, 06 Dec 2024 14:15:47 -0800 [thread overview]
Message-ID: <c898338622625cbfc825e8d4cc5f0fff.sboyd@kernel.org> (raw)
In-Reply-To: <OS8PR06MB75418449B451224C5AB46FBFF2302@OS8PR06MB7541.apcprd06.prod.outlook.com>
Quoting Ryan Chen (2024-12-04 16:48:42)
> > > struct ast2700_clk_info {
> > > const char *name;
> > > u8 clk_idx;
> > > u32 reg;
> > > u32 type;
> > > union {
> > > struct ast2700_clk_fixed_factor_data factor;
> > > struct ast2700_clk_fixed_rate_data rate;
> > > struct ast2700_clk_gate_data gate;
> > > struct ast2700_clk_div_data div;
> > > struct ast2700_clk_pll_data pll;
> > > struct ast2700_clk_mux_data mux;
> > > } data;
> > > };
> > >
> > > struct ast2700_clk_div_data {
> > > const struct clk_div_table *div_table;
> > > const struct clk_parent_data *parent;
> > > u8 bit_shift;
> > > u8 bit_width;
> > > u32 reg;
> > > };
> > >
> > > static const struct ast2700_clk_info ast2700_scu0_clk_info[]
> > > __initconst = { ...........................
> > > DIVIDER_CLK(SCU0_CLK_AHB, "soc0-ahb", soc0_ahbmux,
> >
> > Can you also show what soc0_ahbmux is?
> It will be following.
>
> static const struct clk_parent_data soc0_ahbmux[] = {
> { .fw_name = "soc0-ahbmux", .name = "soc0-ahbmux" },
> };
Instead of that, please use only the index.
static const struct clk_parent_data soc0_ahbmux[] = {
{ .index = <number from DT binding> },
};
next prev parent reply other threads:[~2024-12-06 22:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 5:30 [PATCH v7 0/3] [PATCH v6 0/3] Add support for AST2700 clk driver Ryan Chen
2024-10-28 5:30 ` [PATCH v7 1/3] dt-bindings: mfd: aspeed: support for AST2700 Ryan Chen
2024-10-28 5:30 ` [PATCH v7 2/3] reset: aspeed: register AST2700 reset auxiliary bus device Ryan Chen
2024-10-28 5:30 ` [PATCH v7 3/3] clk: aspeed: add AST2700 clock driver Ryan Chen
2024-10-30 21:01 ` Stephen Boyd
2024-10-31 7:24 ` Ryan Chen
2024-11-21 23:06 ` Stephen Boyd
2024-12-02 3:12 ` Ryan Chen
2024-12-04 23:24 ` Stephen Boyd
2024-12-05 0:48 ` Ryan Chen
2024-12-06 22:15 ` Stephen Boyd [this message]
2024-12-09 1:49 ` Ryan Chen
2024-10-30 21:02 ` Stephen Boyd
2024-10-31 0:44 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c898338622625cbfc825e8d4cc5f0fff.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).