From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72BA8C48BC4 for ; Sat, 17 Feb 2024 11:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dxc2ovSoSSMV6/iIN4gNboxEgbRNvIJD0nFGiuj+jHs=; b=uYsvVIHiUYfKag GdRS3RAY2FgfQBl1sn1jPfgR9JqW17CP3I/gqpei33yR46VoV52MBOqYJioue53PzUT1yZ7XqJyaz zDmOUfgkCJpDxw/q3e6pf3yAmq9oiOGoeIODiwr+rOe6B4FawSve3nUQxyfMW2GtxPJZZoIL1Lxlk L8AiwhA6BaBbIyVyC1UVpBgSR9WlbZWuUuIF25mmTAT1RIEgs3LsFFYf1ycvyH6LVFMrRgx01SN2v Td7R5TOAJhIow4YNW7mVCcC7tgZUaGwiB4Bk6NSxL6SXowAmEyt/AFMcZ7//bxCjDL3kTBR9aFhcv vuEepUv2qFriNNxr+G6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbIxC-00000005ZNM-0Lua; Sat, 17 Feb 2024 11:33:58 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbHoP-00000005M5y-1WrP for linux-arm-kernel@bombadil.infradead.org; Sat, 17 Feb 2024 10:20:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=s2HtFC7DBy8UXBSfjJEWGOAW/7YBWZq1oTJW9cuFiD8=; b=Xv+VJ0rRMK3UcDmcC5kAVU7UfT txyJtLmHEkip49UIuVYAq8nYVJUWi+StWL0KdkCKeYE4M433nKysPsM9sqjiUasrlInD/OxSBMhNG kI3rSqmGsR62YnhbVe5ThpQnrqHdgPb1DY2FORlAcV5AzoyS74Cwc8Q7b80NfJ5DxEWej0mmqucev 3+O0h79vJb5zX6qHR8yyl8AKeWKXHCL1a9ABN7jefe513614Y+KhJexL6UcW+aYoh0RNErtAZn5VW F2GlDUFEAdlNcbU5Mqc5kgfm5TjdkuQvLXjnzGADc3tjWnBbKzSQuxnAF3EqoRUTGF75xxStO0pMd f4rhMNZg==; Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbHoI-00000000JUm-1MWy for linux-arm-kernel@lists.infradead.org; Sat, 17 Feb 2024 10:20:47 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-511898b6c9eso3596564e87.3 for ; Sat, 17 Feb 2024 02:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708165240; x=1708770040; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s2HtFC7DBy8UXBSfjJEWGOAW/7YBWZq1oTJW9cuFiD8=; b=p+whoCI7/amCiilPpITiTeS1ycV5j/oIM1b+lhw9vwvy7jpmYUiJ7XVVfUAgmvuJ64 22nc0JXweJlZOePi7u7jC28JSU4Ye714Tpke0m3yYU4KrjhN/3jyfLOKkFh0H94u4ol+ 1uhu1jOAxvHeKUu1sd4XIv7LQkSMRFXMrA+53ZUV6kC+RZ366XSKW66PjU+GEQ1Lv5hi mcUzblee24xOwGibAecjoFMCXdzefpPUuA0NTUa4GySfHRdXcSDT1EC0S2mOlC2vtAM1 H+9x2/czexQJoWL5tOWRcXbJYmsdakJRe26T+v+vz91Y47xNXl0VfRy5xKKOIY9JdvC6 h/JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708165240; x=1708770040; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s2HtFC7DBy8UXBSfjJEWGOAW/7YBWZq1oTJW9cuFiD8=; b=PEkpS5iwz+2nlKujYEit83vC0WA/UCjyGbdx+b1uSFtV6zLjZk1Hy7a5GCHMei5n1F tETq/BjuQioUdTInEvYHNVNc4hrWPOUjUCBaFo65dUe4DUWWDg5ScRGZc1Sfv/EG50vi FgY1kgVOYwrXHc99DIe6yfUCeQNBMYUgE89K2DkrxvWtBugrD66h6xE671YEqWCsfq3c hanvhu9zaFzOo4delFLcXJosG5/Gmt0Clge5TDLMLKPLiwlQJ0uI97hNU395R96OczaP YNNN2fuRxeT4utqs33862rZ/O2XK8TgsLo74Pnip/e5wUpPS+BGjs/VYBk4rDgRHsPEF RMjw== X-Forwarded-Encrypted: i=1; AJvYcCWkeqbE2WA9fxUXOdXjIO0fIBMRHFp8/oCPfV+w7sX24CBIf/9fx5jGrQ4IoE4hHQ/yI31F3j7Dei2l6w5cmfbn6AT/kT4k2hIEgfq1cMd1W85eFuA= X-Gm-Message-State: AOJu0Yy2QE4gxFS33iqKuCd4ZA18kPf1Gsyh2cZL1KWbj9/FAMBGhx20 dhmXcM/gIiPDnjPjHgGN4p3ewC1NX9UJyPPfJD2s3oAi9hmjOruGIJw529p7aQU= X-Google-Smtp-Source: AGHT+IGquEMz25c27Vj8Gouis+jAtB47ep+KUh3aTYNC/omQeZjhA/tjbci6BdSMco6nb5Jdb83Gdw== X-Received: by 2002:a19:ca42:0:b0:511:a100:b30d with SMTP id h2-20020a19ca42000000b00511a100b30dmr4502876lfj.56.1708165240313; Sat, 17 Feb 2024 02:20:40 -0800 (PST) Received: from [192.168.0.22] ([78.10.207.130]) by smtp.gmail.com with ESMTPSA id m5-20020a1709061ec500b00a3d669a2055sm855029ejj.88.2024.02.17.02.20.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Feb 2024 02:20:39 -0800 (PST) Message-ID: Date: Sat, 17 Feb 2024 11:20:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] clk: rockchip: rst-rk3588: Add BIU reset Content-Language: en-US To: Shreeya Patel Cc: heiko@sntech.de, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, jose.abreu@synopsys.com, nelson.costa@synopsys.com, dmitry.osipenko@collabora.com, sebastian.reichel@collabora.com, shawn.wen@rock-chips.com, kernel@collabora.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-dt@vger.kernel.org, linux-arm@lists.infradead.org References: <20240216094922.257674-1-shreeya.patel@collabora.com> <20240216094922.257674-2-shreeya.patel@collabora.com> <237e690a-2f49-4046-b054-3a878eed6748@linaro.org> <30d2-65cf5980-3-2ec9f500@242931553> <0c2f4d92-afa9-46f1-844e-994bd45924ef@linaro.org> <1b9-65d08800-3-19290580@120474537> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <1b9-65d08800-3-19290580@120474537> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240217_102043_530256_8E0FE890 X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/02/2024 11:18, Shreeya Patel wrote: > On Saturday, February 17, 2024 13:47 IST, Krzysztof Kozlowski wrote: > >> On 16/02/2024 13:48, Shreeya Patel wrote: >>> On Friday, February 16, 2024 15:33 IST, Krzysztof Kozlowski wrote: >>> >>>> On 16/02/2024 10:49, Shreeya Patel wrote: >>>>> Export hdmirx_biu soft reset id which is required by the hdmirx controller. >>>>> >>>>> Signed-off-by: Shreeya Patel >>>>> --- >>>>> drivers/clk/rockchip/rst-rk3588.c | 1 + >>>>> include/dt-bindings/reset/rockchip,rk3588-cru.h | 2 ++ >>>> >>>> Please run scripts/checkpatch.pl and fix reported warnings. Some >>>> warnings can be ignored, but the code here looks like it needs a fix. >>>> Feel free to get in touch if the warning is not clear. >>>> >>>> Please do internal review. The internal Collabora review would tell you: >>>> YOU MUST run checkpatch. Then you see errors, so why do you send patch >>>> with errors to the mailing list? >>>> >>> >>> I am sorry but what errors are you talking about? >>> I don't see any errors reported by checkpatch :- >>> >>> shreeya@shreeya:~/collabora/rd/rockchip/torvalds$ ./scripts/checkpatch.pl hdmirx/0001-clk-rockchip-rst-rk3588-Add-BIU-reset.patch >>> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst >> >> Here. >> >>> >>> total: 0 errors, 1 warnings, 13 lines checked >>> >>> NOTE: For some of the reported defects, checkpatch may be able to >>> mechanically convert to the typical style using --fix or --fix-inplace. >>> >>> hdmirx-v1-1602/0001-clk-rockchip-rst-rk3588-Add-BIU-reset.patch has style problems, please review. >>> >>> I see the above warning but that looks like a false positive to me. >> >> Why for your patch it would be false positive and for all others would not? >> > > OK, now I see what you meant. Since we are touching the include file and C file together, this warning was generated. > It was a bit confusing to interpret this as the warning also talks about Documentation which we didn't touch at all. Really, no documentation touching? Care to check the full path of the files you are changing? > > Anyway, I will create two separate patches for this in v2. I think rules cannot be clearer: https://elixir.bootlin.com/linux/v6.8-rc4/source/Documentation/devicetree/bindings/submitting-patches.rst#L13 Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel