From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: broonie@kernel.org, Wentao Liang <vulab@iscas.ac.cn>
Cc: herve.codina@bootlin.com, leoyang.li@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
qiang.zhao@nxp.com, stable@vger.kernel.org
Subject: Re: [PATCH] soc: fsl: cpm1: tsa: Fix clock leak in tsa_of_parse_tdms()
Date: Fri, 9 Oct 2026 11:21:29 +0200 [thread overview]
Message-ID: <c8e47d1d-1487-4f51-a858-cb66b5f8c808@kernel.org> (raw)
In-Reply-To: <178972077003.546774.17878987805855996127.b4-ty@kernel.org>
Le 18/09/2026 à 10:39, Christophe Leroy (CS GROUP) a écrit :
>
> On Thu, 17 Sep 2026 15:27:19 +0000, Wentao Liang wrote:
>> The error cleanup loop puts l1rsync_clk and l1rclk_clk a second time
>> and never puts l1tsync_clk or l1tclk_clk, because the branches that
>> guard the transmit clocks use the receive clock field names.
>>
>> Use the matching field in each branch so every clock acquired by
>> tsa_of_parse_tdms() is released exactly once.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] soc: fsl: cpm1: tsa: Fix clock leak in tsa_of_parse_tdms()
> commit: 7b3b0598c00e67f2df85d0b4cd99eaa3be6c9bfd
>
> Best regards,
For your information, I folded in this patch a similar fix to
tsa_remove() function.
Christophe
prev parent reply other threads:[~2026-10-09 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 15:27 [PATCH] soc: fsl: cpm1: tsa: Fix clock leak in tsa_of_parse_tdms() Wentao Liang
2026-09-17 17:49 ` Herve Codina
2026-09-18 8:39 ` Christophe Leroy (CS GROUP)
2026-10-09 9:21 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8e47d1d-1487-4f51-a858-cb66b5f8c808@kernel.org \
--to=chleroy@kernel.org \
--cc=broonie@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox