From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61CBC433DB for ; Mon, 11 Jan 2021 15:45:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3962820897 for ; Mon, 11 Jan 2021 15:45:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3962820897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To: Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1QgvkjbjSGX3hVcgKNZJK5JAWnw6XNTVp2AxIDFfmK8=; b=mcG5mM5ShZ3PmHpSYuOVAQdNi vp9/meKbiROlV6NJaDNvBoilSrg3mwrSdpjF3XF6uTp5K+nwzj1hvKZPdC21YGLHkQAq3BDsgL2aR VNGAzIkn+uFhR01W/gOFldd3DdKaiuxZVVopDL6Rd2yMSHMGNhLmr3jK5gzrcNRik5AWWdRMXa5g9 R+GswpXFF/T2+acOE/8MSC3GZIs+q+Dz7iv8/rE8gcjS1ueX1Knbj972/KggbKz/7mdXOb74HXZKo Znm7Ic7rlMvOpbiU6l00J+n+25EaVz+vqetWplAXaKZUHdpEEnhiG2hRl+j1gIZRsfYWId39QMBIm xJF79CyrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyzMX-00060u-4B; Mon, 11 Jan 2021 15:44:09 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyzMR-0005yb-Fk; Mon, 11 Jan 2021 15:44:04 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 56DB1AB3E; Mon, 11 Jan 2021 15:44:01 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 0/3] A trio of vchiq bulk transfer fixes From: Nicolas Saenz Julienne To: Phil Elwell , Greg Kroah-Hartman , Arnd Bergmann , Dan Carpenter , Stefan Wahren , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org Date: Mon, 11 Jan 2021 16:43:59 +0100 In-Reply-To: <20210105162030.1415213-1-phil@raspberrypi.com> References: <20210105162030.1415213-1-phil@raspberrypi.com> User-Agent: Evolution 3.38.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_104403_656558_F5CFAA06 X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3660222533635310120==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3660222533635310120== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-vWevdPEfOrfcmx1Agg/s" --=-vWevdPEfOrfcmx1Agg/s Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-01-05 at 16:20 +0000, Phil Elwell wrote: > The recent batch of vchiq improvements broke bulk transfers in two ways: >=20 > 1. The userdata associated with a transfer was lost in the case that a > =C2=A0=C2=A0=C2=A0non-blocking mode was used. >=20 > 2. The 64-bit ioctl compatibility shim for a bulk transfer used the > =C2=A0=C2=A0=C2=A0wrong ioctl command. >=20 > This patch set fixes both of those bugs, and adds a security-related > note to the TODO file. >=20 > Changes in v2: > - Expand the commit message on patch 1 to clarify the impact of the > =C2=A0=C2=A0bug, and add Tested-by. > - Add commit 3 with an additional TODO item. > - Change the name of the patch set to be numerically accurate. >=20 > Phil Elwell (3): > =C2=A0=C2=A0staging: vchiq: Fix bulk userdata handling > =C2=A0=C2=A0staging: vchiq: Fix bulk transfers on 64-bit builds > =C2=A0=C2=A0staging: vc04_services: Add a note to the TODO >=20 > =C2=A0drivers/staging/vc04_services/interface/TODO | 4 +++= + > =C2=A0.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++= +-- > =C2=A02 files changed, 8 insertions(+), 2 deletions(-) >=20 Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas --=-vWevdPEfOrfcmx1Agg/s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl/8ckAACgkQlfZmHno8 x/4eBAf9HsjeqowbAXSubi5234uRVGWJuSN3HyNrJ3tMPSVKRBn3TqeY6FcIkcwQ G+oTMN0u2TsQs4d6o2JaxFm83Ioih0hsSGxM9bWQp/STALmiZRpeNe27gLYcxYki +tZsbEln+9Gbfn/JakiR+UqD7DlN4lr113MVAc4iDAYpu1VfGEFwZRkeD7sJzcbs GYrzbJ/Ws0FhrrCzEvc00nRJ4hwLEUb+tQyMPQd3X4JEiOLpq/nE+TaUI2Y9A5rd u78ZoI58BMRh5GloHYzh7tS8RdhxM0LfJ2w5aIzWkdHOTU0QRKCJSlZZXSB1fkyl 6chDk0vgdVUSXmAzDFsSo0vZVLcT/w== =aqSe -----END PGP SIGNATURE----- --=-vWevdPEfOrfcmx1Agg/s-- --===============3660222533635310120== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3660222533635310120==--