From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62F6CC25B78 for ; Tue, 4 Jun 2024 12:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N/c0mKazM7FQfKrY5zYL+gnlEKeTwDJ2w4cK0rEGd2g=; b=Cjmic31hu1wIrj XlhypN/hsJo2yyUFrjBTQlKY3ru1OY9FUPlLm0yM6j6Pj1eGp495A8U3vwYCMD7IQVi6S7cE2/8n5 vEPB+HT3uVIYPm9MCZGFDrVGIgJWtQzOSYVk0S/v2sQPjA9SBzKioMeAagyRT6JfCLoj6Y5Z4RIj8 I2l3e2VDjMU0n+Z08cSSvUuIKbeHN8AdqjXDbqXJ1e+802Eg6cPH3GRjcFEG6UWSwZBJ7YSH6eed/ 8IGD71RweE603+DSrc9hOFFOiYcKNwCUZwZKfdDUlRoLXoESnKervoVxMrYawwevy8YvgNSeXvq1n AzYFg0sgAmTe/agEvBwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sETDY-00000002GOT-2zBD; Tue, 04 Jun 2024 12:24:45 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sETDU-00000002GNw-3g6L; Tue, 04 Jun 2024 12:24:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1717503877; bh=Lv9Ndc3v7OplGgEuObrkLWF5jfo0VwmttjMAF0BC7Yg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=wYr4Iky7YMflG9JtezhvZtRBcZeFnpjwTSMcpN+b5X5cESTbE3GoiK7IFx9Qgw/sQ 6d/NUKDtM1reDJRZotpXohQC2N+7opEJiqseoukugOvnse6Pin5MpMgeMq8uE9ArWm nm6OvNACcVFYGZjjGCpXQeR0nh9owN2hSJyo0pzFNRuc2p5Xvla51cRS9SsWa47dRv 74xee2CHTTmMsHkw4kY6reOt9KRaq1hWuass2Ls5E9iobh8YQbegJhA78kHlJ3020W KF2vtCtt/JUF8+Fi2QdtGbtYEHbuQoPVrpeIUeD6ZE86udgWVwzvyU3+V//duffumK pACLCgDn2sBPQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 2C687378214D; Tue, 4 Jun 2024 12:24:36 +0000 (UTC) Message-ID: Date: Tue, 4 Jun 2024 14:24:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] dt-bindings: iio: adc: Add MediaTek MT6359 PMIC AUXADC To: Krzysztof Kozlowski , jic23@kernel.org Cc: lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lee@kernel.org, andy@kernel.org, nuno.sa@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, marius.cristea@microchip.com, marcelo.schmitt@analog.com, fr0st61te@gmail.com, mitrutzceclan@gmail.com, mike.looijmans@topic.nl, marcus.folkesson@gmail.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com References: <20240530093410.112716-1-angelogioacchino.delregno@collabora.com> <20240530093410.112716-2-angelogioacchino.delregno@collabora.com> <0d7d9f61-2590-4c72-9498-dc6540b571d5@kernel.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <0d7d9f61-2590-4c72-9498-dc6540b571d5@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_052441_150729_EB7A7462 X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 04/06/24 11:38, Krzysztof Kozlowski ha scritto: > On 04/06/2024 10:55, AngeloGioacchino Del Regno wrote: >> Il 01/06/24 17:32, Krzysztof Kozlowski ha scritto: >>> On 30/05/2024 11:34, AngeloGioacchino Del Regno wrote: >>>> Add a new binding for the MT6350 Series (MT6357/8/9) PMIC AUXADC, >>>> providing various ADC channels for both internal temperatures and >>>> voltages, audio accessory detection (hp/mic/hp+mic and buttons, >>>> usually on a 3.5mm jack) other than some basic battery statistics >>>> on boards where the battery is managed by this PMIC. >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno >>>> --- >>>> .../iio/adc/mediatek,mt6359-auxadc.yaml | 43 +++++++++++++++++++ >>>> .../iio/adc/mediatek,mt6357-auxadc.h | 21 +++++++++ >>>> .../iio/adc/mediatek,mt6358-auxadc.h | 22 ++++++++++ >>>> .../iio/adc/mediatek,mt6359-auxadc.h | 22 ++++++++++ >>>> 4 files changed, 108 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml >>>> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6357-auxadc.h >>>> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6358-auxadc.h >>>> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6359-auxadc.h >>>> >>>> diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml >>>> new file mode 100644 >>>> index 000000000000..dd6c331905cf >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml >>>> @@ -0,0 +1,43 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/iio/adc/mediatek,mt6359-auxadc.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: MediaTek MT6350 series PMIC AUXADC >>>> + >>>> +maintainers: >>>> + - AngeloGioacchino Del Regno >>>> + >>>> +description: >>>> + The Auxiliary Analog/Digital Converter (AUXADC) is an ADC found >>>> + in some MediaTek PMICs, performing various PMIC related measurements >>>> + such as battery and PMIC internal voltage regulators temperatures, >>>> + accessory detection resistance (usually, for a 3.5mm audio jack) >>>> + other than voltages for various PMIC internal components. >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - mediatek,mt6357-auxadc >>>> + - mediatek,mt6358-auxadc >>>> + - mediatek,mt6359-auxadc >>>> + >>>> + "#io-channel-cells": >>>> + const: 1 >>>> + >>>> +additionalProperties: false >>> >>> If there is going to be a re-spin, please move this below required: block. >>> >> >> Yep, will do. Fixed up for v2. >> >>>> + >>>> +required: >>>> + - compatible >>>> + - "#io-channel-cells" >>>> + >>>> +examples: >>>> + - | >>>> + pmic { >>>> + pmic_adc: adc { >>>> + compatible = "mediatek,mt6359-auxadc"; >>>> + #io-channel-cells = <1>; >>>> + }; >>> >>> This suggests that you should grow (make complete) the parent PMIC example. >> >> Uhm, should I instead add that to bindings/mfd/mediatek,mt6357.yaml and avoid >> growing the parent example? > > No. You should avoid this example and grow the parent example. Not avoid > parent example... > I will remove examples from here and move the example that I wrote in here to mediatek,mt6357.yaml. >> >> adc: >> type: object >> $ref: /schemas/iio/adc/mediatek,mt6359-auxadc.yaml >> unevaluatedProperties: false >> >>> >>> Actually having this as a separate node is not really needed. Why it >>> cannot be just part of the MFD/parent node? >>> >> >> (glossary: PWRAP = PMIC [SPI] WRAPper) >> >> The top node is the PWRAP, an IP that is (mostly) used to dispatch commands to >> the PMIC, but the AUXADC is not integrated into the PWRAP, but into the PMIC. > > Eh? mediatek,mt6357.yaml says it is a PMIC... > Eh, apparently my brain cells are somewhere else today. I was thinking about the HW, and some synapse got disconnected in the process, lol. Just pretend I never wrote this useless wall of text, sorry. Ugh :-) Cheers, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel